From: Serge Semin <fancer.lancer@gmail.com> To: Brad Larson <blarson@amd.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, brendan.higgins@linux.dev, briannorris@chromium.org, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, skhan@linuxfoundation.org, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, tonyhuang.sunplus@gmail.com, ulf.hansson@linaro.org, vaishnav.a@ti.com, will@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v11 04/15] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller Date: Mon, 13 Mar 2023 00:42:04 +0300 [thread overview] Message-ID: <20230312214204.sjycq3xyk56ny2on@mobilestation> (raw) In-Reply-To: <20230312004445.15913-5-blarson@amd.com> On Sat, Mar 11, 2023 at 04:44:34PM -0800, Brad Larson wrote: > The AMD Pensando Elba SoC has integrated the DW APB SPI Controller > > Signed-off-by: Brad Larson <blarson@amd.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > v10 changes: > - Move definition of amd,pensando-elba-syscon into properties > with a better description > - Add amd,pensando-elba-syscon: false for non elba designs > > v9 changes: > - Define property amd,pensando-elba-syscon > - Move compatible amd,pensando-elba-spi ahead of baikal,bt1-ssi > > --- > .../bindings/spi/snps,dw-apb-ssi.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index a132b5fc56e0..2383d6497b1e 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -37,6 +37,17 @@ allOf: > else: > required: > - interrupts > + - if: > + properties: > + compatible: > + contains: > + const: amd,pensando-elba-spi > + then: > + required: > + - amd,pensando-elba-syscon > + else: > + properties: > + amd,pensando-elba-syscon: false > > properties: > compatible: > @@ -63,6 +74,8 @@ properties: > const: intel,keembay-ssi > - description: Intel Thunder Bay SPI Controller > const: intel,thunderbay-ssi > + - description: AMD Pensando Elba SoC SPI Controller > + const: amd,pensando-elba-spi > - description: Baikal-T1 SPI Controller > const: baikal,bt1-ssi > - description: Baikal-T1 System Boot SPI Controller > @@ -136,6 +149,12 @@ properties: > of the designware controller, and the upper limit is also subject to > controller configuration. > > + amd,pensando-elba-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | ^ +--------------+ This + modifier is redundant. > + Block address to control SPI chip-selects. The Elba SoC > + does not use ssi. ^ | 1. Drop one of the whitespaces ---------------------+ 2. The description is misleading. SSI means "Synchronous Serial Interface" which basically means SPI. If you meant SS (slave-select) signals then Elba SoC do use them. What would sound correctly here is that Elba SoC system controller provides an interface to override the native DWC SSI CS control. Please fix the notes above. Then feel free to add Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > + > patternProperties: > "^.*@[0-9a-f]+$": > type: object > -- > 2.17.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Serge Semin <fancer.lancer@gmail.com> To: Brad Larson <blarson@amd.com> Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, linux-spi@vger.kernel.org, adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, brendan.higgins@linux.dev, briannorris@chromium.org, brijeshkumar.singh@amd.com, catalin.marinas@arm.com, davidgow@google.com, gsomlo@gmail.com, gerg@linux-m68k.org, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee@kernel.org, lee.jones@linaro.org, broonie@kernel.org, yamada.masahiro@socionext.com, p.zabel@pengutronix.de, piotrs@cadence.com, p.yadav@ti.com, rdunlap@infradead.org, robh+dt@kernel.org, samuel@sholland.org, skhan@linuxfoundation.org, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, tonyhuang.sunplus@gmail.com, ulf.hansson@linaro.org, vaishnav.a@ti.com, will@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v11 04/15] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller Date: Mon, 13 Mar 2023 00:42:04 +0300 [thread overview] Message-ID: <20230312214204.sjycq3xyk56ny2on@mobilestation> (raw) In-Reply-To: <20230312004445.15913-5-blarson@amd.com> On Sat, Mar 11, 2023 at 04:44:34PM -0800, Brad Larson wrote: > The AMD Pensando Elba SoC has integrated the DW APB SPI Controller > > Signed-off-by: Brad Larson <blarson@amd.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > > v10 changes: > - Move definition of amd,pensando-elba-syscon into properties > with a better description > - Add amd,pensando-elba-syscon: false for non elba designs > > v9 changes: > - Define property amd,pensando-elba-syscon > - Move compatible amd,pensando-elba-spi ahead of baikal,bt1-ssi > > --- > .../bindings/spi/snps,dw-apb-ssi.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > index a132b5fc56e0..2383d6497b1e 100644 > --- a/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > +++ b/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > @@ -37,6 +37,17 @@ allOf: > else: > required: > - interrupts > + - if: > + properties: > + compatible: > + contains: > + const: amd,pensando-elba-spi > + then: > + required: > + - amd,pensando-elba-syscon > + else: > + properties: > + amd,pensando-elba-syscon: false > > properties: > compatible: > @@ -63,6 +74,8 @@ properties: > const: intel,keembay-ssi > - description: Intel Thunder Bay SPI Controller > const: intel,thunderbay-ssi > + - description: AMD Pensando Elba SoC SPI Controller > + const: amd,pensando-elba-spi > - description: Baikal-T1 SPI Controller > const: baikal,bt1-ssi > - description: Baikal-T1 System Boot SPI Controller > @@ -136,6 +149,12 @@ properties: > of the designware controller, and the upper limit is also subject to > controller configuration. > > + amd,pensando-elba-syscon: > + $ref: /schemas/types.yaml#/definitions/phandle-array > + description: | ^ +--------------+ This + modifier is redundant. > + Block address to control SPI chip-selects. The Elba SoC > + does not use ssi. ^ | 1. Drop one of the whitespaces ---------------------+ 2. The description is misleading. SSI means "Synchronous Serial Interface" which basically means SPI. If you meant SS (slave-select) signals then Elba SoC do use them. What would sound correctly here is that Elba SoC system controller provides an interface to override the native DWC SSI CS control. Please fix the notes above. Then feel free to add Reviewed-by: Serge Semin <fancer.lancer@gmail.com> -Serge(y) > + > patternProperties: > "^.*@[0-9a-f]+$": > type: object > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-12 21:42 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-03-12 0:44 [PATCH v11 00/15] Support AMD Pensando Elba SoC Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 01/15] dt-bindings: arm: add AMD Pensando boards Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 02/15] dt-bindings: mmc: cdns: Add AMD Pensando Elba SoC Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 20:57 ` Krzysztof Kozlowski 2023-03-12 20:57 ` Krzysztof Kozlowski 2023-03-12 0:44 ` [PATCH v11 03/15] dt-bindings: spi: cdns: Add compatible for " Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 20:57 ` Krzysztof Kozlowski 2023-03-12 20:57 ` Krzysztof Kozlowski 2023-03-12 0:44 ` [PATCH v11 04/15] dt-bindings: spi: dw: Add AMD Pensando Elba SoC SPI Controller Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 21:42 ` Serge Semin [this message] 2023-03-12 21:42 ` Serge Semin 2023-03-12 0:44 ` [PATCH v11 05/15] dt-bindings: soc: amd: amd,pensando-elba-ctrl: Add Pensando SoC Controller Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 20:58 ` Krzysztof Kozlowski 2023-03-12 20:58 ` Krzysztof Kozlowski 2023-03-12 0:44 ` [PATCH v11 06/15] MAINTAINERS: Add entry for AMD PENSANDO Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 07/15] arm64: Add config for AMD Pensando SoC platforms Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 08/15] arm64: dts: Add AMD Pensando Elba SoC support Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 09/15] spi: cadence-quadspi: Add compatible for AMD Pensando Elba SoC Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 10/15] spi: dw: Add support " Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 21:16 ` Serge Semin 2023-03-12 21:16 ` Serge Semin 2023-03-12 0:44 ` [PATCH v11 11/15] mmc: sdhci-cadence: Enable device specific override of writel() Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 12/15] mmc: sdhci-cadence: Support device specific init during probe Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 13/15] mmc: sdhci-cadence: Add AMD Pensando Elba SoC support Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 14/15] mmc: sdhci-cadence: Support mmc hardware reset Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 0:44 ` [PATCH v11 15/15] soc: amd: Add support for AMD Pensando SoC Controller Brad Larson 2023-03-12 0:44 ` Brad Larson 2023-03-12 2:08 ` kernel test robot 2023-03-12 2:08 ` kernel test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230312214204.sjycq3xyk56ny2on@mobilestation \ --to=fancer.lancer@gmail.com \ --cc=adrian.hunter@intel.com \ --cc=alcooperx@gmail.com \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=blarson@amd.com \ --cc=brendan.higgins@linux.dev \ --cc=briannorris@chromium.org \ --cc=brijeshkumar.singh@amd.com \ --cc=broonie@kernel.org \ --cc=catalin.marinas@arm.com \ --cc=davidgow@google.com \ --cc=devicetree@vger.kernel.org \ --cc=gerg@linux-m68k.org \ --cc=gsomlo@gmail.com \ --cc=krzk@kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=lee.jones@linaro.org \ --cc=lee@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=p.yadav@ti.com \ --cc=p.zabel@pengutronix.de \ --cc=piotrs@cadence.com \ --cc=rdunlap@infradead.org \ --cc=robh+dt@kernel.org \ --cc=samuel@sholland.org \ --cc=skhan@linuxfoundation.org \ --cc=suravee.suthikulpanit@amd.com \ --cc=thomas.lendacky@amd.com \ --cc=tonyhuang.sunplus@gmail.com \ --cc=ulf.hansson@linaro.org \ --cc=vaishnav.a@ti.com \ --cc=will@kernel.org \ --cc=yamada.masahiro@socionext.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.