From: Douglas Anderson <dianders@chromium.org>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: devicetree@vger.kernel.org, cros-qcom-dts-watchers@chromium.org,
linux-arm-msm@vger.kernel.org,
yangcong5@huaqin.corp-partner.google.com,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Douglas Anderson <dianders@chromium.org>,
linux-input@vger.kernel.org, hsinyi@google.com
Subject: [PATCH 4/9] HID: i2c-hid: Switch to SYSTEM_SLEEP_PM_OPS()
Date: Tue, 23 May 2023 12:27:58 -0700 [thread overview]
Message-ID: <20230523122802.4.Ib2a2865bd3c0b068432259dfc7d76cebcbb512be@changeid> (raw)
In-Reply-To: <20230523193017.4109557-1-dianders@chromium.org>
The SYSTEM_SLEEP_PM_OPS() allows us to get rid of '#ifdef
CONFIG_PM_SLEEP', as talked about in commit 1a3c7bb08826 ("PM: core:
Add new *_PM_OPS macros, deprecate old ones").
This change is expected to have no functional effect.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index efbba0465eef..19d985c20a5c 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -1085,7 +1085,6 @@ void i2c_hid_core_shutdown(struct i2c_client *client)
}
EXPORT_SYMBOL_GPL(i2c_hid_core_shutdown);
-#ifdef CONFIG_PM_SLEEP
static int i2c_hid_core_suspend(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
@@ -1138,10 +1137,9 @@ static int i2c_hid_core_resume(struct device *dev)
return hid_driver_reset_resume(hid);
}
-#endif
const struct dev_pm_ops i2c_hid_core_pm = {
- SET_SYSTEM_SLEEP_PM_OPS(i2c_hid_core_suspend, i2c_hid_core_resume)
+ SYSTEM_SLEEP_PM_OPS(i2c_hid_core_suspend, i2c_hid_core_resume)
};
EXPORT_SYMBOL_GPL(i2c_hid_core_pm);
--
2.40.1.698.g37aff9b760-goog
WARNING: multiple messages have this Message-ID (diff)
From: Douglas Anderson <dianders@chromium.org>
To: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sam Ravnborg <sam@ravnborg.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
hsinyi@google.com, devicetree@vger.kernel.org,
yangcong5@huaqin.corp-partner.google.com,
linux-kernel@vger.kernel.org, Daniel Vetter <daniel@ffwll.ch>,
linux-arm-msm@vger.kernel.org,
cros-qcom-dts-watchers@chromium.org,
Douglas Anderson <dianders@chromium.org>
Subject: [PATCH 4/9] HID: i2c-hid: Switch to SYSTEM_SLEEP_PM_OPS()
Date: Tue, 23 May 2023 12:27:58 -0700 [thread overview]
Message-ID: <20230523122802.4.Ib2a2865bd3c0b068432259dfc7d76cebcbb512be@changeid> (raw)
In-Reply-To: <20230523193017.4109557-1-dianders@chromium.org>
The SYSTEM_SLEEP_PM_OPS() allows us to get rid of '#ifdef
CONFIG_PM_SLEEP', as talked about in commit 1a3c7bb08826 ("PM: core:
Add new *_PM_OPS macros, deprecate old ones").
This change is expected to have no functional effect.
Signed-off-by: Douglas Anderson <dianders@chromium.org>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index efbba0465eef..19d985c20a5c 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -1085,7 +1085,6 @@ void i2c_hid_core_shutdown(struct i2c_client *client)
}
EXPORT_SYMBOL_GPL(i2c_hid_core_shutdown);
-#ifdef CONFIG_PM_SLEEP
static int i2c_hid_core_suspend(struct device *dev)
{
struct i2c_client *client = to_i2c_client(dev);
@@ -1138,10 +1137,9 @@ static int i2c_hid_core_resume(struct device *dev)
return hid_driver_reset_resume(hid);
}
-#endif
const struct dev_pm_ops i2c_hid_core_pm = {
- SET_SYSTEM_SLEEP_PM_OPS(i2c_hid_core_suspend, i2c_hid_core_resume)
+ SYSTEM_SLEEP_PM_OPS(i2c_hid_core_suspend, i2c_hid_core_resume)
};
EXPORT_SYMBOL_GPL(i2c_hid_core_pm);
--
2.40.1.698.g37aff9b760-goog
next prev parent reply other threads:[~2023-05-23 19:31 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-23 19:27 [PATCH 0/9] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together Douglas Anderson
2023-05-23 19:27 ` Douglas Anderson
2023-05-23 19:27 ` [PATCH 1/9] dt-bindings: HID: i2c-hid: Add "panel" property to i2c-hid backed panels Douglas Anderson
2023-05-23 19:27 ` Douglas Anderson
2023-05-30 15:34 ` Krzysztof Kozlowski
2023-05-30 15:34 ` Krzysztof Kozlowski
2023-05-30 16:52 ` Doug Anderson
2023-05-30 16:52 ` Doug Anderson
2023-05-23 19:27 ` [PATCH 2/9] drm/panel: Check for already prepared/enabled in drm_panel Douglas Anderson
2023-05-23 19:27 ` Douglas Anderson
2023-05-24 9:52 ` Neil Armstrong
2023-05-24 9:52 ` Neil Armstrong
2023-05-24 16:57 ` Doug Anderson
2023-05-24 16:57 ` Doug Anderson
2023-05-24 16:19 ` Chris Morgan
2023-05-24 16:19 ` Chris Morgan
2023-05-24 17:04 ` Doug Anderson
2023-05-24 17:04 ` Doug Anderson
2023-05-23 19:27 ` [PATCH 3/9] drm/panel: Add a way for other devices to follow panel state Douglas Anderson
2023-05-23 19:27 ` Douglas Anderson
2023-05-23 19:27 ` Douglas Anderson [this message]
2023-05-23 19:27 ` [PATCH 4/9] HID: i2c-hid: Switch to SYSTEM_SLEEP_PM_OPS() Douglas Anderson
2023-05-23 19:27 ` [PATCH 5/9] HID: i2c-hid: Rearrange probe() to power things up later Douglas Anderson
2023-05-23 19:27 ` Douglas Anderson
2023-05-23 23:27 ` kernel test robot
2023-05-23 23:27 ` kernel test robot
2023-05-24 13:01 ` kernel test robot
2023-05-24 13:01 ` kernel test robot
2023-05-23 19:28 ` [PATCH 6/9] HID: i2c-hid: Make suspend and resume into helper functions Douglas Anderson
2023-05-23 19:28 ` Douglas Anderson
2023-05-23 19:28 ` [PATCH 7/9] HID: i2c-hid: Support being a panel follower Douglas Anderson
2023-05-23 19:28 ` Douglas Anderson
2023-05-24 0:28 ` kernel test robot
2023-05-24 0:28 ` kernel test robot
2023-05-24 15:37 ` kernel test robot
2023-05-24 15:37 ` kernel test robot
2023-05-24 17:29 ` Doug Anderson
2023-05-24 17:29 ` Doug Anderson
2023-05-23 19:28 ` [PATCH 8/9] HID: i2c-hid: Do panel follower work on the system_wq Douglas Anderson
2023-05-23 19:28 ` Douglas Anderson
2023-05-24 1:36 ` kernel test robot
2023-05-24 1:36 ` kernel test robot
2023-05-24 18:56 ` kernel test robot
2023-05-24 18:56 ` kernel test robot
2023-05-23 19:28 ` [PATCH 9/9] arm64: dts: qcom: sc7180: Link trogdor touchscreens to the panels Douglas Anderson
2023-05-23 19:28 ` Douglas Anderson
2023-05-23 21:39 ` [PATCH 0/9] drm/panel and i2c-hid: Allow panels and touchscreens to power sequence together Dmitry Torokhov
2023-05-23 21:39 ` Dmitry Torokhov
2023-05-23 23:52 ` Doug Anderson
2023-05-23 23:52 ` Doug Anderson
2023-05-26 19:29 ` Konrad Dybcio
2023-05-26 19:29 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230523122802.4.Ib2a2865bd3c0b068432259dfc7d76cebcbb512be@changeid \
--to=dianders@chromium.org \
--cc=andersson@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hsinyi@google.com \
--cc=jikos@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=tzimmermann@suse.de \
--cc=yangcong5@huaqin.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.