From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v1 2/5] mtd: nand: raw: rockchip-nand-controller: add skipbbt option
Date: Fri, 9 Jun 2023 10:44:26 +0200 [thread overview]
Message-ID: <20230609104426.3901df54@xps-13> (raw)
In-Reply-To: <4d9473ce-c167-47d7-e37a-7b39915a724c@gmail.com>
Hi Johan,
jbx6244@gmail.com wrote on Thu, 8 Jun 2023 18:30:27 +0200:
> On Rockchip SoCs the first boot stages are written on NAND
> with help of manufacturer software that uses a different format
> then the MTD framework. Skip the automatic BBT scan with the
> NAND_SKIP_BBTSCAN option so we can run it manually.
How do you run it manually?
> The NAND_NO_BBM_QUIRK option allows us to erase bad blocks with
> the nand_erase_nand() function and the flash_erase command.
For erasure you now have access to a debugfs entry for
experts/forensics which allows you to bypass all bad block checks.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> drivers/mtd/nand/raw/rockchip-nand-controller.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> index cafccc324..f56430f6c 100644
> --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
> +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> @@ -188,6 +188,10 @@ struct rk_nfc {
> unsigned long assigned_cs;
> };
>
> +static int skipbbt;
> +module_param(skipbbt, int, 0644);
> +MODULE_PARM_DESC(skipbbt, "Skip BBT scan if the NAND chip contains data not in MTD format.");
I highly dislike this.
It's not a module parameter that you need, it is related to a partition.
> +
> static inline struct rk_nfc_nand_chip *rk_nfc_to_rknand(struct nand_chip *chip)
> {
> return container_of(chip, struct rk_nfc_nand_chip, chip);
> @@ -1156,6 +1160,10 @@ static int rk_nfc_nand_chip_init(struct device *dev, struct rk_nfc *nfc,
>
> nand_set_controller_data(chip, nfc);
>
> + /* Skip the automatic BBT scan so we can run it manually. */
> + if (skipbbt)
> + chip->options |= NAND_SKIP_BBTSCAN | NAND_NO_BBM_QUIRK;
> +
> chip->options |= NAND_USES_DMA | NAND_NO_SUBPAGE_WRITE;
> chip->bbt_options = NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB;
>
> --
> 2.30.2
>
Thanks,
Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v1 2/5] mtd: nand: raw: rockchip-nand-controller: add skipbbt option
Date: Fri, 9 Jun 2023 10:44:26 +0200 [thread overview]
Message-ID: <20230609104426.3901df54@xps-13> (raw)
In-Reply-To: <4d9473ce-c167-47d7-e37a-7b39915a724c@gmail.com>
Hi Johan,
jbx6244@gmail.com wrote on Thu, 8 Jun 2023 18:30:27 +0200:
> On Rockchip SoCs the first boot stages are written on NAND
> with help of manufacturer software that uses a different format
> then the MTD framework. Skip the automatic BBT scan with the
> NAND_SKIP_BBTSCAN option so we can run it manually.
How do you run it manually?
> The NAND_NO_BBM_QUIRK option allows us to erase bad blocks with
> the nand_erase_nand() function and the flash_erase command.
For erasure you now have access to a debugfs entry for
experts/forensics which allows you to bypass all bad block checks.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> drivers/mtd/nand/raw/rockchip-nand-controller.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> index cafccc324..f56430f6c 100644
> --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
> +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> @@ -188,6 +188,10 @@ struct rk_nfc {
> unsigned long assigned_cs;
> };
>
> +static int skipbbt;
> +module_param(skipbbt, int, 0644);
> +MODULE_PARM_DESC(skipbbt, "Skip BBT scan if the NAND chip contains data not in MTD format.");
I highly dislike this.
It's not a module parameter that you need, it is related to a partition.
> +
> static inline struct rk_nfc_nand_chip *rk_nfc_to_rknand(struct nand_chip *chip)
> {
> return container_of(chip, struct rk_nfc_nand_chip, chip);
> @@ -1156,6 +1160,10 @@ static int rk_nfc_nand_chip_init(struct device *dev, struct rk_nfc *nfc,
>
> nand_set_controller_data(chip, nfc);
>
> + /* Skip the automatic BBT scan so we can run it manually. */
> + if (skipbbt)
> + chip->options |= NAND_SKIP_BBTSCAN | NAND_NO_BBM_QUIRK;
> +
> chip->options |= NAND_USES_DMA | NAND_NO_SUBPAGE_WRITE;
> chip->bbt_options = NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB;
>
> --
> 2.30.2
>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v1 2/5] mtd: nand: raw: rockchip-nand-controller: add skipbbt option
Date: Fri, 9 Jun 2023 10:44:26 +0200 [thread overview]
Message-ID: <20230609104426.3901df54@xps-13> (raw)
In-Reply-To: <4d9473ce-c167-47d7-e37a-7b39915a724c@gmail.com>
Hi Johan,
jbx6244@gmail.com wrote on Thu, 8 Jun 2023 18:30:27 +0200:
> On Rockchip SoCs the first boot stages are written on NAND
> with help of manufacturer software that uses a different format
> then the MTD framework. Skip the automatic BBT scan with the
> NAND_SKIP_BBTSCAN option so we can run it manually.
How do you run it manually?
> The NAND_NO_BBM_QUIRK option allows us to erase bad blocks with
> the nand_erase_nand() function and the flash_erase command.
For erasure you now have access to a debugfs entry for
experts/forensics which allows you to bypass all bad block checks.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> drivers/mtd/nand/raw/rockchip-nand-controller.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> index cafccc324..f56430f6c 100644
> --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
> +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> @@ -188,6 +188,10 @@ struct rk_nfc {
> unsigned long assigned_cs;
> };
>
> +static int skipbbt;
> +module_param(skipbbt, int, 0644);
> +MODULE_PARM_DESC(skipbbt, "Skip BBT scan if the NAND chip contains data not in MTD format.");
I highly dislike this.
It's not a module parameter that you need, it is related to a partition.
> +
> static inline struct rk_nfc_nand_chip *rk_nfc_to_rknand(struct nand_chip *chip)
> {
> return container_of(chip, struct rk_nfc_nand_chip, chip);
> @@ -1156,6 +1160,10 @@ static int rk_nfc_nand_chip_init(struct device *dev, struct rk_nfc *nfc,
>
> nand_set_controller_data(chip, nfc);
>
> + /* Skip the automatic BBT scan so we can run it manually. */
> + if (skipbbt)
> + chip->options |= NAND_SKIP_BBTSCAN | NAND_NO_BBM_QUIRK;
> +
> chip->options |= NAND_USES_DMA | NAND_NO_SUBPAGE_WRITE;
> chip->bbt_options = NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB;
>
> --
> 2.30.2
>
Thanks,
Miquèl
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Johan Jonker <jbx6244@gmail.com>
Cc: richard@nod.at, vigneshr@ti.com, heiko@sntech.de,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, yifeng.zhao@rock-chips.com
Subject: Re: [PATCH v1 2/5] mtd: nand: raw: rockchip-nand-controller: add skipbbt option
Date: Fri, 9 Jun 2023 10:44:26 +0200 [thread overview]
Message-ID: <20230609104426.3901df54@xps-13> (raw)
In-Reply-To: <4d9473ce-c167-47d7-e37a-7b39915a724c@gmail.com>
Hi Johan,
jbx6244@gmail.com wrote on Thu, 8 Jun 2023 18:30:27 +0200:
> On Rockchip SoCs the first boot stages are written on NAND
> with help of manufacturer software that uses a different format
> then the MTD framework. Skip the automatic BBT scan with the
> NAND_SKIP_BBTSCAN option so we can run it manually.
How do you run it manually?
> The NAND_NO_BBM_QUIRK option allows us to erase bad blocks with
> the nand_erase_nand() function and the flash_erase command.
For erasure you now have access to a debugfs entry for
experts/forensics which allows you to bypass all bad block checks.
>
> Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> ---
> drivers/mtd/nand/raw/rockchip-nand-controller.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> index cafccc324..f56430f6c 100644
> --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c
> +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c
> @@ -188,6 +188,10 @@ struct rk_nfc {
> unsigned long assigned_cs;
> };
>
> +static int skipbbt;
> +module_param(skipbbt, int, 0644);
> +MODULE_PARM_DESC(skipbbt, "Skip BBT scan if the NAND chip contains data not in MTD format.");
I highly dislike this.
It's not a module parameter that you need, it is related to a partition.
> +
> static inline struct rk_nfc_nand_chip *rk_nfc_to_rknand(struct nand_chip *chip)
> {
> return container_of(chip, struct rk_nfc_nand_chip, chip);
> @@ -1156,6 +1160,10 @@ static int rk_nfc_nand_chip_init(struct device *dev, struct rk_nfc *nfc,
>
> nand_set_controller_data(chip, nfc);
>
> + /* Skip the automatic BBT scan so we can run it manually. */
> + if (skipbbt)
> + chip->options |= NAND_SKIP_BBTSCAN | NAND_NO_BBM_QUIRK;
> +
> chip->options |= NAND_USES_DMA | NAND_NO_SUBPAGE_WRITE;
> chip->bbt_options = NAND_BBT_USE_FLASH | NAND_BBT_NO_OOB;
>
> --
> 2.30.2
>
Thanks,
Miquèl
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-09 8:44 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-08 16:28 [PATCH v1 0/5] Fixes for Rockchip NAND controller driver Johan Jonker
2023-06-08 16:28 ` Johan Jonker
2023-06-08 16:28 ` Johan Jonker
2023-06-08 16:28 ` Johan Jonker
2023-06-08 16:30 ` [PATCH v1 1/5] mtd: nand: raw: rockchip-nand-controller: copy hwecc PA data to oob_poi buffer Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` [PATCH v1 2/5] mtd: nand: raw: rockchip-nand-controller: add skipbbt option Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-09 8:44 ` Miquel Raynal [this message]
2023-06-09 8:44 ` Miquel Raynal
2023-06-09 8:44 ` Miquel Raynal
2023-06-09 8:44 ` Miquel Raynal
2023-06-10 22:13 ` Johan Jonker
2023-06-10 22:13 ` Johan Jonker
2023-06-10 22:13 ` Johan Jonker
2023-06-08 16:30 ` [PATCH v1 3/5] mtd: nand: raw: rockchip-nand-controller: fix nand timing default Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-09 8:50 ` Miquel Raynal
2023-06-09 8:50 ` Miquel Raynal
2023-06-09 8:50 ` Miquel Raynal
2023-06-09 8:50 ` Miquel Raynal
2023-06-08 16:30 ` [PATCH v1 4/5] mtd: nand: raw: rockchip-nand-controller: fix oobfree offset and description Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:30 ` Johan Jonker
2023-06-08 16:31 ` [PATCH v1 5/5] mtd: nand: add support for the Sandisk SDTNQGAMA chip Johan Jonker
2023-06-08 16:31 ` Johan Jonker
2023-06-08 16:31 ` Johan Jonker
2023-06-08 16:31 ` Johan Jonker
2023-06-09 8:54 ` Miquel Raynal
2023-06-09 8:54 ` Miquel Raynal
2023-06-09 8:54 ` Miquel Raynal
2023-06-09 8:54 ` Miquel Raynal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230609104426.3901df54@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.