All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Michael Walle <michael@walle.cc>,
	Thierry Reding <thierry.reding@gmail.com>
Cc: linux-pwm@vger.kernel.org, kernel@pengutronix.de
Subject: [PATCH 09/10] pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
Date: Fri, 14 Jul 2023 22:56:22 +0200	[thread overview]
Message-ID: <20230714205623.2496590-10-u.kleine-koenig@pengutronix.de> (raw)
In-Reply-To: <20230714205623.2496590-1-u.kleine-koenig@pengutronix.de>

Nearly all pwm drivers use the name "chip" for the member in the driver
struct pointing to the pwm_chip. Also all local variables and function
parameters with this type use this name. Rename the struct pwm_chip
member accordingly for consistency.

Also rename the parameter of the macro sl28cpld_pwm_from_chip to "chip".

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 drivers/pwm/pwm-sl28cpld.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c
index e64900ad4ba1..98b0024f9658 100644
--- a/drivers/pwm/pwm-sl28cpld.c
+++ b/drivers/pwm/pwm-sl28cpld.c
@@ -80,12 +80,12 @@
 	regmap_write((priv)->regmap, (priv)->offset + (reg), (val))
 
 struct sl28cpld_pwm {
-	struct pwm_chip pwm_chip;
+	struct pwm_chip chip;
 	struct regmap *regmap;
 	u32 offset;
 };
-#define sl28cpld_pwm_from_chip(_chip) \
-	container_of(_chip, struct sl28cpld_pwm, pwm_chip)
+#define sl28cpld_pwm_from_chip(chip) \
+	container_of(chip, struct sl28cpld_pwm, chip)
 
 static int sl28cpld_pwm_get_state(struct pwm_chip *chip,
 				  struct pwm_device *pwm,
@@ -228,12 +228,12 @@ static int sl28cpld_pwm_probe(struct platform_device *pdev)
 	}
 
 	/* Initialize the pwm_chip structure */
-	chip = &priv->pwm_chip;
+	chip = &priv->chip;
 	chip->dev = &pdev->dev;
 	chip->ops = &sl28cpld_pwm_ops;
 	chip->npwm = 1;
 
-	ret = devm_pwmchip_add(&pdev->dev, &priv->pwm_chip);
+	ret = devm_pwmchip_add(&pdev->dev, chip);
 	if (ret) {
 		dev_err(&pdev->dev, "failed to add PWM chip (%pe)",
 			ERR_PTR(ret));
-- 
2.39.2


  parent reply	other threads:[~2023-07-14 20:56 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-14 20:56 [PATCH 00/10] pwm: Constistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` Uwe Kleine-König
2023-07-14 20:56 ` Uwe Kleine-König
2023-07-14 20:56 ` Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 01/10] pwm: Use a consistent name for pwm_chip pointers in the core Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 02/10] pwm: atmel-hlcdc: Use consistent variable naming Uwe Kleine-König
2023-07-14 20:56   ` Uwe Kleine-König
2023-07-16 13:04   ` claudiu beznea
2023-07-16 13:04     ` claudiu beznea
2023-07-20  6:53   ` Thierry Reding
2023-07-20  6:53     ` Thierry Reding
2023-07-20  7:29     ` Uwe Kleine-König
2023-07-20  7:29       ` Uwe Kleine-König
2023-07-21 17:58       ` Uwe Kleine-König
2023-07-21 17:58         ` Uwe Kleine-König
2023-07-21 18:26         ` Thierry Reding
2023-07-21 18:26           ` Thierry Reding
2023-07-14 20:56 ` [PATCH 03/10] pwm: bcm-kona: Consistenly name pwm_chip variables "chip" Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 04/10] pwm: crc: " Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 05/10] pwm: cros-ec: " Uwe Kleine-König
2023-07-17  3:34   ` Tzung-Bi Shih
2023-07-14 20:56 ` [PATCH 06/10] pwm: lp3943: " Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 07/10] pwm: rockchip: " Uwe Kleine-König
2023-07-14 20:56   ` Uwe Kleine-König
2023-07-14 20:56   ` Uwe Kleine-König
2023-07-14 20:56 ` [PATCH 08/10] pwm: sifive: " Uwe Kleine-König
2023-07-14 20:56   ` Uwe Kleine-König
2023-07-14 20:56 ` Uwe Kleine-König [this message]
2023-07-19 14:17   ` [PATCH 09/10] pwm: sl28cpld: " Michael Walle
2023-07-19 14:39     ` Uwe Kleine-König
2023-07-19 14:55       ` Michael Walle
2023-07-14 20:56 ` [PATCH 10/10] staging: greybus: pwm: " Uwe Kleine-König
2023-07-15 15:04   ` Alex Elder
2023-07-20  6:48 ` [PATCH 00/10] pwm: Constistenly " Thierry Reding
2023-07-20  6:48   ` Thierry Reding
2023-07-20  6:48   ` Thierry Reding
2023-07-20  6:48   ` Thierry Reding
2023-07-20  7:10   ` Uwe Kleine-König
2023-07-20  7:10     ` Uwe Kleine-König
2023-07-20  7:10     ` Uwe Kleine-König
2023-07-20  7:10     ` Uwe Kleine-König
2023-07-20 15:03     ` Thierry Reding
2023-07-20 15:03       ` Thierry Reding
2023-07-20 15:03       ` Thierry Reding
2023-07-20 15:03       ` Thierry Reding
2023-07-20 14:41 ` Thierry Reding
2023-07-20 14:41   ` Thierry Reding
2023-07-20 14:41   ` Thierry Reding
2023-07-20 14:41   ` Thierry Reding
2023-09-11  4:31 ` patchwork-bot+chrome-platform
2023-09-11  4:31   ` patchwork-bot+chrome-platform
2023-09-11  4:31   ` patchwork-bot+chrome-platform
2023-09-11  4:31   ` patchwork-bot+chrome-platform
2023-09-11  4:49 ` patchwork-bot+chrome-platform
2023-09-11  4:49   ` patchwork-bot+chrome-platform
2023-09-11  4:49   ` patchwork-bot+chrome-platform
2023-09-11  4:49   ` patchwork-bot+chrome-platform

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230714205623.2496590-10-u.kleine-koenig@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=kernel@pengutronix.de \
    --cc=linux-pwm@vger.kernel.org \
    --cc=michael@walle.cc \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.