Re: [PATCH 09/10] pwm: sl28cpld: Consistenly name pwm_chip variables "chip"

From: Michael Walle <michael@walle.cc>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org,
	Thierry Reding <thierry.reding@gmail.com>,
	kernel@pengutronix.de
Subject: Re: [PATCH 09/10] pwm: sl28cpld: Consistenly name pwm_chip variables "chip"
Date: Wed, 19 Jul 2023 16:55:31 +0200	[thread overview]
Message-ID: <9cb1b141e206dd9afd215d8886d688d9@walle.cc> (raw)
In-Reply-To: <20230719143956.6sv3feiroiwrcosb@pengutronix.de>

Hi,

>> I'd expect it to be:
>> #define sl28cpld_pwm_from_chip(_chip) \
>> 	container_of(_chip, struct sl28cpld_pwm, chip)
> 
> Indeed, that's bogus. My preference would be to make this a static
> inline, i.e.
> 
> diff --git a/drivers/pwm/pwm-sl28cpld.c b/drivers/pwm/pwm-sl28cpld.c
> index 98b0024f9658..c789e934671e 100644
> --- a/drivers/pwm/pwm-sl28cpld.c
> +++ b/drivers/pwm/pwm-sl28cpld.c
> @@ -84,8 +84,11 @@ struct sl28cpld_pwm {
>  	struct regmap *regmap;
>  	u32 offset;
>  };
> -#define sl28cpld_pwm_from_chip(chip) \
> -	container_of(chip, struct sl28cpld_pwm, chip)
> +
> +static inline struct sl28cpld_pwm *sl28cpld_pwm_from_chip(struct 
> pwm_chip *chip)
> +{
> +	return container_of(chip, struct sl28cpld_pwm, chip);
> +}
> 
>  static int sl28cpld_pwm_get_state(struct pwm_chip *chip,
>  				  struct pwm_device *pwm,
> 
> but I can live with _chip, too.

I don't have a strong preference. Looks like most drivers use
the inline. Go with that :)

-michael