Re: [PATCH 10/10] staging: greybus: pwm: Consistenly name pwm_chip variables "chip"

From: Alex Elder <elder@ieee.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Johan Hovold" <johan@kernel.org>,
	"Alex Elder" <elder@kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Thierry Reding" <thierry.reding@gmail.com>
Cc: greybus-dev@lists.linaro.org, linux-staging@lists.linux.dev,
	kernel@pengutronix.de, linux-pwm@vger.kernel.org
Subject: Re: [PATCH 10/10] staging: greybus: pwm: Consistenly name pwm_chip variables "chip"
Date: Sat, 15 Jul 2023 10:04:45 -0500	[thread overview]
Message-ID: <f8aec2a1-45ae-712f-db60-f923f2bf2a5b@ieee.org> (raw)
In-Reply-To: <20230714205623.2496590-11-u.kleine-koenig@pengutronix.de>

On 7/14/23 3:56 PM, Uwe Kleine-König wrote:
> All function parameters of type pointer to struct pwm_chip in this
> driver are called chip which is also the usual name of function
> parameters and local variables in most other pwm drivers. For consistency
> use the same name for the local variable of that type.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Looks good to me.

Reviewed-by: Alex Elder <elder@linaro.org>

> ---
>   drivers/staging/greybus/pwm.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/staging/greybus/pwm.c b/drivers/staging/greybus/pwm.c
> index 88da1d796f13..c483e1f0738e 100644
> --- a/drivers/staging/greybus/pwm.c
> +++ b/drivers/staging/greybus/pwm.c
> @@ -267,7 +267,7 @@ static int gb_pwm_probe(struct gbphy_device *gbphy_dev,
>   {
>   	struct gb_connection *connection;
>   	struct gb_pwm_chip *pwmc;
> -	struct pwm_chip *pwm;
> +	struct pwm_chip *chip;
>   	int ret;
>   
>   	pwmc = kzalloc(sizeof(*pwmc), GFP_KERNEL);
> @@ -295,13 +295,13 @@ static int gb_pwm_probe(struct gbphy_device *gbphy_dev,
>   	if (ret)
>   		goto exit_connection_disable;
>   
> -	pwm = &pwmc->chip;
> +	chip = &pwmc->chip;
>   
> -	pwm->dev = &gbphy_dev->dev;
> -	pwm->ops = &gb_pwm_ops;
> -	pwm->npwm = pwmc->pwm_max + 1;
> +	chip->dev = &gbphy_dev->dev;
> +	chip->ops = &gb_pwm_ops;
> +	chip->npwm = pwmc->pwm_max + 1;
>   
> -	ret = pwmchip_add(pwm);
> +	ret = pwmchip_add(chip);
>   	if (ret) {
>   		dev_err(&gbphy_dev->dev,
>   			"failed to register PWM: %d\n", ret);