From: SeongJae Park <sj@kernel.org> To: unlisted-recipients:; (no To-header on input) Cc: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC 1/8] mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses Date: Sun, 10 Sep 2023 03:40:41 +0000 [thread overview] Message-ID: <20230910034048.59191-2-sj@kernel.org> (raw) In-Reply-To: <20230910034048.59191-1-sj@kernel.org> DAMON provides nr_accesses_bp, which becomes same to nr_accesses * 10000 for every aggregation interval, but updated every sampling interval with a reasonable accuracy. Since DAMON-based operation schemes are applied in every aggregation interval using nr_accesses, using nr_accesses_bp instead will make no difference. This also makes future DAMOS changes for applying the scheme in a time interval that less than the aggregation interval possible. Signed-off-by: SeongJae Park <sj@kernel.org> --- mm/damon/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 83b0cd329e84..3e0532c6896c 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -799,12 +799,13 @@ static void damon_split_region_at(struct damon_target *t, static bool __damos_valid_target(struct damon_region *r, struct damos *s) { unsigned long sz; + unsigned int nr_accesses = r->nr_accesses_bp / 10000; sz = damon_sz_region(r); return s->pattern.min_sz_region <= sz && sz <= s->pattern.max_sz_region && - s->pattern.min_nr_accesses <= r->nr_accesses && - r->nr_accesses <= s->pattern.max_nr_accesses && + s->pattern.min_nr_accesses <= nr_accesses && + nr_accesses <= s->pattern.max_nr_accesses && s->pattern.min_age_region <= r->age && r->age <= s->pattern.max_age_region; } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: SeongJae Park <sj@kernel.org> Cc: SeongJae Park <sj@kernel.org>, Andrew Morton <akpm@linux-foundation.org>, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [RFC 1/8] mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses Date: Sun, 10 Sep 2023 03:40:41 +0000 [thread overview] Message-ID: <20230910034048.59191-2-sj@kernel.org> (raw) In-Reply-To: <20230910034048.59191-1-sj@kernel.org> DAMON provides nr_accesses_bp, which becomes same to nr_accesses * 10000 for every aggregation interval, but updated every sampling interval with a reasonable accuracy. Since DAMON-based operation schemes are applied in every aggregation interval using nr_accesses, using nr_accesses_bp instead will make no difference. This also makes future DAMOS changes for applying the scheme in a time interval that less than the aggregation interval possible. Signed-off-by: SeongJae Park <sj@kernel.org> --- mm/damon/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/damon/core.c b/mm/damon/core.c index 83b0cd329e84..3e0532c6896c 100644 --- a/mm/damon/core.c +++ b/mm/damon/core.c @@ -799,12 +799,13 @@ static void damon_split_region_at(struct damon_target *t, static bool __damos_valid_target(struct damon_region *r, struct damos *s) { unsigned long sz; + unsigned int nr_accesses = r->nr_accesses_bp / 10000; sz = damon_sz_region(r); return s->pattern.min_sz_region <= sz && sz <= s->pattern.max_sz_region && - s->pattern.min_nr_accesses <= r->nr_accesses && - r->nr_accesses <= s->pattern.max_nr_accesses && + s->pattern.min_nr_accesses <= nr_accesses && + nr_accesses <= s->pattern.max_nr_accesses && s->pattern.min_age_region <= r->age && r->age <= s->pattern.max_age_region; } -- 2.25.1
next prev parent reply other threads:[~2023-09-10 3:41 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-09-10 3:40 [RFC 0/8] mm/damon: implement DAMOS apply intervals SeongJae Park 2023-09-10 3:40 ` SeongJae Park 2023-09-10 3:40 ` SeongJae Park [this message] 2023-09-10 3:40 ` [RFC 1/8] mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses SeongJae Park 2023-09-10 3:40 ` [RFC 2/8] mm/damon/sysfs-schemes: expose nr_accesses_bp via tried_regions/<N>/nr_accesses SeongJae Park 2023-09-10 3:40 ` SeongJae Park 2023-09-10 3:40 ` [RFC 3/8] mm/damon/core: expose nr_accesses_bp from damos_before_apply tracepoint SeongJae Park 2023-09-10 3:40 ` SeongJae Park 2023-09-10 3:40 ` [RFC 4/8] mm/damon/core: implement scheme-specific apply interval SeongJae Park 2023-09-10 3:40 ` SeongJae Park 2023-09-10 3:40 ` [RFC 5/8] Docs/mm/damon/design: document DAMOS apply intervals SeongJae Park 2023-09-10 3:40 ` SeongJae Park 2023-09-10 3:40 ` [RFC 6/8] mm/damon/sysfs-schemes: support DAMOS apply interval SeongJae Park 2023-09-10 3:40 ` SeongJae Park 2023-09-10 3:40 ` [RFC 7/8] Docs/admin-guide/mm/damon/usage: update for DAMOS apply intervals SeongJae Park 2023-09-10 3:40 ` SeongJae Park 2023-09-10 3:40 ` [RFC 8/8] Docs/ABI/damon: " SeongJae Park 2023-09-10 3:40 ` SeongJae Park
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20230910034048.59191-2-sj@kernel.org \ --to=sj@kernel.org \ --cc=akpm@linux-foundation.org \ --cc=damon@lists.linux.dev \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.