From: SeongJae Park <sj@kernel.org>
To: unlisted-recipients:; (no To-header on input)
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC 3/8] mm/damon/core: expose nr_accesses_bp from damos_before_apply tracepoint
Date: Sun, 10 Sep 2023 03:40:43 +0000 [thread overview]
Message-ID: <20230910034048.59191-4-sj@kernel.org> (raw)
In-Reply-To: <20230910034048.59191-1-sj@kernel.org>
damos_before_apply tracepoint is exposing access rate of DAMON regions
using nr_accesses, which was actually used by DAMOS in the past.
However, it has changed to use nr_accesses_bp instead. Update the
tracepoint to expose the value that DAMOS is really using. Note that it
doesn't expose the value as is in the basis point, but after converting
it to the natural number by dividing it by 10,000. That's for avoiding
confuses for old users.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/trace/events/damon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h
index 9e7b39495b05..6f98198c0104 100644
--- a/include/trace/events/damon.h
+++ b/include/trace/events/damon.h
@@ -34,7 +34,7 @@ TRACE_EVENT(damos_before_apply,
__entry->target_idx = target_idx;
__entry->start = r->ar.start;
__entry->end = r->ar.end;
- __entry->nr_accesses = r->nr_accesses;
+ __entry->nr_accesses = r->nr_accesses_bp / 10000;
__entry->age = r->age;
__entry->nr_regions = nr_regions;
),
--
2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-trace-kernel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [RFC 3/8] mm/damon/core: expose nr_accesses_bp from damos_before_apply tracepoint
Date: Sun, 10 Sep 2023 03:40:43 +0000 [thread overview]
Message-ID: <20230910034048.59191-4-sj@kernel.org> (raw)
In-Reply-To: <20230910034048.59191-1-sj@kernel.org>
damos_before_apply tracepoint is exposing access rate of DAMON regions
using nr_accesses, which was actually used by DAMOS in the past.
However, it has changed to use nr_accesses_bp instead. Update the
tracepoint to expose the value that DAMOS is really using. Note that it
doesn't expose the value as is in the basis point, but after converting
it to the natural number by dividing it by 10,000. That's for avoiding
confuses for old users.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
include/trace/events/damon.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h
index 9e7b39495b05..6f98198c0104 100644
--- a/include/trace/events/damon.h
+++ b/include/trace/events/damon.h
@@ -34,7 +34,7 @@ TRACE_EVENT(damos_before_apply,
__entry->target_idx = target_idx;
__entry->start = r->ar.start;
__entry->end = r->ar.end;
- __entry->nr_accesses = r->nr_accesses;
+ __entry->nr_accesses = r->nr_accesses_bp / 10000;
__entry->age = r->age;
__entry->nr_regions = nr_regions;
),
--
2.25.1
next prev parent reply other threads:[~2023-09-10 3:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-10 3:40 [RFC 0/8] mm/damon: implement DAMOS apply intervals SeongJae Park
2023-09-10 3:40 ` SeongJae Park
2023-09-10 3:40 ` [RFC 1/8] mm/damon/core: make DAMOS uses nr_accesses_bp instead of nr_accesses SeongJae Park
2023-09-10 3:40 ` SeongJae Park
2023-09-10 3:40 ` [RFC 2/8] mm/damon/sysfs-schemes: expose nr_accesses_bp via tried_regions/<N>/nr_accesses SeongJae Park
2023-09-10 3:40 ` SeongJae Park
2023-09-10 3:40 ` SeongJae Park [this message]
2023-09-10 3:40 ` [RFC 3/8] mm/damon/core: expose nr_accesses_bp from damos_before_apply tracepoint SeongJae Park
2023-09-10 3:40 ` [RFC 4/8] mm/damon/core: implement scheme-specific apply interval SeongJae Park
2023-09-10 3:40 ` SeongJae Park
2023-09-10 3:40 ` [RFC 5/8] Docs/mm/damon/design: document DAMOS apply intervals SeongJae Park
2023-09-10 3:40 ` SeongJae Park
2023-09-10 3:40 ` [RFC 6/8] mm/damon/sysfs-schemes: support DAMOS apply interval SeongJae Park
2023-09-10 3:40 ` SeongJae Park
2023-09-10 3:40 ` [RFC 7/8] Docs/admin-guide/mm/damon/usage: update for DAMOS apply intervals SeongJae Park
2023-09-10 3:40 ` SeongJae Park
2023-09-10 3:40 ` [RFC 8/8] Docs/ABI/damon: " SeongJae Park
2023-09-10 3:40 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230910034048.59191-4-sj@kernel.org \
--to=sj@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=damon@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.