Re: [PATCH] mfd: Use device_get_match_data()

From: Lee Jones <lee@kernel.org>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Rob Herring <robh@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	NXP Linux Team <linux-imx@nxp.com>,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Tony Lindgren <tony@atomide.com>,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-arm-msm@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] mfd: Use device_get_match_data()
Date: Thu, 12 Oct 2023 10:26:18 +0100	[thread overview]
Message-ID: <20231012092618.GF8314@google.com> (raw)
In-Reply-To: <CAGb2v66ZHD8mMMNVwp+sTYT6DAFDUrP8ydeTo7KW+uUtBRM3bQ@mail.gmail.com>

On Tue, 10 Oct 2023, Chen-Yu Tsai wrote:

> On Tue, Oct 10, 2023 at 5:14 AM Rob Herring <robh@kernel.org> wrote:
> >
> > Use preferred device_get_match_data() instead of of_match_device() to
> > get the driver match data. With this, adjust the includes to explicitly
> > include the correct headers.
> >
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> >  drivers/mfd/axp20x.c           | 22 +++-------------------
> 
> I'd keep the error message, but otherwise for axp20x,
> 
> Reviewed-by: Chen-Yu Tsai <wens@csie.org>
> 
> >  drivers/mfd/hi6421-pmic-core.c |  9 +++------
> >  drivers/mfd/mxs-lradc.c        |  9 ++-------
> >  drivers/mfd/qcom-spmi-pmic.c   |  6 ++++--
> >  drivers/mfd/qcom_rpm.c         |  8 ++++----
> >  drivers/mfd/tps65910.c         | 11 ++---------
> >  drivers/mfd/twl4030-power.c    |  9 +++------
> >  drivers/mfd/twl6030-irq.c      | 10 +++++-----
> >  8 files changed, 26 insertions(+), 58 deletions(-)

FYI, this patch is not in my inbox.

-- 
Lee Jones [李琼斯]