From: Miquel Raynal <miquel.raynal@bootlin.com> To: Frank Li <Frank.Li@nxp.com> Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 Resent 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Date: Thu, 19 Oct 2023 08:31:51 +0200 [thread overview] Message-ID: <20231019083151.3bd10536@xps-13> (raw) In-Reply-To: <20231018155926.3305476-6-Frank.Li@nxp.com> Hi Frank, Frank.Li@nxp.com wrote on Wed, 18 Oct 2023 11:59:25 -0400: > If IBIWON timeout happen, SDA line will always keep low because miss emit > stop. " Upon IBIWON timeout, the SDA line will always be kept low if we don't emit a stop. Calling svc_i3c_master_emit_stop() there will let the bus return to idle state. " With this commit log, Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Call svc_i3c_master_emit_stop() to let i3c bus come back to idle statue > when IBIWON timeout happen. > > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > Cc: stable@vger.kernel.org > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > > Notes: > Change from v1 to v2 > - Update commite message > > drivers/i3c/master/svc-i3c-master.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index b113460f059c3..1a57fdebaa26d 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -404,6 +404,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) > SVC_I3C_MSTATUS_IBIWON(val), 0, 1000); > if (ret) { > dev_err(master->dev, "Timeout when polling for IBIWON\n"); > + svc_i3c_master_emit_stop(master); > goto reenable_ibis; > } > Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Frank Li <Frank.Li@nxp.com> Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 Resent 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Date: Thu, 19 Oct 2023 08:31:51 +0200 [thread overview] Message-ID: <20231019083151.3bd10536@xps-13> (raw) In-Reply-To: <20231018155926.3305476-6-Frank.Li@nxp.com> Hi Frank, Frank.Li@nxp.com wrote on Wed, 18 Oct 2023 11:59:25 -0400: > If IBIWON timeout happen, SDA line will always keep low because miss emit > stop. " Upon IBIWON timeout, the SDA line will always be kept low if we don't emit a stop. Calling svc_i3c_master_emit_stop() there will let the bus return to idle state. " With this commit log, Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com> > > Call svc_i3c_master_emit_stop() to let i3c bus come back to idle statue > when IBIWON timeout happen. > > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > Cc: stable@vger.kernel.org > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > > Notes: > Change from v1 to v2 > - Update commite message > > drivers/i3c/master/svc-i3c-master.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index b113460f059c3..1a57fdebaa26d 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -404,6 +404,7 @@ static void svc_i3c_master_ibi_work(struct work_struct *work) > SVC_I3C_MSTATUS_IBIWON(val), 0, 1000); > if (ret) { > dev_err(master->dev, "Timeout when polling for IBIWON\n"); > + svc_i3c_master_emit_stop(master); > goto reenable_ibis; > } > Thanks, Miquèl -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-10-19 6:31 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-18 15:59 [PATCH v2 Resent 0/6] i3c: master: svc: collection of bugs fixes Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 1/6] i3c: master: svc: fix race condition in ibi work thread Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 2/6] i3c: master: svc: fix wrong data return when IBI happen during start frame Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 3/6] i3c: master: svc: fix ibi may not return mandatory data byte Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-19 6:29 ` Miquel Raynal 2023-10-19 6:29 ` Miquel Raynal 2023-10-18 15:59 ` [PATCH v2 Resent 4/6] i3c: master: svc: fix check wrong status register in irq handler Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-19 6:31 ` Miquel Raynal [this message] 2023-10-19 6:31 ` Miquel Raynal 2023-10-18 15:59 ` [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout error Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-19 6:44 ` Miquel Raynal 2023-10-19 6:44 ` Miquel Raynal 2023-10-19 15:39 ` Frank Li 2023-10-19 15:39 ` Frank Li 2023-10-20 14:06 ` Miquel Raynal 2023-10-20 14:06 ` Miquel Raynal 2023-10-20 14:18 ` Frank Li 2023-10-20 14:18 ` Frank Li 2023-10-20 14:35 ` Miquel Raynal 2023-10-20 14:35 ` Miquel Raynal 2023-10-20 14:47 ` Frank Li 2023-10-20 14:47 ` Frank Li 2023-10-20 15:17 ` Frank Li 2023-10-20 15:17 ` Frank Li 2023-10-20 15:25 ` Miquel Raynal 2023-10-20 15:25 ` Miquel Raynal 2023-10-20 15:20 ` Miquel Raynal 2023-10-20 15:20 ` Miquel Raynal 2023-10-20 15:47 ` [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout errory Frank Li 2023-10-20 15:47 ` Frank Li 2023-10-20 17:03 ` Miquel Raynal 2023-10-20 17:03 ` Miquel Raynal 2023-10-20 19:58 ` Frank Li 2023-10-20 19:58 ` Frank Li 2023-10-23 7:48 ` Miquel Raynal 2023-10-23 7:48 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231019083151.3bd10536@xps-13 \ --to=miquel.raynal@bootlin.com \ --cc=Frank.Li@nxp.com \ --cc=alexandre.belloni@bootlin.com \ --cc=conor.culhane@silvaco.com \ --cc=imx@lists.linux.dev \ --cc=joe@perches.com \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.