From: Miquel Raynal <miquel.raynal@bootlin.com> To: Frank Li <Frank.Li@nxp.com> Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout error Date: Thu, 19 Oct 2023 08:44:52 +0200 [thread overview] Message-ID: <20231019084452.11fd0645@xps-13> (raw) In-Reply-To: <20231018155926.3305476-7-Frank.Li@nxp.com> Hi Frank, Frank.Li@nxp.com wrote on Wed, 18 Oct 2023 11:59:26 -0400: > master side report: > silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000 > > BIT 20: TIMEOUT error > The module has stalled too long in a frame. This happens when: > - The TX FIFO or RX FIFO is not handled and the bus is stuck in the > middle of a message, > - No STOP was issued and between messages, > - IBI manual is used and no decision was made. I am still not convinced this should be ignored in all cases. Case 1 is a problem because the hardware failed somehow. Case 2 is fine I guess. Case 3 is not possible in Linux, this will not be supported. > The maximum stall period is 10 KHz or 100 μs. s/10 KHz// > > This is a just warning. System irq thread schedule latency is possible > bigger than 100us. Just omit this waring. This can be considered as being just a warning as the system IRQ latency can easily be greater than 100us. > > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > Cc: stable@vger.kernel.org > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > > Notes: > Change from v1 to v2 > -none > > drivers/i3c/master/svc-i3c-master.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index 1a57fdebaa26d..fedb31e0076c4 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -93,6 +93,7 @@ > #define SVC_I3C_MINTMASKED 0x098 > #define SVC_I3C_MERRWARN 0x09C > #define SVC_I3C_MERRWARN_NACK BIT(2) > +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) > #define SVC_I3C_MDMACTRL 0x0A0 > #define SVC_I3C_MDATACTRL 0x0AC > #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) > @@ -226,6 +227,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master) > if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { > merrwarn = readl(master->regs + SVC_I3C_MERRWARN); > writel(merrwarn, master->regs + SVC_I3C_MERRWARN); > + > + /* ignore timeout error */ > + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) > + return false; > + > dev_err(master->dev, > "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", > mstatus, merrwarn); Thanks, Miquèl
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com> To: Frank Li <Frank.Li@nxp.com> Cc: alexandre.belloni@bootlin.com, conor.culhane@silvaco.com, imx@lists.linux.dev, joe@perches.com, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout error Date: Thu, 19 Oct 2023 08:44:52 +0200 [thread overview] Message-ID: <20231019084452.11fd0645@xps-13> (raw) In-Reply-To: <20231018155926.3305476-7-Frank.Li@nxp.com> Hi Frank, Frank.Li@nxp.com wrote on Wed, 18 Oct 2023 11:59:26 -0400: > master side report: > silvaco-i3c-master 44330000.i3c-master: Error condition: MSTATUS 0x020090c7, MERRWARN 0x00100000 > > BIT 20: TIMEOUT error > The module has stalled too long in a frame. This happens when: > - The TX FIFO or RX FIFO is not handled and the bus is stuck in the > middle of a message, > - No STOP was issued and between messages, > - IBI manual is used and no decision was made. I am still not convinced this should be ignored in all cases. Case 1 is a problem because the hardware failed somehow. Case 2 is fine I guess. Case 3 is not possible in Linux, this will not be supported. > The maximum stall period is 10 KHz or 100 μs. s/10 KHz// > > This is a just warning. System irq thread schedule latency is possible > bigger than 100us. Just omit this waring. This can be considered as being just a warning as the system IRQ latency can easily be greater than 100us. > > Fixes: dd3c52846d59 ("i3c: master: svc: Add Silvaco I3C master driver") > Cc: stable@vger.kernel.org > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > > Notes: > Change from v1 to v2 > -none > > drivers/i3c/master/svc-i3c-master.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c > index 1a57fdebaa26d..fedb31e0076c4 100644 > --- a/drivers/i3c/master/svc-i3c-master.c > +++ b/drivers/i3c/master/svc-i3c-master.c > @@ -93,6 +93,7 @@ > #define SVC_I3C_MINTMASKED 0x098 > #define SVC_I3C_MERRWARN 0x09C > #define SVC_I3C_MERRWARN_NACK BIT(2) > +#define SVC_I3C_MERRWARN_TIMEOUT BIT(20) > #define SVC_I3C_MDMACTRL 0x0A0 > #define SVC_I3C_MDATACTRL 0x0AC > #define SVC_I3C_MDATACTRL_FLUSHTB BIT(0) > @@ -226,6 +227,11 @@ static bool svc_i3c_master_error(struct svc_i3c_master *master) > if (SVC_I3C_MSTATUS_ERRWARN(mstatus)) { > merrwarn = readl(master->regs + SVC_I3C_MERRWARN); > writel(merrwarn, master->regs + SVC_I3C_MERRWARN); > + > + /* ignore timeout error */ > + if (merrwarn & SVC_I3C_MERRWARN_TIMEOUT) > + return false; > + > dev_err(master->dev, > "Error condition: MSTATUS 0x%08x, MERRWARN 0x%08x\n", > mstatus, merrwarn); Thanks, Miquèl -- linux-i3c mailing list linux-i3c@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-i3c
next prev parent reply other threads:[~2023-10-19 6:45 UTC|newest] Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-10-18 15:59 [PATCH v2 Resent 0/6] i3c: master: svc: collection of bugs fixes Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 1/6] i3c: master: svc: fix race condition in ibi work thread Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 2/6] i3c: master: svc: fix wrong data return when IBI happen during start frame Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 3/6] i3c: master: svc: fix ibi may not return mandatory data byte Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-19 6:29 ` Miquel Raynal 2023-10-19 6:29 ` Miquel Raynal 2023-10-18 15:59 ` [PATCH v2 Resent 4/6] i3c: master: svc: fix check wrong status register in irq handler Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-18 15:59 ` [PATCH v2 Resent 5/6] i3c: master: svc: fix SDA keep low when polling IBIWON timeout happen Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-19 6:31 ` Miquel Raynal 2023-10-19 6:31 ` Miquel Raynal 2023-10-18 15:59 ` [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout error Frank Li 2023-10-18 15:59 ` Frank Li 2023-10-19 6:44 ` Miquel Raynal [this message] 2023-10-19 6:44 ` Miquel Raynal 2023-10-19 15:39 ` Frank Li 2023-10-19 15:39 ` Frank Li 2023-10-20 14:06 ` Miquel Raynal 2023-10-20 14:06 ` Miquel Raynal 2023-10-20 14:18 ` Frank Li 2023-10-20 14:18 ` Frank Li 2023-10-20 14:35 ` Miquel Raynal 2023-10-20 14:35 ` Miquel Raynal 2023-10-20 14:47 ` Frank Li 2023-10-20 14:47 ` Frank Li 2023-10-20 15:17 ` Frank Li 2023-10-20 15:17 ` Frank Li 2023-10-20 15:25 ` Miquel Raynal 2023-10-20 15:25 ` Miquel Raynal 2023-10-20 15:20 ` Miquel Raynal 2023-10-20 15:20 ` Miquel Raynal 2023-10-20 15:47 ` [PATCH v2 Resent 6/6] i3c: master: svc: fix random hot join failure since timeout errory Frank Li 2023-10-20 15:47 ` Frank Li 2023-10-20 17:03 ` Miquel Raynal 2023-10-20 17:03 ` Miquel Raynal 2023-10-20 19:58 ` Frank Li 2023-10-20 19:58 ` Frank Li 2023-10-23 7:48 ` Miquel Raynal 2023-10-23 7:48 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20231019084452.11fd0645@xps-13 \ --to=miquel.raynal@bootlin.com \ --cc=Frank.Li@nxp.com \ --cc=alexandre.belloni@bootlin.com \ --cc=conor.culhane@silvaco.com \ --cc=imx@lists.linux.dev \ --cc=joe@perches.com \ --cc=linux-i3c@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.