From: David Woodhouse <dwmw2@infradead.org> To: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Cc: Paolo Bonzini <pbonzini@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Marc Zyngier <maz@kernel.org>, Oliver Upton <oliver.upton@linux.dev>, James Morse <james.morse@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Zenghui Yu <yuzenghui@huawei.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, David Woodhouse <dwmw@amazon.co.uk>, Mostafa Saleh <smostafa@google.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-pm@vger.kernel.org Subject: [RFC PATCH v3 0/5] Add PSCI v1.3 SYSTEM_OFF2 support for hibernation Date: Tue, 19 Mar 2024 12:59:01 +0000 [thread overview] Message-ID: <20240319130957.1050637-1-dwmw2@infradead.org> (raw) The PSCI v1.3 spec (https://developer.arm.com/documentation/den0022, currently in Alpha state, hence 'RFC') adds support for a SYSTEM_OFF2 function enabling a HIBERNATE_OFF state which is analogous to ACPI S4. This will allow hosting environments to determine that a guest is hibernated rather than just powered off, and ensure that they preserve the virtual environment appropriately to allow the guest to resume safely (or bump the hardware_signature in the FACS to trigger a clean reboot instead). This updates KVM to support advertising PSCI v1.3, and unconditionally enables the SYSTEM_OFF2 support when PSCI v1.3 is enabled. For now, KVM defaults to PSCI v1.2 unless explicitly requested. For the guest side, add a new SYS_OFF_MODE_POWER_OFF handler with higher priority than the EFI one, but which *only* triggers when there's a hibernation in progress. There are other ways to do this (see the commit message for more details) but this seemed like the simplest. Version 2 of the patch series splits out the psci.h definitions into a separate commit (a dependency for both the guest and KVM side), and adds definitions for the other new functions added in v1.3. It also moves the pKVM psci-relay support to a separate commit; although in arch/arm64/kvm that's actually about the *guest* side of SYSTEM_OFF2 (i.e. using it from the host kernel, relayed through nVHE). Version 3 dropped the KVM_CAP which allowed userspace to explicitly opt in to the new feature like with SYSTEM_SUSPEND, and makes it depend only on PSCI v1.3 being exposed to the guest. David Woodhouse (5): firmware/psci: Add definitions for PSCI v1.3 specification (ALPHA) KVM: arm64: Add support for PSCI v1.2 and v1.3 KVM: arm64: Add PSCI v1.3 SYSTEM_OFF2 function for hibernation KVM: arm64: nvhe: Pass through PSCI v1.3 SYSTEM_OFF2 call arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate Documentation/virt/kvm/api.rst | 11 +++++++++ arch/arm64/include/uapi/asm/kvm.h | 6 +++++ arch/arm64/kvm/hyp/nvhe/psci-relay.c | 2 ++ arch/arm64/kvm/hypercalls.c | 2 ++ arch/arm64/kvm/psci.c | 43 +++++++++++++++++++++++++++++++++++- drivers/firmware/psci/psci.c | 35 +++++++++++++++++++++++++++++ include/kvm/arm_psci.h | 4 +++- include/uapi/linux/psci.h | 20 +++++++++++++++++ kernel/power/hibernate.c | 5 ++++- 9 files changed, 125 insertions(+), 3 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: David Woodhouse <dwmw2@infradead.org> To: linux-arm-kernel@lists.infradead.org, kvm@vger.kernel.org Cc: Paolo Bonzini <pbonzini@redhat.com>, Jonathan Corbet <corbet@lwn.net>, Marc Zyngier <maz@kernel.org>, Oliver Upton <oliver.upton@linux.dev>, James Morse <james.morse@arm.com>, Suzuki K Poulose <suzuki.poulose@arm.com>, Zenghui Yu <yuzenghui@huawei.com>, Catalin Marinas <catalin.marinas@arm.com>, Will Deacon <will@kernel.org>, Mark Rutland <mark.rutland@arm.com>, Lorenzo Pieralisi <lpieralisi@kernel.org>, "Rafael J. Wysocki" <rafael@kernel.org>, Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>, David Woodhouse <dwmw@amazon.co.uk>, Mostafa Saleh <smostafa@google.com>, Jean-Philippe Brucker <jean-philippe@linaro.org>, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-pm@vger.kernel.org Subject: [RFC PATCH v3 0/5] Add PSCI v1.3 SYSTEM_OFF2 support for hibernation Date: Tue, 19 Mar 2024 12:59:01 +0000 [thread overview] Message-ID: <20240319130957.1050637-1-dwmw2@infradead.org> (raw) The PSCI v1.3 spec (https://developer.arm.com/documentation/den0022, currently in Alpha state, hence 'RFC') adds support for a SYSTEM_OFF2 function enabling a HIBERNATE_OFF state which is analogous to ACPI S4. This will allow hosting environments to determine that a guest is hibernated rather than just powered off, and ensure that they preserve the virtual environment appropriately to allow the guest to resume safely (or bump the hardware_signature in the FACS to trigger a clean reboot instead). This updates KVM to support advertising PSCI v1.3, and unconditionally enables the SYSTEM_OFF2 support when PSCI v1.3 is enabled. For now, KVM defaults to PSCI v1.2 unless explicitly requested. For the guest side, add a new SYS_OFF_MODE_POWER_OFF handler with higher priority than the EFI one, but which *only* triggers when there's a hibernation in progress. There are other ways to do this (see the commit message for more details) but this seemed like the simplest. Version 2 of the patch series splits out the psci.h definitions into a separate commit (a dependency for both the guest and KVM side), and adds definitions for the other new functions added in v1.3. It also moves the pKVM psci-relay support to a separate commit; although in arch/arm64/kvm that's actually about the *guest* side of SYSTEM_OFF2 (i.e. using it from the host kernel, relayed through nVHE). Version 3 dropped the KVM_CAP which allowed userspace to explicitly opt in to the new feature like with SYSTEM_SUSPEND, and makes it depend only on PSCI v1.3 being exposed to the guest. David Woodhouse (5): firmware/psci: Add definitions for PSCI v1.3 specification (ALPHA) KVM: arm64: Add support for PSCI v1.2 and v1.3 KVM: arm64: Add PSCI v1.3 SYSTEM_OFF2 function for hibernation KVM: arm64: nvhe: Pass through PSCI v1.3 SYSTEM_OFF2 call arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate Documentation/virt/kvm/api.rst | 11 +++++++++ arch/arm64/include/uapi/asm/kvm.h | 6 +++++ arch/arm64/kvm/hyp/nvhe/psci-relay.c | 2 ++ arch/arm64/kvm/hypercalls.c | 2 ++ arch/arm64/kvm/psci.c | 43 +++++++++++++++++++++++++++++++++++- drivers/firmware/psci/psci.c | 35 +++++++++++++++++++++++++++++ include/kvm/arm_psci.h | 4 +++- include/uapi/linux/psci.h | 20 +++++++++++++++++ kernel/power/hibernate.c | 5 ++++- 9 files changed, 125 insertions(+), 3 deletions(-) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2024-03-19 13:10 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2024-03-19 12:59 David Woodhouse [this message] 2024-03-19 12:59 ` [RFC PATCH v3 0/5] Add PSCI v1.3 SYSTEM_OFF2 support for hibernation David Woodhouse 2024-03-19 12:59 ` [RFC PATCH v3 1/5] firmware/psci: Add definitions for PSCI v1.3 specification (ALPHA) David Woodhouse 2024-03-19 12:59 ` David Woodhouse 2024-03-19 12:59 ` [RFC PATCH v3 2/5] KVM: arm64: Add support for PSCI v1.2 and v1.3 David Woodhouse 2024-03-19 12:59 ` David Woodhouse 2024-03-19 15:42 ` Oliver Upton 2024-03-19 15:42 ` Oliver Upton 2024-03-19 15:52 ` David Woodhouse 2024-03-19 15:52 ` David Woodhouse 2024-03-22 16:05 ` Marc Zyngier 2024-03-22 16:05 ` Marc Zyngier 2024-03-22 16:14 ` David Woodhouse 2024-03-22 16:14 ` David Woodhouse 2024-03-19 12:59 ` [RFC PATCH v3 3/5] KVM: arm64: Add PSCI v1.3 SYSTEM_OFF2 function for hibernation David Woodhouse 2024-03-19 12:59 ` David Woodhouse 2024-03-22 16:06 ` Marc Zyngier 2024-03-22 16:06 ` Marc Zyngier 2024-03-19 12:59 ` [RFC PATCH v3 4/5] KVM: arm64: nvhe: Pass through PSCI v1.3 SYSTEM_OFF2 call David Woodhouse 2024-03-19 12:59 ` David Woodhouse 2024-03-19 12:59 ` [RFC PATCH v3 5/5] arm64: Use SYSTEM_OFF2 PSCI call to power off for hibernate David Woodhouse 2024-03-19 12:59 ` David Woodhouse 2024-03-22 16:02 ` Marc Zyngier 2024-03-22 16:02 ` Marc Zyngier 2024-03-22 16:12 ` David Woodhouse 2024-03-22 16:12 ` David Woodhouse 2024-03-22 16:37 ` Marc Zyngier 2024-03-22 16:37 ` Marc Zyngier 2024-03-22 16:55 ` David Woodhouse 2024-03-22 16:55 ` David Woodhouse 2024-03-22 17:08 ` Sudeep Holla 2024-03-22 17:08 ` Sudeep Holla 2024-03-22 17:05 ` Sudeep Holla 2024-03-22 17:05 ` Sudeep Holla 2024-03-19 15:27 ` [RFC PATCH v3 0/5] Add PSCI v1.3 SYSTEM_OFF2 support for hibernation Oliver Upton 2024-03-19 15:27 ` Oliver Upton 2024-03-19 17:14 ` David Woodhouse 2024-03-19 17:14 ` David Woodhouse 2024-03-19 19:41 ` Oliver Upton 2024-03-19 19:41 ` Oliver Upton 2024-03-22 10:17 ` David Woodhouse 2024-03-22 10:17 ` David Woodhouse 2024-03-22 16:09 ` Marc Zyngier 2024-03-22 16:09 ` Marc Zyngier 2024-03-22 17:33 ` David Woodhouse 2024-03-22 17:33 ` David Woodhouse
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20240319130957.1050637-1-dwmw2@infradead.org \ --to=dwmw2@infradead.org \ --cc=catalin.marinas@arm.com \ --cc=corbet@lwn.net \ --cc=dwmw@amazon.co.uk \ --cc=james.morse@arm.com \ --cc=jean-philippe@linaro.org \ --cc=kvm@vger.kernel.org \ --cc=kvmarm@lists.linux.dev \ --cc=len.brown@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=lpieralisi@kernel.org \ --cc=mark.rutland@arm.com \ --cc=maz@kernel.org \ --cc=oliver.upton@linux.dev \ --cc=pavel@ucw.cz \ --cc=pbonzini@redhat.com \ --cc=rafael@kernel.org \ --cc=smostafa@google.com \ --cc=suzuki.poulose@arm.com \ --cc=will@kernel.org \ --cc=yuzenghui@huawei.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.