Re: [PATCH v2 3/3] arm64: dts: rockchip: add Anbernic RG353P and RG503

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Heiko Stübner" <heiko@sntech.de>,
	"Chris Morgan" <macroalpha82@gmail.com>,
	"Maya Matuszczyk" <maccraft123mc@gmail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Peter Geis <pgwipeout@gmail.com>, Chris Healy <cphealy@gmail.com>,
	Chris Morgan <macromorgan@hotmail.com>
Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: add Anbernic RG353P and RG503
Date: Tue, 23 Aug 2022 15:28:52 +0300	[thread overview]
Message-ID: <21c798fc-bfc5-ed67-bcea-a213890e5ef1@linaro.org> (raw)
In-Reply-To: <45694752.fMDQidcC6G@diego>

On 23/08/2022 15:16, Heiko Stübner wrote:
> Am Samstag, 20. August 2022, 10:40:34 CEST schrieb Maya Matuszczyk:
>> sob., 20 sie 2022 o 00:26 Chris Morgan <macroalpha82@gmail.com> napisał(a):
>>>
>>> From: Chris Morgan <macromorgan@hotmail.com>
> 
> [...]
> 
>>> +&gpio_keys_control {
>>> +       button-5 {
>>> +               gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>;
>>> +               label = "DPAD-LEFT";
>>> +               linux,code = <BTN_DPAD_RIGHT>;
>>> +       };
>>> +
>>> +       button-6 {
>>> +               gpios = <&gpio3 RK_PA6 GPIO_ACTIVE_LOW>;
>>> +               label = "DPAD-RIGHT";
>>> +               linux,code = <BTN_DPAD_LEFT>;
>>> +       };
>>> +
>>> +       button-9 {
>>> +               gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>;
>>> +               label = "TR";
>>> +               linux,code = <BTN_TR2>;
>>> +       };
>>> +
>>> +       button-10 {
>>> +               gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_LOW>;
>>> +               label = "TR2";
>>> +               linux,code = <BTN_TR>;
>>> +       };
>>> +
>>> +       button-14 {
>>> +               gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>;
>>> +               label = "WEST";
>>> +               linux,code = <BTN_WEST>;
>>> +       };
>>> +
>>> +       button-15 {
>> I don't think just having the buttons numbered sequentially
>> is the best course of action, but this preserves the GPIO
>> ordering while other options don't...
>> I'm thinking about either having them named after
>> their function, or named after what they're labeled
>> on the PCB of the device.
>> Can any of DT maintainers give their input on this?
> 
> Personally, I'd prefer going with what is on the PCB
> or defined in the schematics.
> 
> This makes it way easier finding dt-elements either in
> schematics or on the board itself.
> 
> This is true for all names ;-)
> 
> On the Odroid-Go for example buttons are really named
> sw1, sw2, ... so the dt-name became button-sw1 etc.
> 

Matching what's on the schematics/board makes sense.

Best regards,
Krzysztof

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip