From: Chris Morgan <macromorgan@hotmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: "Heiko Stübner" <heiko@sntech.de>, "Chris Morgan" <macroalpha82@gmail.com>, "Maya Matuszczyk" <maccraft123mc@gmail.com>, devicetree <devicetree@vger.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Peter Geis" <pgwipeout@gmail.com>, "Chris Healy" <cphealy@gmail.com> Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: add Anbernic RG353P and RG503 Date: Tue, 23 Aug 2022 07:36:25 -0500 [thread overview] Message-ID: <SN6PR06MB53420ACEDA3DF63A64F18A21A5709@SN6PR06MB5342.namprd06.prod.outlook.com> (raw) In-Reply-To: <21c798fc-bfc5-ed67-bcea-a213890e5ef1@linaro.org> On Tue, Aug 23, 2022 at 03:28:52PM +0300, Krzysztof Kozlowski wrote: > On 23/08/2022 15:16, Heiko Stübner wrote: > > Am Samstag, 20. August 2022, 10:40:34 CEST schrieb Maya Matuszczyk: > >> sob., 20 sie 2022 o 00:26 Chris Morgan <macroalpha82@gmail.com> napisał(a): > >>> > >>> From: Chris Morgan <macromorgan@hotmail.com> > > > > [...] > > > >>> +&gpio_keys_control { > >>> + button-5 { > >>> + gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>; > >>> + label = "DPAD-LEFT"; > >>> + linux,code = <BTN_DPAD_RIGHT>; > >>> + }; > >>> + > >>> + button-6 { > >>> + gpios = <&gpio3 RK_PA6 GPIO_ACTIVE_LOW>; > >>> + label = "DPAD-RIGHT"; > >>> + linux,code = <BTN_DPAD_LEFT>; > >>> + }; > >>> + > >>> + button-9 { > >>> + gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>; > >>> + label = "TR"; > >>> + linux,code = <BTN_TR2>; > >>> + }; > >>> + > >>> + button-10 { > >>> + gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_LOW>; > >>> + label = "TR2"; > >>> + linux,code = <BTN_TR>; > >>> + }; > >>> + > >>> + button-14 { > >>> + gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>; > >>> + label = "WEST"; > >>> + linux,code = <BTN_WEST>; > >>> + }; > >>> + > >>> + button-15 { > >> I don't think just having the buttons numbered sequentially > >> is the best course of action, but this preserves the GPIO > >> ordering while other options don't... > >> I'm thinking about either having them named after > >> their function, or named after what they're labeled > >> on the PCB of the device. > >> Can any of DT maintainers give their input on this? > > > > Personally, I'd prefer going with what is on the PCB > > or defined in the schematics. > > > > This makes it way easier finding dt-elements either in > > schematics or on the board itself. > > > > This is true for all names ;-) > > > > On the Odroid-Go for example buttons are really named > > sw1, sw2, ... so the dt-name became button-sw1 etc. > > > > Matching what's on the schematics/board makes sense. I'll do my best (in regards to board name). Schematics won't be possible as Anbernic hasn't released them. > > Best regards, > Krzysztof _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Chris Morgan <macromorgan@hotmail.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: "Heiko Stübner" <heiko@sntech.de>, "Chris Morgan" <macroalpha82@gmail.com>, "Maya Matuszczyk" <maccraft123mc@gmail.com>, devicetree <devicetree@vger.kernel.org>, "open list:ARM/Rockchip SoC..." <linux-rockchip@lists.infradead.org>, "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Peter Geis" <pgwipeout@gmail.com>, "Chris Healy" <cphealy@gmail.com> Subject: Re: [PATCH v2 3/3] arm64: dts: rockchip: add Anbernic RG353P and RG503 Date: Tue, 23 Aug 2022 07:36:25 -0500 [thread overview] Message-ID: <SN6PR06MB53420ACEDA3DF63A64F18A21A5709@SN6PR06MB5342.namprd06.prod.outlook.com> (raw) In-Reply-To: <21c798fc-bfc5-ed67-bcea-a213890e5ef1@linaro.org> On Tue, Aug 23, 2022 at 03:28:52PM +0300, Krzysztof Kozlowski wrote: > On 23/08/2022 15:16, Heiko Stübner wrote: > > Am Samstag, 20. August 2022, 10:40:34 CEST schrieb Maya Matuszczyk: > >> sob., 20 sie 2022 o 00:26 Chris Morgan <macroalpha82@gmail.com> napisał(a): > >>> > >>> From: Chris Morgan <macromorgan@hotmail.com> > > > > [...] > > > >>> +&gpio_keys_control { > >>> + button-5 { > >>> + gpios = <&gpio3 RK_PA5 GPIO_ACTIVE_LOW>; > >>> + label = "DPAD-LEFT"; > >>> + linux,code = <BTN_DPAD_RIGHT>; > >>> + }; > >>> + > >>> + button-6 { > >>> + gpios = <&gpio3 RK_PA6 GPIO_ACTIVE_LOW>; > >>> + label = "DPAD-RIGHT"; > >>> + linux,code = <BTN_DPAD_LEFT>; > >>> + }; > >>> + > >>> + button-9 { > >>> + gpios = <&gpio3 RK_PB3 GPIO_ACTIVE_LOW>; > >>> + label = "TR"; > >>> + linux,code = <BTN_TR2>; > >>> + }; > >>> + > >>> + button-10 { > >>> + gpios = <&gpio3 RK_PB4 GPIO_ACTIVE_LOW>; > >>> + label = "TR2"; > >>> + linux,code = <BTN_TR>; > >>> + }; > >>> + > >>> + button-14 { > >>> + gpios = <&gpio3 RK_PC1 GPIO_ACTIVE_LOW>; > >>> + label = "WEST"; > >>> + linux,code = <BTN_WEST>; > >>> + }; > >>> + > >>> + button-15 { > >> I don't think just having the buttons numbered sequentially > >> is the best course of action, but this preserves the GPIO > >> ordering while other options don't... > >> I'm thinking about either having them named after > >> their function, or named after what they're labeled > >> on the PCB of the device. > >> Can any of DT maintainers give their input on this? > > > > Personally, I'd prefer going with what is on the PCB > > or defined in the schematics. > > > > This makes it way easier finding dt-elements either in > > schematics or on the board itself. > > > > This is true for all names ;-) > > > > On the Odroid-Go for example buttons are really named > > sw1, sw2, ... so the dt-name became button-sw1 etc. > > > > Matching what's on the schematics/board makes sense. I'll do my best (in regards to board name). Schematics won't be possible as Anbernic hasn't released them. > > Best regards, > Krzysztof
next prev parent reply other threads:[~2022-08-23 12:42 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-08-19 22:25 [PATCH v2 0/3] Add Anbernic RG353P and RG503 Chris Morgan 2022-08-19 22:25 ` Chris Morgan 2022-08-19 22:25 ` [PATCH v2 1/3] dt-bindings: vendor-prefixes: add Anbernic Chris Morgan 2022-08-19 22:25 ` Chris Morgan 2022-08-19 22:25 ` [PATCH v2 2/3] dt-bindings: arm: rockchip: Add Anbernic RG353P and RG503 Chris Morgan 2022-08-19 22:25 ` Chris Morgan 2022-08-19 22:25 ` [PATCH v2 3/3] arm64: dts: rockchip: add " Chris Morgan 2022-08-19 22:25 ` Chris Morgan 2022-08-20 8:40 ` Maya Matuszczyk 2022-08-20 8:40 ` Maya Matuszczyk 2022-08-23 12:16 ` Heiko Stübner 2022-08-23 12:16 ` Heiko Stübner 2022-08-23 12:28 ` Maya Matuszczyk 2022-08-23 12:28 ` Maya Matuszczyk 2022-08-23 13:29 ` Chris Morgan 2022-08-23 13:29 ` Chris Morgan 2022-08-23 12:28 ` Krzysztof Kozlowski 2022-08-23 12:28 ` Krzysztof Kozlowski 2022-08-23 12:36 ` Chris Morgan [this message] 2022-08-23 12:36 ` Chris Morgan 2022-08-23 12:35 ` Chris Morgan 2022-08-23 12:35 ` Chris Morgan [not found] ` <20220823123529.GA9857@wintermute.localdomain> 2022-08-23 12:50 ` Chris Morgan 2022-08-23 12:50 ` Chris Morgan 2022-08-23 12:28 ` Krzysztof Kozlowski 2022-08-23 12:28 ` Krzysztof Kozlowski 2022-08-23 12:26 ` Krzysztof Kozlowski 2022-08-23 12:26 ` Krzysztof Kozlowski 2022-08-23 12:40 ` Chris Morgan 2022-08-23 12:40 ` Chris Morgan 2022-08-23 12:41 ` Krzysztof Kozlowski 2022-08-23 12:41 ` Krzysztof Kozlowski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=SN6PR06MB53420ACEDA3DF63A64F18A21A5709@SN6PR06MB5342.namprd06.prod.outlook.com \ --to=macromorgan@hotmail.com \ --cc=cphealy@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-rockchip@lists.infradead.org \ --cc=maccraft123mc@gmail.com \ --cc=macroalpha82@gmail.com \ --cc=pgwipeout@gmail.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.