From: Matthias Brugger <matthias.bgg@gmail.com>
To: James Liao <jamesjj.liao@mediatek.com>
Cc: Daniel Kurtz <djkurtz@chromium.org>,
Mike Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@codeaurora.org>,
Heiko Stubner <heiko@sntech.de>,
srv_heupstream <srv_heupstream@mediatek.com>,
Ricky Liang <jcliang@chromium.org>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
"open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes
Date: Mon, 27 Jul 2015 03:21:01 -0700 (PDT) [thread overview]
Message-ID: <24796517.2pfRdOOmRJ@ubix> (raw)
In-Reply-To: <1437965782.5614.4.camel@mtksdaap41>
On Monday, July 27, 2015 10:56:22 AM James Liao wrote:
> Hi Daniel,
>
> On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote:
> > > @@ -88,6 +88,13 @@
> > >
> > > #clock-cells = <0>;
> > >
> > > };
> > >
> > > + cpum_ck: dummy_clk {
> >
> > I'm not a big fan of this "dummy_clk".
> > The 'name' part of the devicetree node is supposed to be generic.
> > So, perhaps just oscillator@2, and move it down below clk32k:
> > oscillator@1.
>
> > Otherwise:
> cpum_ck is a test clock which only available in IC test. It's empty on
> MT8173 evaluation or production boards. Should we name this kind of
> empty clock as an oscillator? Or is there a better name for it?
>
So if it will never be part of any available boards, why do you want to add
it?
Regards,
Matthias
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: James Liao <jamesjj.liao-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
Cc: Daniel Kurtz <djkurtz-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Mike Turquette
<mturquette-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>,
Stephen Boyd <sboyd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Heiko Stubner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>,
srv_heupstream
<srv_heupstream-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>,
Ricky Liang <jcliang-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Sascha Hauer <kernel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>,
"open list:OPEN FIRMWARE AND..."
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org"
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
"linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Subject: Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes
Date: Mon, 27 Jul 2015 03:21:01 -0700 (PDT) [thread overview]
Message-ID: <24796517.2pfRdOOmRJ@ubix> (raw)
In-Reply-To: <1437965782.5614.4.camel@mtksdaap41>
On Monday, July 27, 2015 10:56:22 AM James Liao wrote:
> Hi Daniel,
>
> On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote:
> > > @@ -88,6 +88,13 @@
> > >
> > > #clock-cells = <0>;
> > >
> > > };
> > >
> > > + cpum_ck: dummy_clk {
> >
> > I'm not a big fan of this "dummy_clk".
> > The 'name' part of the devicetree node is supposed to be generic.
> > So, perhaps just oscillator@2, and move it down below clk32k:
> > oscillator@1.
>
> > Otherwise:
> cpum_ck is a test clock which only available in IC test. It's empty on
> MT8173 evaluation or production boards. Should we name this kind of
> empty clock as an oscillator? Or is there a better name for it?
>
So if it will never be part of any available boards, why do you want to add
it?
Regards,
Matthias
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes
Date: Mon, 27 Jul 2015 03:21:01 -0700 (PDT) [thread overview]
Message-ID: <24796517.2pfRdOOmRJ@ubix> (raw)
In-Reply-To: <1437965782.5614.4.camel@mtksdaap41>
On Monday, July 27, 2015 10:56:22 AM James Liao wrote:
> Hi Daniel,
>
> On Fri, 2015-07-24 at 19:32 +0800, Daniel Kurtz wrote:
> > > @@ -88,6 +88,13 @@
> > >
> > > #clock-cells = <0>;
> > >
> > > };
> > >
> > > + cpum_ck: dummy_clk {
> >
> > I'm not a big fan of this "dummy_clk".
> > The 'name' part of the devicetree node is supposed to be generic.
> > So, perhaps just oscillator at 2, and move it down below clk32k:
> > oscillator at 1.
>
> > Otherwise:
> cpum_ck is a test clock which only available in IC test. It's empty on
> MT8173 evaluation or production boards. Should we name this kind of
> empty clock as an oscillator? Or is there a better name for it?
>
So if it will never be part of any available boards, why do you want to add
it?
Regards,
Matthias
next prev parent reply other threads:[~2015-07-27 10:21 UTC|newest]
Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 3:01 [PATCH v4 0/7] Add Mediatek MT8173 subsystem clocks support James Liao
2015-07-24 3:01 ` James Liao
2015-07-24 3:01 ` James Liao
2015-07-24 3:01 ` [PATCH v4 1/7] clk: mediatek: Add fixed clocks support for Mediatek SoC James Liao
2015-07-24 3:01 ` James Liao
2015-07-24 3:01 ` James Liao
2015-07-24 11:33 ` Daniel Kurtz
2015-07-24 11:33 ` Daniel Kurtz
2015-07-24 11:33 ` Daniel Kurtz
2015-07-28 5:10 ` James Liao
2015-07-28 5:10 ` James Liao
2015-07-28 5:10 ` James Liao
2015-07-24 3:02 ` [PATCH v4 2/7] clk: mediatek: Fix rate and dependency of MT8173 clocks James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 11:10 ` Daniel Kurtz
2015-07-24 11:10 ` Daniel Kurtz
2015-07-24 11:10 ` Daniel Kurtz
2015-07-27 5:52 ` Sascha Hauer
2015-07-27 5:52 ` Sascha Hauer
2015-07-27 5:52 ` Sascha Hauer
2015-07-27 6:19 ` Daniel Kurtz
2015-07-27 7:52 ` Heiko Stübner
2015-07-27 7:52 ` Heiko Stübner
2015-07-27 7:52 ` Heiko Stübner
2015-07-28 5:19 ` James Liao
2015-07-28 5:19 ` James Liao
2015-07-28 5:19 ` James Liao
2015-07-24 3:02 ` [PATCH v4 3/7] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` [PATCH v4 4/7] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` [PATCH v4 5/7] clk: mediatek: Add subsystem clocks of MT8173 James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 11:18 ` Daniel Kurtz
2015-07-24 11:18 ` Daniel Kurtz
2015-07-24 11:18 ` Daniel Kurtz
2015-07-28 2:14 ` James Liao
2015-07-28 2:14 ` James Liao
2015-07-28 2:14 ` James Liao
2015-07-24 3:02 ` [PATCH v4 6/7] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 11:28 ` Daniel Kurtz
2015-07-24 11:28 ` Daniel Kurtz
2015-07-24 11:28 ` Daniel Kurtz
2015-07-28 4:05 ` James Liao
2015-07-28 4:05 ` James Liao
2015-07-28 4:05 ` James Liao
2015-07-24 3:02 ` [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 3:02 ` James Liao
2015-07-24 11:32 ` Daniel Kurtz
2015-07-24 11:32 ` Daniel Kurtz
2015-07-24 11:32 ` Daniel Kurtz
2015-07-27 2:56 ` James Liao
2015-07-27 2:56 ` James Liao
2015-07-27 2:56 ` James Liao
2015-07-27 5:34 ` Daniel Kurtz
2015-07-27 10:21 ` Matthias Brugger [this message]
2015-07-27 10:21 ` Matthias Brugger
2015-07-27 10:21 ` Matthias Brugger
2015-07-28 5:29 ` James Liao
2015-07-28 5:29 ` James Liao
2015-07-28 5:29 ` James Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24796517.2pfRdOOmRJ@ubix \
--to=matthias.bgg@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=heiko@sntech.de \
--cc=jamesjj.liao@mediatek.com \
--cc=jcliang@chromium.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=srv_heupstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.