From: Daniel Kurtz <djkurtz@chromium.org> To: James Liao <jamesjj.liao@mediatek.com> Cc: Matthias Brugger <matthias.bgg@gmail.com>, Mike Turquette <mturquette@baylibre.com>, Stephen Boyd <sboyd@codeaurora.org>, Heiko Stubner <heiko@sntech.de>, srv_heupstream <srv_heupstream@mediatek.com>, Ricky Liang <jcliang@chromium.org>, Rob Herring <robh+dt@kernel.org>, Sascha Hauer <kernel@pengutronix.de>, "open list:OPEN FIRMWARE AND..." <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes Date: Fri, 24 Jul 2015 19:32:32 +0800 [thread overview] Message-ID: <CAGS+omAUAHZUJQMnWJbH7NXB_Etp=OF3dWyMB7Ri1+rAyzyPBg@mail.gmail.com> (raw) In-Reply-To: <1437706925-3222-8-git-send-email-jamesjj.liao@mediatek.com> On Fri, Jul 24, 2015 at 11:02 AM, James Liao <jamesjj.liao@mediatek.com> wrote: > This patch adds device nodes providing subsystem clocks on MT8173, > includes mmsys, imgsys, vdecsys, vencsys and vencltsys. > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 ++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index a2f63e4..8731d24 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -88,6 +88,13 @@ > #clock-cells = <0>; > }; > > + cpum_ck: dummy_clk { I'm not a big fan of this "dummy_clk". The 'name' part of the devicetree node is supposed to be generic. So, perhaps just oscillator@2, and move it down below clk32k: oscillator@1. Otherwise: Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> -Dan > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + clock-output-names = "cpum_ck"; > + }; > + > clk26m: oscillator@0 { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -227,6 +234,36 @@ > clocks = <&uart_clk>; > status = "disabled"; > }; > + > + mmsys: clock-controller@14000000 { > + compatible = "mediatek,mt8173-mmsys", "syscon"; > + reg = <0 0x14000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + imgsys: clock-controller@15000000 { > + compatible = "mediatek,mt8173-imgsys", "syscon"; > + reg = <0 0x15000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vdecsys: clock-controller@16000000 { > + compatible = "mediatek,mt8173-vdecsys", "syscon"; > + reg = <0 0x16000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vencsys: clock-controller@18000000 { > + compatible = "mediatek,mt8173-vencsys", "syscon"; > + reg = <0 0x18000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vencltsys: clock-controller@19000000 { > + compatible = "mediatek,mt8173-vencltsys", "syscon"; > + reg = <0 0x19000000 0 0x1000>; > + #clock-cells = <1>; > + }; > }; > }; > > -- > 1.8.1.1.dirty >
WARNING: multiple messages have this Message-ID (diff)
From: djkurtz@chromium.org (Daniel Kurtz) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes Date: Fri, 24 Jul 2015 19:32:32 +0800 [thread overview] Message-ID: <CAGS+omAUAHZUJQMnWJbH7NXB_Etp=OF3dWyMB7Ri1+rAyzyPBg@mail.gmail.com> (raw) In-Reply-To: <1437706925-3222-8-git-send-email-jamesjj.liao@mediatek.com> On Fri, Jul 24, 2015 at 11:02 AM, James Liao <jamesjj.liao@mediatek.com> wrote: > This patch adds device nodes providing subsystem clocks on MT8173, > includes mmsys, imgsys, vdecsys, vencsys and vencltsys. > > Signed-off-by: James Liao <jamesjj.liao@mediatek.com> > --- > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 37 ++++++++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > index a2f63e4..8731d24 100644 > --- a/arch/arm64/boot/dts/mediatek/mt8173.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt8173.dtsi > @@ -88,6 +88,13 @@ > #clock-cells = <0>; > }; > > + cpum_ck: dummy_clk { I'm not a big fan of this "dummy_clk". The 'name' part of the devicetree node is supposed to be generic. So, perhaps just oscillator at 2, and move it down below clk32k: oscillator at 1. Otherwise: Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> -Dan > + compatible = "fixed-clock"; > + #clock-cells = <0>; > + clock-frequency = <0>; > + clock-output-names = "cpum_ck"; > + }; > + > clk26m: oscillator at 0 { > compatible = "fixed-clock"; > #clock-cells = <0>; > @@ -227,6 +234,36 @@ > clocks = <&uart_clk>; > status = "disabled"; > }; > + > + mmsys: clock-controller at 14000000 { > + compatible = "mediatek,mt8173-mmsys", "syscon"; > + reg = <0 0x14000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + imgsys: clock-controller at 15000000 { > + compatible = "mediatek,mt8173-imgsys", "syscon"; > + reg = <0 0x15000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vdecsys: clock-controller at 16000000 { > + compatible = "mediatek,mt8173-vdecsys", "syscon"; > + reg = <0 0x16000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vencsys: clock-controller at 18000000 { > + compatible = "mediatek,mt8173-vencsys", "syscon"; > + reg = <0 0x18000000 0 0x1000>; > + #clock-cells = <1>; > + }; > + > + vencltsys: clock-controller at 19000000 { > + compatible = "mediatek,mt8173-vencltsys", "syscon"; > + reg = <0 0x19000000 0 0x1000>; > + #clock-cells = <1>; > + }; > }; > }; > > -- > 1.8.1.1.dirty >
next prev parent reply other threads:[~2015-07-24 11:32 UTC|newest] Thread overview: 68+ messages / expand[flat|nested] mbox.gz Atom feed top 2015-07-24 3:01 [PATCH v4 0/7] Add Mediatek MT8173 subsystem clocks support James Liao 2015-07-24 3:01 ` James Liao 2015-07-24 3:01 ` James Liao 2015-07-24 3:01 ` [PATCH v4 1/7] clk: mediatek: Add fixed clocks support for Mediatek SoC James Liao 2015-07-24 3:01 ` James Liao 2015-07-24 3:01 ` James Liao 2015-07-24 11:33 ` Daniel Kurtz 2015-07-24 11:33 ` Daniel Kurtz 2015-07-24 11:33 ` Daniel Kurtz 2015-07-28 5:10 ` James Liao 2015-07-28 5:10 ` James Liao 2015-07-28 5:10 ` James Liao 2015-07-24 3:02 ` [PATCH v4 2/7] clk: mediatek: Fix rate and dependency of MT8173 clocks James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 11:10 ` Daniel Kurtz 2015-07-24 11:10 ` Daniel Kurtz 2015-07-24 11:10 ` Daniel Kurtz 2015-07-27 5:52 ` Sascha Hauer 2015-07-27 5:52 ` Sascha Hauer 2015-07-27 5:52 ` Sascha Hauer 2015-07-27 6:19 ` Daniel Kurtz 2015-07-27 7:52 ` Heiko Stübner 2015-07-27 7:52 ` Heiko Stübner 2015-07-27 7:52 ` Heiko Stübner 2015-07-28 5:19 ` James Liao 2015-07-28 5:19 ` James Liao 2015-07-28 5:19 ` James Liao 2015-07-24 3:02 ` [PATCH v4 3/7] clk: mediatek: mt8173: Fix enabling of critical clocks James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` [PATCH v4 4/7] dt-bindings: ARM: Mediatek: Document devicetree bindings for clock controllers James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` [PATCH v4 5/7] clk: mediatek: Add subsystem clocks of MT8173 James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 11:18 ` Daniel Kurtz 2015-07-24 11:18 ` Daniel Kurtz 2015-07-24 11:18 ` Daniel Kurtz 2015-07-28 2:14 ` James Liao 2015-07-28 2:14 ` James Liao 2015-07-28 2:14 ` James Liao 2015-07-24 3:02 ` [PATCH v4 6/7] clk: mediatek: Add USB clock support in MT8173 APMIXEDSYS James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 11:28 ` Daniel Kurtz 2015-07-24 11:28 ` Daniel Kurtz 2015-07-24 11:28 ` Daniel Kurtz 2015-07-28 4:05 ` James Liao 2015-07-28 4:05 ` James Liao 2015-07-28 4:05 ` James Liao 2015-07-24 3:02 ` [PATCH v4 7/7] arm64: dts: mt8173: Add subsystem clock controller device nodes James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 3:02 ` James Liao 2015-07-24 11:32 ` Daniel Kurtz [this message] 2015-07-24 11:32 ` Daniel Kurtz 2015-07-24 11:32 ` Daniel Kurtz 2015-07-27 2:56 ` James Liao 2015-07-27 2:56 ` James Liao 2015-07-27 2:56 ` James Liao 2015-07-27 5:34 ` Daniel Kurtz 2015-07-27 10:21 ` Matthias Brugger 2015-07-27 10:21 ` Matthias Brugger 2015-07-27 10:21 ` Matthias Brugger 2015-07-28 5:29 ` James Liao 2015-07-28 5:29 ` James Liao 2015-07-28 5:29 ` James Liao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAGS+omAUAHZUJQMnWJbH7NXB_Etp=OF3dWyMB7Ri1+rAyzyPBg@mail.gmail.com' \ --to=djkurtz@chromium.org \ --cc=devicetree@vger.kernel.org \ --cc=heiko@sntech.de \ --cc=jamesjj.liao@mediatek.com \ --cc=jcliang@chromium.org \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=mturquette@baylibre.com \ --cc=robh+dt@kernel.org \ --cc=sboyd@codeaurora.org \ --cc=srv_heupstream@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.