From: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
To: Geert Uytterhoeven
<geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Cc: Simon Horman
<horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org>,
Magnus Damm <magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
"Rafael J. Wysocki" <rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org>,
Kevin Hilman <khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Ulf Hansson <ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 4/7] soc: renesas: Add r8a7791 SYSC PM Domain Binding Definitions
Date: Thu, 10 Mar 2016 08:58:12 +0200 [thread overview]
Message-ID: <27503872.R73ke9ZNPh@avalon> (raw)
In-Reply-To: <1457551122-21838-5-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
Hi Geert,
Thank you for the patch.
On Wednesday 09 March 2016 20:18:39 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> ---
> v3:
> - New.
> ---
> include/dt-bindings/power/r8a7791-sysc.h | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 include/dt-bindings/power/r8a7791-sysc.h
>
> diff --git a/include/dt-bindings/power/r8a7791-sysc.h
> b/include/dt-bindings/power/r8a7791-sysc.h new file mode 100644
> index 0000000000000000..791bcdc0df1c6c04
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7791-sysc.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7791_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7791_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + */
> +
> +#define R8A7791_PD_CA15_CPU0 0
> +#define R8A7791_PD_CA15_CPU1 1
> +#define R8A7791_PD_CA15_SCU 12
> +#define R8A7791_PD_SH 16
The power domain is called SH-4A in the datasheet, how about naming it
R8A7791_PD_SH_4A ?
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
> +#define R8A7791_PD_SGX 20
> +
> +#endif /* __DT_BINDINGS_POWER_R8A7791_SYSC_H__ */
--
Regards,
Laurent Pinchart
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Simon Horman <horms+renesas@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Kevin Hilman <khilman@kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 4/7] soc: renesas: Add r8a7791 SYSC PM Domain Binding Definitions
Date: Thu, 10 Mar 2016 08:58:12 +0200 [thread overview]
Message-ID: <27503872.R73ke9ZNPh@avalon> (raw)
In-Reply-To: <1457551122-21838-5-git-send-email-geert+renesas@glider.be>
Hi Geert,
Thank you for the patch.
On Wednesday 09 March 2016 20:18:39 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
> - New.
> ---
> include/dt-bindings/power/r8a7791-sysc.h | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
> create mode 100644 include/dt-bindings/power/r8a7791-sysc.h
>
> diff --git a/include/dt-bindings/power/r8a7791-sysc.h
> b/include/dt-bindings/power/r8a7791-sysc.h new file mode 100644
> index 0000000000000000..791bcdc0df1c6c04
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7791-sysc.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7791_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7791_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + */
> +
> +#define R8A7791_PD_CA15_CPU0 0
> +#define R8A7791_PD_CA15_CPU1 1
> +#define R8A7791_PD_CA15_SCU 12
> +#define R8A7791_PD_SH 16
The power domain is called SH-4A in the datasheet, how about naming it
R8A7791_PD_SH_4A ?
Apart from that,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +#define R8A7791_PD_SGX 20
> +
> +#endif /* __DT_BINDINGS_POWER_R8A7791_SYSC_H__ */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-03-10 6:58 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-09 19:18 [PATCH v3 0/7] PM / Domains: Add DT bindings for the R-Car System Controller Geert Uytterhoeven
2016-03-09 19:18 ` Geert Uytterhoeven
2016-03-09 19:18 ` [PATCH v3 2/7] soc: renesas: Add r8a7779 SYSC PM Domain Binding Definitions Geert Uytterhoeven
2016-03-10 2:40 ` Laurent Pinchart
2016-03-10 8:02 ` Geert Uytterhoeven
[not found] ` <1457551122-21838-1-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2016-03-09 19:18 ` [PATCH v3 1/7] PM / Domains: Add DT bindings for the R-Car System Controller Geert Uytterhoeven
2016-03-09 19:18 ` Geert Uytterhoeven
2016-03-10 2:24 ` Laurent Pinchart
2016-03-10 8:21 ` Geert Uytterhoeven
2016-03-17 19:17 ` Rob Herring
2016-03-09 19:18 ` [PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions Geert Uytterhoeven
2016-03-09 19:18 ` Geert Uytterhoeven
2016-03-10 6:57 ` Laurent Pinchart
2016-03-10 8:26 ` Geert Uytterhoeven
2016-03-10 8:26 ` Geert Uytterhoeven
[not found] ` <CAMuHMdVy1eY1t55NSmdkJ=haFEPYWoTReecOOK-63XaJj6ztew-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-03-24 15:35 ` Geert Uytterhoeven
2016-03-24 15:35 ` Geert Uytterhoeven
2016-03-09 19:18 ` [PATCH v3 4/7] soc: renesas: Add r8a7791 " Geert Uytterhoeven
2016-03-09 19:18 ` Geert Uytterhoeven
[not found] ` <1457551122-21838-5-git-send-email-geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
2016-03-10 6:58 ` Laurent Pinchart [this message]
2016-03-10 6:58 ` Laurent Pinchart
2016-03-09 19:18 ` [PATCH v3 7/7] soc: renesas: Add r8a7795 " Geert Uytterhoeven
2016-03-09 19:18 ` Geert Uytterhoeven
2016-03-10 2:32 ` Laurent Pinchart
2016-03-10 8:17 ` Geert Uytterhoeven
2016-03-10 8:54 ` Laurent Pinchart
2016-03-09 19:18 ` [PATCH v3 5/7] soc: renesas: Add r8a7793 " Geert Uytterhoeven
2016-03-10 6:59 ` Laurent Pinchart
2016-03-10 8:09 ` Geert Uytterhoeven
2016-03-10 8:09 ` Geert Uytterhoeven
2016-03-24 16:09 ` Geert Uytterhoeven
2016-03-09 19:18 ` [PATCH v3 6/7] soc: renesas: Add r8a7794 " Geert Uytterhoeven
2016-03-10 2:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=27503872.R73ke9ZNPh@avalon \
--to=laurent.pinchart-rylnwiuwjnjg/c1bvhzhaw@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org \
--cc=geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org \
--cc=horms+renesas-/R6kz+dDXgpPR4JQBCEnsQ@public.gmane.org \
--cc=ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org \
--cc=khilman-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-renesas-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=magnus.damm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=pawel.moll-5wv7dgnIgG8@public.gmane.org \
--cc=rjw-LthD3rsA81gm4RdzfppkhA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=ulf.hansson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.