From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Evan Green <evgreen@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
Will Deacon <will.deacon@arm.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
anan.sun@mediatek.com, chao.hao@mediatek.com,
ming-fan.chen@mediatek.com, yi.kuo@mediatek.com,
eizan@chromium.org, acourbot@chromium.org
Subject: Re: [PATCH v5 09/16] drm/mediatek: Use pm_runtime_resume_and_get for PM get_sync
Date: Wed, 9 Jun 2021 15:52:57 +0200 [thread overview]
Message-ID: <299857fd-533d-5e6e-0744-92ee56078638@gmail.com> (raw)
In-Reply-To: <20210410091128.31823-10-yong.wu@mediatek.com>
On 10/04/2021 11:11, Yong Wu wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> This patch use pm_runtime_resume_and_get instead of pm_runtime_get
> to keep usage counter balanced.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index 8b0de90156c6..69d23ce56d2c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
> drm_connector_list_iter_end(&conn_iter);
> }
>
> - ret = pm_runtime_get_sync(crtc->dev->dev);
> + ret = pm_runtime_resume_and_get(crtc->dev->dev);
> if (ret < 0) {
> DRM_ERROR("Failed to enable power domain: %d\n", ret);
> return ret;
>
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: youlin.pei@mediatek.com, devicetree@vger.kernel.org,
yi.kuo@mediatek.com, Nicolas Boichat <drinkcat@chromium.org>,
acourbot@chromium.org, srv_heupstream@mediatek.com,
eizan@chromium.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org, Evan Green <evgreen@chromium.org>,
chao.hao@mediatek.com, iommu@lists.linux-foundation.org,
Matthias Kaehlcke <mka@chromium.org>,
linux-mediatek@lists.infradead.org, ming-fan.chen@mediatek.com,
anan.sun@mediatek.com, Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 09/16] drm/mediatek: Use pm_runtime_resume_and_get for PM get_sync
Date: Wed, 9 Jun 2021 15:52:57 +0200 [thread overview]
Message-ID: <299857fd-533d-5e6e-0744-92ee56078638@gmail.com> (raw)
In-Reply-To: <20210410091128.31823-10-yong.wu@mediatek.com>
On 10/04/2021 11:11, Yong Wu wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> This patch use pm_runtime_resume_and_get instead of pm_runtime_get
> to keep usage counter balanced.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index 8b0de90156c6..69d23ce56d2c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
> drm_connector_list_iter_end(&conn_iter);
> }
>
> - ret = pm_runtime_get_sync(crtc->dev->dev);
> + ret = pm_runtime_resume_and_get(crtc->dev->dev);
> if (ret < 0) {
> DRM_ERROR("Failed to enable power domain: %d\n", ret);
> return ret;
>
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Evan Green <evgreen@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
Will Deacon <will.deacon@arm.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
anan.sun@mediatek.com, chao.hao@mediatek.com,
ming-fan.chen@mediatek.com, yi.kuo@mediatek.com,
eizan@chromium.org, acourbot@chromium.org
Subject: Re: [PATCH v5 09/16] drm/mediatek: Use pm_runtime_resume_and_get for PM get_sync
Date: Wed, 9 Jun 2021 15:52:57 +0200 [thread overview]
Message-ID: <299857fd-533d-5e6e-0744-92ee56078638@gmail.com> (raw)
In-Reply-To: <20210410091128.31823-10-yong.wu@mediatek.com>
On 10/04/2021 11:11, Yong Wu wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> This patch use pm_runtime_resume_and_get instead of pm_runtime_get
> to keep usage counter balanced.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index 8b0de90156c6..69d23ce56d2c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
> drm_connector_list_iter_end(&conn_iter);
> }
>
> - ret = pm_runtime_get_sync(crtc->dev->dev);
> + ret = pm_runtime_resume_and_get(crtc->dev->dev);
> if (ret < 0) {
> DRM_ERROR("Failed to enable power domain: %d\n", ret);
> return ret;
>
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: Matthias Brugger <matthias.bgg@gmail.com>
To: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: Evan Green <evgreen@chromium.org>,
Robin Murphy <robin.murphy@arm.com>,
Tomasz Figa <tfiga@chromium.org>,
Will Deacon <will.deacon@arm.com>,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org, youlin.pei@mediatek.com,
Nicolas Boichat <drinkcat@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
anan.sun@mediatek.com, chao.hao@mediatek.com,
ming-fan.chen@mediatek.com, yi.kuo@mediatek.com,
eizan@chromium.org, acourbot@chromium.org
Subject: Re: [PATCH v5 09/16] drm/mediatek: Use pm_runtime_resume_and_get for PM get_sync
Date: Wed, 9 Jun 2021 15:52:57 +0200 [thread overview]
Message-ID: <299857fd-533d-5e6e-0744-92ee56078638@gmail.com> (raw)
In-Reply-To: <20210410091128.31823-10-yong.wu@mediatek.com>
On 10/04/2021 11:11, Yong Wu wrote:
> pm_runtime_get_sync will increment pm usage counter even it failed.
> This patch use pm_runtime_resume_and_get instead of pm_runtime_get
> to keep usage counter balanced.
>
> Signed-off-by: Yong Wu <yong.wu@mediatek.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> index 8b0de90156c6..69d23ce56d2c 100644
> --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c
> @@ -259,7 +259,7 @@ static int mtk_crtc_ddp_hw_init(struct mtk_drm_crtc *mtk_crtc)
> drm_connector_list_iter_end(&conn_iter);
> }
>
> - ret = pm_runtime_get_sync(crtc->dev->dev);
> + ret = pm_runtime_resume_and_get(crtc->dev->dev);
> if (ret < 0) {
> DRM_ERROR("Failed to enable power domain: %d\n", ret);
> return ret;
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-09 13:54 UTC|newest]
Thread overview: 136+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-10 9:11 [PATCH v5 00/16] Clean up "mediatek,larb" Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 01/16] dt-binding: mediatek: Get rid of mediatek,larb for multimedia HW Yong Wu
2021-04-10 9:11 ` [PATCH v5 01/16] dt-binding: mediatek: Get rid of mediatek, larb " Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 02/16] iommu/mediatek: Add probe_defer for smi-larb Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 03/16] iommu/mediatek: Add device_link between the consumer and the larb devices Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 04/16] memory: mtk-smi: Add device-link between smi-larb and smi-common Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 12:40 ` Krzysztof Kozlowski
2021-04-10 12:40 ` Krzysztof Kozlowski
2021-04-10 12:40 ` Krzysztof Kozlowski
2021-04-10 12:40 ` Krzysztof Kozlowski
2021-04-13 6:04 ` Yong Wu
2021-04-13 6:04 ` Yong Wu
2021-04-13 6:04 ` Yong Wu
2021-04-13 6:04 ` Yong Wu
2021-04-13 14:58 ` Krzysztof Kozlowski
2021-04-13 14:58 ` Krzysztof Kozlowski
2021-04-13 14:58 ` Krzysztof Kozlowski
2021-04-13 14:58 ` Krzysztof Kozlowski
2021-04-10 9:11 ` [PATCH v5 05/16] media: mtk-jpeg: Use pm_runtime_resume_and_get for PM get_sync Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-06-09 13:38 ` Matthias Brugger
2021-06-09 13:38 ` Matthias Brugger
2021-06-09 13:38 ` Matthias Brugger
2021-06-09 13:38 ` Matthias Brugger
2021-04-10 9:11 ` [PATCH v5 06/16] media: mtk-jpeg: Get rid of mtk_smi_larb_get/put Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 07/16] media: mtk-mdp: Use pm_runtime_resume_and_get for PM get_sync Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 08/16] media: mtk-mdp: Get rid of mtk_smi_larb_get/put Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-06-08 9:35 ` houlong wei
2021-06-08 9:35 ` houlong wei
2021-06-08 9:35 ` houlong wei
2021-06-08 9:35 ` houlong wei
2021-04-10 9:11 ` [PATCH v5 09/16] drm/mediatek: Use pm_runtime_resume_and_get for PM get_sync Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-06-09 13:52 ` Matthias Brugger [this message]
2021-06-09 13:52 ` Matthias Brugger
2021-06-09 13:52 ` Matthias Brugger
2021-06-09 13:52 ` Matthias Brugger
2021-04-10 9:11 ` [PATCH v5 10/16] drm/mediatek: Add pm runtime support for ovl and rdma Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 11/16] drm/mediatek: Get rid of mtk_smi_larb_get/put Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-05-26 5:41 ` Dafna Hirschfeld
2021-05-26 5:41 ` Dafna Hirschfeld
2021-05-26 5:41 ` Dafna Hirschfeld
2021-05-26 5:41 ` Dafna Hirschfeld
2021-06-10 12:00 ` Yong Wu
2021-06-10 12:00 ` Yong Wu
2021-06-10 12:00 ` Yong Wu
2021-06-10 12:00 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 12/16] media: mtk-vcodec: Use pm_runtime_resume_and_get for PM get_sync Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 13/16] media: mtk-vcodec: Get rid of mtk_smi_larb_get/put Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-05-12 9:20 ` Hsin-Yi Wang
2021-05-12 9:20 ` Hsin-Yi Wang
2021-05-12 9:20 ` Hsin-Yi Wang
2021-05-12 9:20 ` Hsin-Yi Wang
2021-05-12 12:29 ` Yong Wu
2021-05-12 12:29 ` Yong Wu
2021-05-12 12:29 ` Yong Wu
2021-05-12 12:29 ` Yong Wu
2021-06-10 7:53 ` Matthias Brugger
2021-06-10 7:53 ` Matthias Brugger
2021-06-10 7:53 ` Matthias Brugger
2021-06-10 7:53 ` Matthias Brugger
2021-06-10 12:02 ` Yong Wu
2021-06-10 12:02 ` Yong Wu
2021-06-10 12:02 ` Yong Wu
2021-06-10 12:02 ` Yong Wu
2021-06-11 10:07 ` Matthias Brugger
2021-06-11 10:07 ` Matthias Brugger
2021-06-11 10:07 ` Matthias Brugger
2021-06-11 10:07 ` Matthias Brugger
2021-06-11 10:46 ` Joerg Roedel
2021-06-11 10:46 ` Joerg Roedel
2021-06-11 10:46 ` Joerg Roedel
2021-06-11 10:46 ` Joerg Roedel
2021-04-10 9:11 ` [PATCH v5 14/16] memory: mtk-smi: " Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-13 14:04 ` Krzysztof Kozlowski
2021-04-13 14:04 ` Krzysztof Kozlowski
2021-04-13 14:04 ` Krzysztof Kozlowski
2021-04-13 14:04 ` Krzysztof Kozlowski
2021-06-09 14:42 ` Matthias Brugger
2021-06-09 14:42 ` Matthias Brugger
2021-06-09 14:42 ` Matthias Brugger
2021-06-09 14:42 ` Matthias Brugger
2021-04-10 9:11 ` [PATCH v5 15/16] arm: dts: mediatek: Get rid of mediatek,larb for MM nodes Yong Wu
2021-04-10 9:11 ` [PATCH v5 15/16] arm: dts: mediatek: Get rid of mediatek, larb " Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` [PATCH v5 16/16] arm64: dts: mediatek: Get rid of mediatek,larb " Yong Wu
2021-04-10 9:11 ` [PATCH v5 16/16] arm64: dts: mediatek: Get rid of mediatek, larb " Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-10 9:11 ` Yong Wu
2021-04-13 14:58 ` (subset) [PATCH v5 00/16] Clean up "mediatek,larb" Krzysztof Kozlowski
2021-04-13 14:58 ` Krzysztof Kozlowski
2021-04-13 14:58 ` Krzysztof Kozlowski
2021-04-13 14:58 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=299857fd-533d-5e6e-0744-92ee56078638@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=acourbot@chromium.org \
--cc=anan.sun@mediatek.com \
--cc=chao.hao@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=eizan@chromium.org \
--cc=evgreen@chromium.org \
--cc=iommu@lists.linux-foundation.org \
--cc=joro@8bytes.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=ming-fan.chen@mediatek.com \
--cc=mka@chromium.org \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=srv_heupstream@mediatek.com \
--cc=tfiga@chromium.org \
--cc=will.deacon@arm.com \
--cc=yi.kuo@mediatek.com \
--cc=yong.wu@mediatek.com \
--cc=youlin.pei@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.