From: Lu Baolu <baolu.lu@linux.intel.com>
To: Keqian Zhu <zhukeqian1@huawei.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Yi Sun <yi.y.sun@linux.intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Tian Kevin <kevin.tian@intel.com>
Cc: baolu.lu@linux.intel.com,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
wanghaibin.wang@huawei.com, jiangkunkun@huawei.com,
yuzenghui@huawei.com, lushenming@huawei.com
Subject: Re: [PATCH v3 01/12] iommu: Introduce dirty log tracking framework
Date: Thu, 15 Apr 2021 18:21:22 +0800 [thread overview]
Message-ID: <2c01425f-813c-4278-ba06-26d651496a5c@linux.intel.com> (raw)
In-Reply-To: <88cba608-2f22-eb83-f22e-50cb547b6ee8@huawei.com>
Hi,
On 2021/4/15 15:43, Keqian Zhu wrote:
>>> design it as not switchable. I will modify the commit message of patch#12, thanks!
>> I am not sure that I fully get your point. But I can't see any gaps of
>> using iommu_dev_enable/disable_feature() to switch dirty log on and off.
>> Probably I missed anything.
> IOMMU_DEV_FEAT_HWDBM just tells user whether underlying IOMMU driver supports
> dirty tracking, it is not used to management the status of dirty log tracking.
>
> The feature reporting is per device, but the status management is per iommu_domain.
> Only when all devices in a domain support HWDBM, we can start dirty log for the domain.
So why not
for_each_device_attached_domain()
iommu_dev_enable_feature(IOMMU_DEV_FEAT_HWDBM)
?
>
> And I think we'd better not mix the feature reporting and status management. Thoughts?
>
I am worrying about having two sets of APIs for single purpose. From
vendor iommu driver's point of view, this feature is per device. Hence,
it still needs to do the same thing.
Best regards,
baolu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Keqian Zhu <zhukeqian1@huawei.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Yi Sun <yi.y.sun@linux.intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Tian Kevin <kevin.tian@intel.com>
Cc: jiangkunkun@huawei.com, Cornelia Huck <cohuck@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
lushenming@huawei.com,
Alex Williamson <alex.williamson@redhat.com>,
wanghaibin.wang@huawei.com
Subject: Re: [PATCH v3 01/12] iommu: Introduce dirty log tracking framework
Date: Thu, 15 Apr 2021 18:21:22 +0800 [thread overview]
Message-ID: <2c01425f-813c-4278-ba06-26d651496a5c@linux.intel.com> (raw)
In-Reply-To: <88cba608-2f22-eb83-f22e-50cb547b6ee8@huawei.com>
Hi,
On 2021/4/15 15:43, Keqian Zhu wrote:
>>> design it as not switchable. I will modify the commit message of patch#12, thanks!
>> I am not sure that I fully get your point. But I can't see any gaps of
>> using iommu_dev_enable/disable_feature() to switch dirty log on and off.
>> Probably I missed anything.
> IOMMU_DEV_FEAT_HWDBM just tells user whether underlying IOMMU driver supports
> dirty tracking, it is not used to management the status of dirty log tracking.
>
> The feature reporting is per device, but the status management is per iommu_domain.
> Only when all devices in a domain support HWDBM, we can start dirty log for the domain.
So why not
for_each_device_attached_domain()
iommu_dev_enable_feature(IOMMU_DEV_FEAT_HWDBM)
?
>
> And I think we'd better not mix the feature reporting and status management. Thoughts?
>
I am worrying about having two sets of APIs for single purpose. From
vendor iommu driver's point of view, this feature is per device. Hence,
it still needs to do the same thing.
Best regards,
baolu
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: Lu Baolu <baolu.lu@linux.intel.com>
To: Keqian Zhu <zhukeqian1@huawei.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
iommu@lists.linux-foundation.org,
Robin Murphy <robin.murphy@arm.com>,
Will Deacon <will@kernel.org>, Joerg Roedel <joro@8bytes.org>,
Yi Sun <yi.y.sun@linux.intel.com>,
Jean-Philippe Brucker <jean-philippe@linaro.org>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Tian Kevin <kevin.tian@intel.com>
Cc: baolu.lu@linux.intel.com,
Alex Williamson <alex.williamson@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Kirti Wankhede <kwankhede@nvidia.com>,
wanghaibin.wang@huawei.com, jiangkunkun@huawei.com,
yuzenghui@huawei.com, lushenming@huawei.com
Subject: Re: [PATCH v3 01/12] iommu: Introduce dirty log tracking framework
Date: Thu, 15 Apr 2021 18:21:22 +0800 [thread overview]
Message-ID: <2c01425f-813c-4278-ba06-26d651496a5c@linux.intel.com> (raw)
In-Reply-To: <88cba608-2f22-eb83-f22e-50cb547b6ee8@huawei.com>
Hi,
On 2021/4/15 15:43, Keqian Zhu wrote:
>>> design it as not switchable. I will modify the commit message of patch#12, thanks!
>> I am not sure that I fully get your point. But I can't see any gaps of
>> using iommu_dev_enable/disable_feature() to switch dirty log on and off.
>> Probably I missed anything.
> IOMMU_DEV_FEAT_HWDBM just tells user whether underlying IOMMU driver supports
> dirty tracking, it is not used to management the status of dirty log tracking.
>
> The feature reporting is per device, but the status management is per iommu_domain.
> Only when all devices in a domain support HWDBM, we can start dirty log for the domain.
So why not
for_each_device_attached_domain()
iommu_dev_enable_feature(IOMMU_DEV_FEAT_HWDBM)
?
>
> And I think we'd better not mix the feature reporting and status management. Thoughts?
>
I am worrying about having two sets of APIs for single purpose. From
vendor iommu driver's point of view, this feature is per device. Hence,
it still needs to do the same thing.
Best regards,
baolu
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-15 10:21 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-13 8:54 [PATCH v3 00/12] iommu/smmuv3: Implement hardware dirty log tracking Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 01/12] iommu: Introduce dirty log tracking framework Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-14 7:00 ` Lu Baolu
2021-04-14 7:00 ` Lu Baolu
2021-04-14 7:00 ` Lu Baolu
2021-04-15 6:18 ` Keqian Zhu
2021-04-15 6:18 ` Keqian Zhu
2021-04-15 6:18 ` Keqian Zhu
2021-04-15 7:03 ` Lu Baolu
2021-04-15 7:03 ` Lu Baolu
2021-04-15 7:03 ` Lu Baolu
2021-04-15 7:43 ` Keqian Zhu
2021-04-15 7:43 ` Keqian Zhu
2021-04-15 7:43 ` Keqian Zhu
2021-04-15 10:21 ` Lu Baolu [this message]
2021-04-15 10:21 ` Lu Baolu
2021-04-15 10:21 ` Lu Baolu
2021-04-16 9:07 ` Keqian Zhu
2021-04-16 9:07 ` Keqian Zhu
2021-04-16 9:07 ` Keqian Zhu
2021-04-19 1:59 ` Lu Baolu
2021-04-19 1:59 ` Lu Baolu
2021-04-19 1:59 ` Lu Baolu
2021-04-13 8:54 ` [PATCH v3 02/12] iommu: Add iommu_split_block interface Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-14 7:14 ` Lu Baolu
2021-04-14 7:14 ` Lu Baolu
2021-04-14 7:14 ` Lu Baolu
2021-04-19 9:32 ` Keqian Zhu
2021-04-19 9:32 ` Keqian Zhu
2021-04-19 9:32 ` Keqian Zhu
2021-04-19 13:33 ` Lu Baolu
2021-04-19 13:33 ` Lu Baolu
2021-04-19 13:33 ` Lu Baolu
2021-04-20 1:25 ` Keqian Zhu
2021-04-20 1:25 ` Keqian Zhu
2021-04-20 1:25 ` Keqian Zhu
2021-04-20 2:09 ` Lu Baolu
2021-04-20 2:09 ` Lu Baolu
2021-04-20 2:09 ` Lu Baolu
2021-04-20 7:32 ` Keqian Zhu
2021-04-20 7:32 ` Keqian Zhu
2021-04-20 7:32 ` Keqian Zhu
2021-04-20 7:53 ` Lu Baolu
2021-04-20 7:53 ` Lu Baolu
2021-04-20 7:53 ` Lu Baolu
2021-04-13 8:54 ` [PATCH v3 03/12] iommu: Add iommu_merge_page interface Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 04/12] iommu/arm-smmu-v3: Add support for Hardware Translation Table Update Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 05/12] iommu/arm-smmu-v3: Enable HTTU for stage1 with io-pgtable mapping Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 06/12] iommu/arm-smmu-v3: Add feature detection for BBML Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 07/12] iommu/arm-smmu-v3: Realize split_block iommu ops Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 08/12] iommu/arm-smmu-v3: Realize merge_page " Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 09/12] iommu/arm-smmu-v3: Realize switch_dirty_log " Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 10/12] iommu/arm-smmu-v3: Realize sync_dirty_log " Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 11/12] iommu/arm-smmu-v3: Realize clear_dirty_log " Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` [PATCH v3 12/12] iommu/arm-smmu-v3: Add HWDBM device feature reporting Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
2021-04-13 8:54 ` Keqian Zhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c01425f-813c-4278-ba06-26d651496a5c@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jiangkunkun@huawei.com \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kwankhede@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lushenming@huawei.com \
--cc=robin.murphy@arm.com \
--cc=wanghaibin.wang@huawei.com \
--cc=will@kernel.org \
--cc=yi.y.sun@linux.intel.com \
--cc=yuzenghui@huawei.com \
--cc=zhukeqian1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.