From: Dan Murphy <dmurphy@ti.com> To: Mark Brown <broonie@kernel.org> Cc: <lgirdwood@gmail.com>, <tiwai@suse.com>, <robh+dt@kernel.org>, <devicetree@vger.kernel.org>, <alsa-devel@alsa-project.org>, <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 6/9] ASoC: tas2770: Convert bit mask to GENMASK in header Date: Mon, 21 Sep 2020 14:19:36 -0500 [thread overview] Message-ID: <2ca0647d-1ebf-1290-0f75-61bb97324165@ti.com> (raw) In-Reply-To: <bea218c8-c71d-2ce8-da92-14af73ac4da5@ti.com> Mark On 9/21/20 2:18 PM, Dan Murphy wrote: > Mark > > On 9/21/20 2:04 PM, Mark Brown wrote: >> On Fri, Sep 18, 2020 at 02:05:45PM -0500, Dan Murphy wrote: >>> Update the hardcoded masks with the GENMASK macro. Also update some of >>> the hardcoded bits with the BIT macro >> Cleanups like this should come after any fixes in the series, that way >> fixes can be sent as fixes if needed which isn't appropriate for random >> cleanups. > > OK I can re-order so the clean up comes at the end. During the clean > up I found patch 7-9. > Forgot to ask are you going to take 1-5? If so I can rebase on top of for-5.10 and re-submit. Dan > Dan >
WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com> To: Mark Brown <broonie@kernel.org> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, tiwai@suse.com, lgirdwood@gmail.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org Subject: Re: [PATCH 6/9] ASoC: tas2770: Convert bit mask to GENMASK in header Date: Mon, 21 Sep 2020 14:19:36 -0500 [thread overview] Message-ID: <2ca0647d-1ebf-1290-0f75-61bb97324165@ti.com> (raw) In-Reply-To: <bea218c8-c71d-2ce8-da92-14af73ac4da5@ti.com> Mark On 9/21/20 2:18 PM, Dan Murphy wrote: > Mark > > On 9/21/20 2:04 PM, Mark Brown wrote: >> On Fri, Sep 18, 2020 at 02:05:45PM -0500, Dan Murphy wrote: >>> Update the hardcoded masks with the GENMASK macro. Also update some of >>> the hardcoded bits with the BIT macro >> Cleanups like this should come after any fixes in the series, that way >> fixes can be sent as fixes if needed which isn't appropriate for random >> cleanups. > > OK I can re-order so the clean up comes at the end. During the clean > up I found patch 7-9. > Forgot to ask are you going to take 1-5? If so I can rebase on top of for-5.10 and re-submit. Dan > Dan >
next prev parent reply other threads:[~2020-09-21 19:19 UTC|newest] Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-09-18 19:05 [PATCH 1/9] ASoC: tas2770: Fix calling reset in probe Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-18 19:05 ` [PATCH 2/9] ASoC: tas2770: Add missing bias level power states Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-18 19:05 ` [PATCH 3/9] dt-bindings: tas2770: Fix I2C addresses for the TAS2770 Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-18 19:05 ` [PATCH 4/9] ASoC: tas2770: Fix required DT properties in the code Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-18 19:05 ` [PATCH 5/9] ASoC: tas2770: Fix unbalanced calls to pm_runtime Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-18 19:05 ` [PATCH 6/9] ASoC: tas2770: Convert bit mask to GENMASK in header Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-21 19:04 ` Mark Brown 2020-09-21 19:04 ` Mark Brown 2020-09-21 19:18 ` Dan Murphy 2020-09-21 19:18 ` Dan Murphy 2020-09-21 19:19 ` Dan Murphy [this message] 2020-09-21 19:19 ` Dan Murphy 2020-09-22 9:47 ` Mark Brown 2020-09-22 9:47 ` Mark Brown 2020-09-18 19:05 ` [PATCH 7/9] ASoC: tas2770: Fix error handling with update_bits Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-18 19:05 ` [PATCH 8/9] ASoC: tas2770: Fix the spacing and new lines Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-18 19:05 ` [PATCH 9/9] ASoC: tas2770: Refactor sample rate function Dan Murphy 2020-09-18 19:05 ` Dan Murphy 2020-09-22 0:05 ` [PATCH 1/9] ASoC: tas2770: Fix calling reset in probe Mark Brown 2020-09-22 0:05 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2ca0647d-1ebf-1290-0f75-61bb97324165@ti.com \ --to=dmurphy@ti.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.