All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@linaro.org>
To: linux-kernel@vger.kernel.org
Cc: rnayak@codeaurora.org, linux-arm-msm@vger.kernel.org,
	bjorn.andersson@linaro.org, edubezval@gmail.com,
	smohanad@codeaurora.org, vivek.gautam@codeaurora.org,
	andy.gross@linaro.org, dianders@chromium.org, mka@chromium.org,
	Zhang Rui <rui.zhang@intel.com>, Rob Herring <robh@kernel.org>,
	Kees Cook <keescook@chromium.org>,
	linux-pm@vger.kernel.org
Subject: [PATCH v7 6/7] thermal: tsens: Add generic support for TSENS v2 IP
Date: Thu, 12 Jul 2018 14:09:07 +0530	[thread overview]
Message-ID: <34de426540a878bf77a77dd2c42a16678d6545a7.1531384019.git.amit.kucheria@linaro.org> (raw)
In-Reply-To: <cover.1531384019.git.amit.kucheria@linaro.org>
In-Reply-To: <cover.1531384019.git.amit.kucheria@linaro.org>

SDM845 uses v2 of the TSENS IP block but the get_temp() function appears to
be identical across v2.x.y in code seen so far. We use the generic
get_temp() function defined as part of ops_generic_v2.

Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Tested-by: Matthias Kaehlcke <mka@chromium.org>
---
 drivers/thermal/qcom/tsens-v2.c | 5 +++++
 drivers/thermal/qcom/tsens.c    | 3 +++
 drivers/thermal/qcom/tsens.h    | 5 ++++-
 3 files changed, 12 insertions(+), 1 deletion(-)

diff --git a/drivers/thermal/qcom/tsens-v2.c b/drivers/thermal/qcom/tsens-v2.c
index 44d3736..f40150f 100644
--- a/drivers/thermal/qcom/tsens-v2.c
+++ b/drivers/thermal/qcom/tsens-v2.c
@@ -69,6 +69,11 @@ static const struct tsens_ops ops_generic_v2 = {
 	.get_temp	= get_temp_tsens_v2,
 };
 
+const struct tsens_data data_tsens_v2 = {
+	.ops            = &ops_generic_v2,
+};
+
+/* Kept around for backward compatibility with old msm8996.dtsi */
 const struct tsens_data data_8996 = {
 	.num_sensors	= 13,
 	.ops		= &ops_generic_v2,
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 3440166c..a2c9bfa 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -72,6 +72,9 @@ static const struct of_device_id tsens_table[] = {
 	}, {
 		.compatible = "qcom,msm8996-tsens",
 		.data = &data_8996,
+	}, {
+		.compatible = "qcom,tsens-v2",
+		.data = &data_tsens_v2,
 	},
 	{}
 };
diff --git a/drivers/thermal/qcom/tsens.h b/drivers/thermal/qcom/tsens.h
index d785b37..14331eb 100644
--- a/drivers/thermal/qcom/tsens.h
+++ b/drivers/thermal/qcom/tsens.h
@@ -88,6 +88,9 @@ void compute_intercept_slope(struct tsens_device *, u32 *, u32 *, u32);
 int init_common(struct tsens_device *);
 int get_temp_common(struct tsens_device *, int, int *);
 
-extern const struct tsens_data data_8916, data_8974, data_8960, data_8996;
+/* TSENS v1 targets */
+extern const struct tsens_data data_8916, data_8974, data_8960;
+/* TSENS v2 targets */
+extern const struct tsens_data data_8996, data_tsens_v2;
 
 #endif /* __QCOM_TSENS_H__ */
-- 
2.7.4

  parent reply	other threads:[~2018-07-12  8:39 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-12  8:39 [PATCH v7 0/7] thermal: tsens: Refactoring for TSENSv2 IP Amit Kucheria
2018-07-12  8:39 ` Amit Kucheria
2018-07-12  8:39 ` [PATCH v7 1/7] thermal: tsens: Get rid of unused fields in structure Amit Kucheria
2018-07-12  8:39 ` [PATCH v7 2/7] thermal: tsens: Add support to split up register address space into two Amit Kucheria
2018-07-12 17:12   ` Doug Anderson
2018-07-17 23:29   ` Matthias Kaehlcke
2018-07-18  3:42     ` Amit Kucheria
2018-07-12  8:39 ` [PATCH v7 3/7] arm64: dts: msm8996: thermal: Initialise via DT and add second controller Amit Kucheria
2018-07-12  8:39   ` Amit Kucheria
2018-07-12 17:14   ` Doug Anderson
2018-07-12 17:14     ` Doug Anderson
2018-07-17 23:42   ` Matthias Kaehlcke
2018-07-17 23:42     ` Matthias Kaehlcke
2018-07-17 23:42     ` Matthias Kaehlcke
2018-07-17 23:55     ` Doug Anderson
2018-07-17 23:55       ` Doug Anderson
2018-07-17 23:58       ` Matthias Kaehlcke
2018-07-17 23:58         ` Matthias Kaehlcke
2018-07-12  8:39 ` [PATCH v7 4/7] thermal: tsens: Rename tsens-8996 to tsens-v2 for reuse Amit Kucheria
2018-07-12 17:19   ` Doug Anderson
2018-07-17 23:54   ` Matthias Kaehlcke
2018-07-12  8:39 ` [PATCH v7 5/7] dt: thermal: tsens: Document the fallback DT property for v2 of TSENS IP Amit Kucheria
2018-07-12 17:15   ` Doug Anderson
2018-07-18  0:09   ` Matthias Kaehlcke
2018-07-18  6:42     ` Amit Kucheria
2018-07-18  6:42       ` Amit Kucheria
2018-07-12  8:39 ` Amit Kucheria [this message]
2018-07-12 17:16   ` [PATCH v7 6/7] thermal: tsens: Add generic support for TSENS v2 IP Doug Anderson
2018-07-12  8:39 ` [PATCH v7 7/7] arm64: dts: sdm845: Add tsens nodes Amit Kucheria
2018-07-12  8:39   ` Amit Kucheria
2018-07-12 17:18   ` Doug Anderson
2018-07-12 17:18     ` Doug Anderson
2018-07-18  0:15   ` Matthias Kaehlcke
2018-07-18  0:15     ` Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34de426540a878bf77a77dd2c42a16678d6545a7.1531384019.git.amit.kucheria@linaro.org \
    --to=amit.kucheria@linaro.org \
    --cc=andy.gross@linaro.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=dianders@chromium.org \
    --cc=edubezval@gmail.com \
    --cc=keescook@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=smohanad@codeaurora.org \
    --cc=vivek.gautam@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.