From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, tkjos@android.com,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
arve@android.com, joel@joelfernandes.org, maco@android.com,
sumit.semwal@linaro.org, christian@brauner.io
Subject: Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c
Date: Wed, 3 Jul 2019 14:14:21 +0530 [thread overview]
Message-ID: <380a7fb4-d299-a3ee-43ae-0822ec25ece6@gmail.com> (raw)
In-Reply-To: <20190703083745.GB8996@kroah.com>
On 03/07/19 2:07 PM, Greg KH wrote:
> On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote:
>> Remove file ion_carveout_heap.c as its functions and definitions are not
>> used anywhere.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>> drivers/staging/android/ion/Kconfig | 9 --
>> drivers/staging/android/ion/Makefile | 1 -
>> .../staging/android/ion/ion_carveout_heap.c | 133 ------------------
>
> I keep trying to do this, but others point out that the ion code is
> "going to be fixed up soon" and that people rely on this interface now.
> Well, "code outside of the kernel tree" relies on this, which is not ok,
> but the "soon" people keep insisting on it...
>
> Odds are I should just delete all of ION, as there hasn't been any
> forward progress on it in a long time.
I'm sorry, I don't think I understand. Should I drop these patches from
my tree then?
Thanking you,
Nishka
> Hopefully that wakes some people up...
>
> thanks,
>
> greg k-h
>
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
WARNING: multiple messages have this Message-ID (diff)
From: Nishka Dasgupta <nishkadg.linux@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: devel@driverdev.osuosl.org, tkjos@android.com,
dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org,
arve@android.com, joel@joelfernandes.org, maco@android.com,
sumit.semwal@linaro.org, christian@brauner.io
Subject: Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c
Date: Wed, 3 Jul 2019 14:14:21 +0530 [thread overview]
Message-ID: <380a7fb4-d299-a3ee-43ae-0822ec25ece6@gmail.com> (raw)
In-Reply-To: <20190703083745.GB8996@kroah.com>
On 03/07/19 2:07 PM, Greg KH wrote:
> On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote:
>> Remove file ion_carveout_heap.c as its functions and definitions are not
>> used anywhere.
>> Issue found with Coccinelle.
>>
>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
>> ---
>> drivers/staging/android/ion/Kconfig | 9 --
>> drivers/staging/android/ion/Makefile | 1 -
>> .../staging/android/ion/ion_carveout_heap.c | 133 ------------------
>
> I keep trying to do this, but others point out that the ion code is
> "going to be fixed up soon" and that people rely on this interface now.
> Well, "code outside of the kernel tree" relies on this, which is not ok,
> but the "soon" people keep insisting on it...
>
> Odds are I should just delete all of ION, as there hasn't been any
> forward progress on it in a long time.
I'm sorry, I don't think I understand. Should I drop these patches from
my tree then?
Thanking you,
Nishka
> Hopefully that wakes some people up...
>
> thanks,
>
> greg k-h
>
next prev parent reply other threads:[~2019-07-03 8:44 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-03 8:18 [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c Nishka Dasgupta
2019-07-03 8:18 ` Nishka Dasgupta
2019-07-03 8:18 ` [PATCH 2/2] staging: android: ion: Remove file ion_chunk_heap.c Nishka Dasgupta
2019-07-03 8:18 ` Nishka Dasgupta
2019-07-03 11:33 ` Laura Abbott
2019-07-03 11:33 ` Laura Abbott
2019-07-03 8:37 ` [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c Greg KH
2019-07-03 8:37 ` Greg KH
2019-07-03 8:44 ` Nishka Dasgupta [this message]
2019-07-03 8:44 ` Nishka Dasgupta
2019-07-03 9:10 ` Greg KH
2019-07-03 9:10 ` Greg KH
2019-07-03 9:50 ` Daniel Vetter
2019-07-03 9:50 ` Daniel Vetter
2019-07-03 11:32 ` Laura Abbott
2019-07-03 11:32 ` Laura Abbott
2019-07-03 16:24 ` Greg KH
2019-07-03 16:24 ` Greg KH
2019-07-03 19:36 ` John Stultz
2019-07-03 19:36 ` John Stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=380a7fb4-d299-a3ee-43ae-0822ec25ece6@gmail.com \
--to=nishkadg.linux@gmail.com \
--cc=arve@android.com \
--cc=christian@brauner.io \
--cc=devel@driverdev.osuosl.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=maco@android.com \
--cc=sumit.semwal@linaro.org \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.