Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c

From: John Stultz <john.stultz@linaro.org>
To: Laura Abbott <labbott@redhat.com>
Cc: driverdevel <devel@driverdev.osuosl.org>,
	"Todd Kjos" <tkjos@android.com>,
	"Nishka Dasgupta" <nishkadg.linux@gmail.com>,
	"Greg KH" <gregkh@linuxfoundation.org>,
	"John Reitan" <John.Reitan@arm.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	"moderated list:DMA BUFFER SHARING FRAMEWORK"
	<linaro-mm-sig@lists.linaro.org>,
	"Arve Hjønnevåg" <arve@android.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Joel Fernandes" <joel@joelfernandes.org>,
	"Martijn Coenen" <maco@android.com>,
	"Brian Starkey" <Brian.Starkey@arm.com>,
	christian@brauner.io
Subject: Re: [PATCH 1/2] staging: android: ion: Remove file ion_carveout_heap.c
Date: Wed, 3 Jul 2019 12:36:13 -0700	[thread overview]
Message-ID: <CALAqxLVvEjTbp9P=btOhTugFONWT9wS6Bjmync=WubYknvnE6A@mail.gmail.com> (raw)
In-Reply-To: <759555d8-98bf-44d3-4fa3-3d927f9a33db@redhat.com>

On Wed, Jul 3, 2019 at 4:32 AM Laura Abbott <labbott@redhat.com> wrote:
>
> On 7/3/19 5:50 AM, Daniel Vetter wrote:
> > On Wed, Jul 3, 2019 at 10:37 AM Greg KH <gregkh@linuxfoundation.org> wrote:
> >>
> >> On Wed, Jul 03, 2019 at 01:48:41PM +0530, Nishka Dasgupta wrote:
> >>> Remove file ion_carveout_heap.c as its functions and definitions are not
> >>> used anywhere.
> >>> Issue found with Coccinelle.
> >>>
> >>> Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
> >>> ---
> >>>   drivers/staging/android/ion/Kconfig           |   9 --
> >>>   drivers/staging/android/ion/Makefile          |   1 -
> >>>   .../staging/android/ion/ion_carveout_heap.c   | 133 ------------------
> >>
> >> I keep trying to do this, but others point out that the ion code is
> >> "going to be fixed up soon" and that people rely on this interface now.
> >> Well, "code outside of the kernel tree" relies on this, which is not ok,
> >> but the "soon" people keep insisting on it...
> >>
> >> Odds are I should just delete all of ION, as there hasn't been any
> >> forward progress on it in a long time.
> >>
> >> Hopefully that wakes some people up...
> >
> > John Stultz has done a steady stream on ion destaging patch series
> > past few months, und the heading of "DMA-BUF Heaps", targeting
> > drivers/dma-buf. I'm not following the details, and it seems a bit a
> > crawl, but there's definitely work going on ... Just probably not
> > in-place in staging I think.
> > -Daniel
> >
>
>
> https://lists.freedesktop.org/archives/dri-devel/2019-June/223705.html
>
> It is making slow and steady progress. Part of this is trying to
> make sure we actually get this right before moving anything
> out of staging.

Hopefully not too much longer. The review feedback has gotten quiet
recently so hopefully everyone is nodding.

Note, I'd also find it useful to *not* eject ION immediately after
dmabuf heaps land, since being able to do A/B validation on the same
kernel is useful if folks run into any new perf regressions. But
hopefully that transition time is fairly small.

> That said, I think we're at the point where nobody wants the
> carveout and chunk heaps so I'd actually be okay with removing
> those files. Just to be explicit:
>
> Acked-by: Laura Abbott <labbott@redhat.com>

Agreed. I think there are some out of tree uses by ARM and others for
the carveout heaps, but I don't know if anyone is using those
unmodified anyway.  So no objection from me, as there is no way to use
them upstream.

thanks
-john
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel