From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Punit Agrawal <punit.agrawal@arm.com>, kvmarm@lists.cs.columbia.edu
Cc: suzuki.poulose@arm.com, marc.zyngier@arm.com,
Catalin Marinas <catalin.marinas@arm.com>,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
punitagrawal@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 3/8] KVM: arm/arm64: Introduce helpers to manipulate page table entries
Date: Mon, 3 Dec 2018 19:20:08 +0530 [thread overview]
Message-ID: <396402d5-fddf-ab72-01c4-80dd1a0d4d44@arm.com> (raw)
In-Reply-To: <20181031175745.18650-4-punit.agrawal@arm.com>
On 10/31/2018 11:27 PM, Punit Agrawal wrote:
> Introduce helpers to abstract architectural handling of the conversion
> of pfn to page table entries and marking a PMD page table entry as a
> block entry.
Why is this necessary ? we would still need to access PMD, PUD as is
without any conversion. IOW KVM knows the breakdown of the page table
at various levels. Is this something required from generic KVM code ?
>
> The helpers are introduced in preparation for supporting PUD hugepages
> at stage 2 - which are supported on arm64 but do not exist on arm.
Some of these patches (including the earlier two) are good on it's
own. Do we have still mention in commit message about the incoming PUD
enablement as the reason for these cleanup patches ?
WARNING: multiple messages have this Message-ID (diff)
From: Anshuman Khandual <anshuman.khandual@arm.com>
To: Punit Agrawal <punit.agrawal@arm.com>, kvmarm@lists.cs.columbia.edu
Cc: suzuki.poulose@arm.com, marc.zyngier@arm.com,
Catalin Marinas <catalin.marinas@arm.com>,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>,
punitagrawal@gmail.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 3/8] KVM: arm/arm64: Introduce helpers to manipulate page table entries
Date: Mon, 3 Dec 2018 19:20:08 +0530 [thread overview]
Message-ID: <396402d5-fddf-ab72-01c4-80dd1a0d4d44@arm.com> (raw)
In-Reply-To: <20181031175745.18650-4-punit.agrawal@arm.com>
On 10/31/2018 11:27 PM, Punit Agrawal wrote:
> Introduce helpers to abstract architectural handling of the conversion
> of pfn to page table entries and marking a PMD page table entry as a
> block entry.
Why is this necessary ? we would still need to access PMD, PUD as is
without any conversion. IOW KVM knows the breakdown of the page table
at various levels. Is this something required from generic KVM code ?
>
> The helpers are introduced in preparation for supporting PUD hugepages
> at stage 2 - which are supported on arm64 but do not exist on arm.
Some of these patches (including the earlier two) are good on it's
own. Do we have still mention in commit message about the incoming PUD
enablement as the reason for these cleanup patches ?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-03 13:50 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-31 17:57 [PATCH v9 0/8] KVM: Support PUD hugepage at stage 2 Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-10-31 17:57 ` [PATCH v9 1/8] KVM: arm/arm64: Share common code in user_mem_abort() Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-12-03 12:11 ` Anshuman Khandual
2018-12-03 12:11 ` Anshuman Khandual
2018-12-03 13:37 ` Suzuki K Poulose
2018-12-03 13:37 ` Suzuki K Poulose
2018-12-03 13:37 ` Suzuki K Poulose
2018-12-10 8:56 ` Christoffer Dall
2018-12-10 8:56 ` Christoffer Dall
2018-12-10 10:26 ` Suzuki K Poulose
2018-12-10 10:26 ` Suzuki K Poulose
2018-12-10 10:47 ` Suzuki K Poulose
2018-12-10 10:47 ` Suzuki K Poulose
2018-12-10 11:01 ` Christoffer Dall
2018-12-10 11:01 ` Christoffer Dall
2018-10-31 17:57 ` [PATCH v9 2/8] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-12-03 13:32 ` Anshuman Khandual
2018-12-03 13:32 ` Anshuman Khandual
2018-12-05 10:47 ` Suzuki K Poulose
2018-12-05 10:47 ` Suzuki K Poulose
2018-12-10 9:00 ` Christoffer Dall
2018-12-10 9:00 ` Christoffer Dall
2018-12-10 8:59 ` Christoffer Dall
2018-12-10 8:59 ` Christoffer Dall
2018-10-31 17:57 ` [PATCH v9 3/8] KVM: arm/arm64: Introduce helpers to manipulate page table entries Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-12-03 13:50 ` Anshuman Khandual [this message]
2018-12-03 13:50 ` Anshuman Khandual
2018-12-03 14:03 ` Suzuki K Poulose
2018-12-03 14:03 ` Suzuki K Poulose
2018-12-10 9:01 ` Christoffer Dall
2018-12-10 9:01 ` Christoffer Dall
2018-10-31 17:57 ` [PATCH v9 4/8] KVM: arm64: Support dirty page tracking for PUD hugepages Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-12-03 14:17 ` Anshuman Khandual
2018-12-03 14:17 ` Anshuman Khandual
2018-12-03 14:21 ` Suzuki K Poulose
2018-12-03 14:21 ` Suzuki K Poulose
2018-10-31 17:57 ` [PATCH v9 5/8] KVM: arm64: Support PUD hugepage in stage2_is_exec() Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-11-01 13:38 ` Christoffer Dall
2018-11-01 13:38 ` Christoffer Dall
2018-12-05 17:57 ` Suzuki K Poulose
2018-12-05 17:57 ` Suzuki K Poulose
2018-12-10 9:06 ` Christoffer Dall
2018-12-10 9:06 ` Christoffer Dall
2018-12-03 14:37 ` Anshuman Khandual
2018-12-03 14:37 ` Anshuman Khandual
2018-10-31 17:57 ` [PATCH v9 6/8] KVM: arm64: Support handling access faults for PUD hugepages Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-11-01 13:40 ` Christoffer Dall
2018-11-01 13:40 ` Christoffer Dall
2018-11-01 13:40 ` Christoffer Dall
2018-12-03 15:10 ` Anshuman Khandual
2018-12-03 15:10 ` Anshuman Khandual
2018-10-31 17:57 ` [PATCH v9 7/8] KVM: arm64: Update age handlers to support " Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-12-03 15:19 ` Anshuman Khandual
2018-12-03 15:19 ` Anshuman Khandual
2018-10-31 17:57 ` [PATCH v9 8/8] KVM: arm64: Add support for creating PUD hugepages at stage 2 Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-10-31 17:57 ` Punit Agrawal
2018-12-03 15:46 ` Anshuman Khandual
2018-12-03 15:46 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=396402d5-fddf-ab72-01c4-80dd1a0d4d44@arm.com \
--to=anshuman.khandual@arm.com \
--cc=catalin.marinas@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=punit.agrawal@arm.com \
--cc=punitagrawal@gmail.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.