From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Anshuman Khandual <anshuman.khandual@arm.com>, Punit Agrawal <punit.agrawal@arm.com>, kvmarm@lists.cs.columbia.edu Cc: marc.zyngier@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Christoffer Dall <christoffer.dall@arm.com>, punitagrawal@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v9 2/8] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault Date: Wed, 5 Dec 2018 10:47:10 +0000 [thread overview] Message-ID: <f078ae84-9906-4394-957f-8f041b08827f@arm.com> (raw) In-Reply-To: <12212830-ffc6-a0e0-5de6-3e6a15ed7141@arm.com> On 03/12/2018 13:32, Anshuman Khandual wrote: > > > On 10/31/2018 11:27 PM, Punit Agrawal wrote: >> Stage 2 fault handler marks a page as executable if it is handling an >> execution fault or if it was a permission fault in which case the >> executable bit needs to be preserved. >> >> The logic to decide if the page should be marked executable is >> duplicated for PMD and PTE entries. To avoid creating another copy >> when support for PUD hugepages is introduced refactor the code to >> share the checks needed to mark a page table entry as executable. >> >> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com> >> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Cc: Christoffer Dall <christoffer.dall@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> --- >> virt/kvm/arm/mmu.c | 28 +++++++++++++++------------- >> 1 file changed, 15 insertions(+), 13 deletions(-) >> >> diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c >> index 59595207c5e1..6912529946fb 100644 >> --- a/virt/kvm/arm/mmu.c >> +++ b/virt/kvm/arm/mmu.c >> @@ -1475,7 +1475,8 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, >> unsigned long fault_status) >> { >> int ret; >> - bool write_fault, exec_fault, writable, force_pte = false; >> + bool write_fault, writable, force_pte = false; >> + bool exec_fault, needs_exec; > > New line not required, still within 80 characters. > >> unsigned long mmu_seq; >> gfn_t gfn = fault_ipa >> PAGE_SHIFT; >> struct kvm *kvm = vcpu->kvm; >> @@ -1598,19 +1599,25 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, >> if (exec_fault) >> invalidate_icache_guest_page(pfn, vma_pagesize); >> >> + /* >> + * If we took an execution fault we have made the >> + * icache/dcache coherent above and should now let the s2 > > Coherent or invalidated with invalidate_icache_guest_page ? We also do clean_dcache above if needed. So that makes sure the data is coherent. Am I missing something here ? > >> + * mapping be executable. >> + * >> + * Write faults (!exec_fault && FSC_PERM) are orthogonal to >> + * execute permissions, and we preserve whatever we have. >> + */ > > Otherwise looks good. > Suzuki
WARNING: multiple messages have this Message-ID (diff)
From: Suzuki K Poulose <suzuki.poulose@arm.com> To: Anshuman Khandual <anshuman.khandual@arm.com>, Punit Agrawal <punit.agrawal@arm.com>, kvmarm@lists.cs.columbia.edu Cc: marc.zyngier@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, Christoffer Dall <christoffer.dall@arm.com>, punitagrawal@gmail.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v9 2/8] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault Date: Wed, 5 Dec 2018 10:47:10 +0000 [thread overview] Message-ID: <f078ae84-9906-4394-957f-8f041b08827f@arm.com> (raw) In-Reply-To: <12212830-ffc6-a0e0-5de6-3e6a15ed7141@arm.com> On 03/12/2018 13:32, Anshuman Khandual wrote: > > > On 10/31/2018 11:27 PM, Punit Agrawal wrote: >> Stage 2 fault handler marks a page as executable if it is handling an >> execution fault or if it was a permission fault in which case the >> executable bit needs to be preserved. >> >> The logic to decide if the page should be marked executable is >> duplicated for PMD and PTE entries. To avoid creating another copy >> when support for PUD hugepages is introduced refactor the code to >> share the checks needed to mark a page table entry as executable. >> >> Signed-off-by: Punit Agrawal <punit.agrawal@arm.com> >> Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com> >> Cc: Christoffer Dall <christoffer.dall@arm.com> >> Cc: Marc Zyngier <marc.zyngier@arm.com> >> --- >> virt/kvm/arm/mmu.c | 28 +++++++++++++++------------- >> 1 file changed, 15 insertions(+), 13 deletions(-) >> >> diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c >> index 59595207c5e1..6912529946fb 100644 >> --- a/virt/kvm/arm/mmu.c >> +++ b/virt/kvm/arm/mmu.c >> @@ -1475,7 +1475,8 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, >> unsigned long fault_status) >> { >> int ret; >> - bool write_fault, exec_fault, writable, force_pte = false; >> + bool write_fault, writable, force_pte = false; >> + bool exec_fault, needs_exec; > > New line not required, still within 80 characters. > >> unsigned long mmu_seq; >> gfn_t gfn = fault_ipa >> PAGE_SHIFT; >> struct kvm *kvm = vcpu->kvm; >> @@ -1598,19 +1599,25 @@ static int user_mem_abort(struct kvm_vcpu *vcpu, phys_addr_t fault_ipa, >> if (exec_fault) >> invalidate_icache_guest_page(pfn, vma_pagesize); >> >> + /* >> + * If we took an execution fault we have made the >> + * icache/dcache coherent above and should now let the s2 > > Coherent or invalidated with invalidate_icache_guest_page ? We also do clean_dcache above if needed. So that makes sure the data is coherent. Am I missing something here ? > >> + * mapping be executable. >> + * >> + * Write faults (!exec_fault && FSC_PERM) are orthogonal to >> + * execute permissions, and we preserve whatever we have. >> + */ > > Otherwise looks good. > Suzuki _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2018-12-05 10:47 UTC|newest] Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-31 17:57 [PATCH v9 0/8] KVM: Support PUD hugepage at stage 2 Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-10-31 17:57 ` [PATCH v9 1/8] KVM: arm/arm64: Share common code in user_mem_abort() Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-12-03 12:11 ` Anshuman Khandual 2018-12-03 12:11 ` Anshuman Khandual 2018-12-03 13:37 ` Suzuki K Poulose 2018-12-03 13:37 ` Suzuki K Poulose 2018-12-03 13:37 ` Suzuki K Poulose 2018-12-10 8:56 ` Christoffer Dall 2018-12-10 8:56 ` Christoffer Dall 2018-12-10 10:26 ` Suzuki K Poulose 2018-12-10 10:26 ` Suzuki K Poulose 2018-12-10 10:47 ` Suzuki K Poulose 2018-12-10 10:47 ` Suzuki K Poulose 2018-12-10 11:01 ` Christoffer Dall 2018-12-10 11:01 ` Christoffer Dall 2018-10-31 17:57 ` [PATCH v9 2/8] KVM: arm/arm64: Re-factor setting the Stage 2 entry to exec on fault Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-12-03 13:32 ` Anshuman Khandual 2018-12-03 13:32 ` Anshuman Khandual 2018-12-05 10:47 ` Suzuki K Poulose [this message] 2018-12-05 10:47 ` Suzuki K Poulose 2018-12-10 9:00 ` Christoffer Dall 2018-12-10 9:00 ` Christoffer Dall 2018-12-10 8:59 ` Christoffer Dall 2018-12-10 8:59 ` Christoffer Dall 2018-10-31 17:57 ` [PATCH v9 3/8] KVM: arm/arm64: Introduce helpers to manipulate page table entries Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-12-03 13:50 ` Anshuman Khandual 2018-12-03 13:50 ` Anshuman Khandual 2018-12-03 14:03 ` Suzuki K Poulose 2018-12-03 14:03 ` Suzuki K Poulose 2018-12-10 9:01 ` Christoffer Dall 2018-12-10 9:01 ` Christoffer Dall 2018-10-31 17:57 ` [PATCH v9 4/8] KVM: arm64: Support dirty page tracking for PUD hugepages Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-12-03 14:17 ` Anshuman Khandual 2018-12-03 14:17 ` Anshuman Khandual 2018-12-03 14:21 ` Suzuki K Poulose 2018-12-03 14:21 ` Suzuki K Poulose 2018-10-31 17:57 ` [PATCH v9 5/8] KVM: arm64: Support PUD hugepage in stage2_is_exec() Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-11-01 13:38 ` Christoffer Dall 2018-11-01 13:38 ` Christoffer Dall 2018-12-05 17:57 ` Suzuki K Poulose 2018-12-05 17:57 ` Suzuki K Poulose 2018-12-10 9:06 ` Christoffer Dall 2018-12-10 9:06 ` Christoffer Dall 2018-12-03 14:37 ` Anshuman Khandual 2018-12-03 14:37 ` Anshuman Khandual 2018-10-31 17:57 ` [PATCH v9 6/8] KVM: arm64: Support handling access faults for PUD hugepages Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-11-01 13:40 ` Christoffer Dall 2018-11-01 13:40 ` Christoffer Dall 2018-11-01 13:40 ` Christoffer Dall 2018-12-03 15:10 ` Anshuman Khandual 2018-12-03 15:10 ` Anshuman Khandual 2018-10-31 17:57 ` [PATCH v9 7/8] KVM: arm64: Update age handlers to support " Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-12-03 15:19 ` Anshuman Khandual 2018-12-03 15:19 ` Anshuman Khandual 2018-10-31 17:57 ` [PATCH v9 8/8] KVM: arm64: Add support for creating PUD hugepages at stage 2 Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-10-31 17:57 ` Punit Agrawal 2018-12-03 15:46 ` Anshuman Khandual 2018-12-03 15:46 ` Anshuman Khandual
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f078ae84-9906-4394-957f-8f041b08827f@arm.com \ --to=suzuki.poulose@arm.com \ --cc=anshuman.khandual@arm.com \ --cc=christoffer.dall@arm.com \ --cc=kvmarm@lists.cs.columbia.edu \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=marc.zyngier@arm.com \ --cc=punit.agrawal@arm.com \ --cc=punitagrawal@gmail.com \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.