From: Pankaj Gupta <pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> To: Eric Blake <eblake-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Cc: kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, nilal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, jack-AlSwsSmVLrQ@public.gmane.org, xiaoguangrong eric <xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org, linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org, david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, ross zwisler <ross.zwisler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org, pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, stefanha-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, niteshnarayanlal-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org, imammedo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, lcapitulino-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org Subject: Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device Date: Wed, 25 Jul 2018 01:01:39 -0400 (EDT) [thread overview] Message-ID: <399916154.53931292.1532494899706.JavaMail.zimbra@redhat.com> (raw) In-Reply-To: <783786ae-2e85-2376-448c-1e362c3d4d48-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Hi Eric, > > On 07/13/2018 02:52 AM, Pankaj Gupta wrote: > > This patch adds virtio-pmem Qemu device. > > > > This device presents memory address range information to guest > > which is backed by file backend type. It acts like persistent > > memory device for KVM guest. Guest can perform read and persistent > > write operations on this memory range with the help of DAX capable > > filesystem. > > > > Persistent guest writes are assured with the help of virtio based > > flushing interface. When guest userspace space performs fsync on > > file fd on pmem device, a flush command is send to Qemu over VIRTIO > > and host side flush/sync is done on backing image file. > > > > Changes from RFC v2: > > This patch has no n/M in the subject line; but is included in a thread > that also has a 0/2 cover letter, as well as 1/2 and 2/2 patches in > separate mails. Is that intentional? Yes, kernel series has 0-2 patches and Qemu has this one. I thought its good to keep separate numbering for both the sets. > > When sending revision notes on a specific patch, it's best to place them... Sure. > > > - Use aio_worker() to avoid Qemu from hanging with blocking fsync > > call - Stefan > > - Use virtio_st*_p() for endianess - Stefan > > - Correct indentation in qapi/misc.json - Eric > > > > Signed-off-by: Pankaj Gupta <pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> > > --- > > ...here, after the --- separator. They are useful to reviewers on the > list, but are stripped by 'git am' as they don't need to be part of the > git history (a year from now, we won't care how many iterations the > patch went through during review, only what actually landed). > > > > +++ b/qapi/misc.json > > @@ -2907,6 +2907,29 @@ > > } > > } > > > > +## > > +# @VirtioPMemDeviceInfo: > > +# > > +# VirtioPMem state information > > +# > > +# @id: device's ID > > +# > > +# @start: physical address, where device is mapped > > +# > > +# @size: size of memory that the device provides > > +# > > +# @memdev: memory backend linked with device > > +# > > +# Since: 2.13 > > There is no 2.13 release, and you've missed the 3.0 window. Please > update this and any other version reference to 3.1. okay. Thanks, Pankaj
WARNING: multiple messages have this Message-ID (diff)
From: Pankaj Gupta <pagupta@redhat.com> To: Eric Blake <eblake@redhat.com> Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, qemu-devel@nongnu.org, linux-nvdimm@ml01.01.org, kwolf@redhat.com, haozhong zhang <haozhong.zhang@intel.com>, jack@suse.cz, xiaoguangrong eric <xiaoguangrong.eric@gmail.com>, riel@surriel.com, niteshnarayanlal@hotmail.com, david@redhat.com, ross zwisler <ross.zwisler@intel.com>, lcapitulino@redhat.com, hch@infradead.org, mst@redhat.com, stefanha@redhat.com, imammedo@redhat.com, pbonzini@redhat.com, dan j williams <dan.j.williams@intel.com>, nilal@redhat.com Subject: Re: [Qemu-devel] [RFC v3] qemu: Add virtio pmem device Date: Wed, 25 Jul 2018 01:01:39 -0400 (EDT) [thread overview] Message-ID: <399916154.53931292.1532494899706.JavaMail.zimbra@redhat.com> (raw) In-Reply-To: <783786ae-2e85-2376-448c-1e362c3d4d48@redhat.com> Hi Eric, > > On 07/13/2018 02:52 AM, Pankaj Gupta wrote: > > This patch adds virtio-pmem Qemu device. > > > > This device presents memory address range information to guest > > which is backed by file backend type. It acts like persistent > > memory device for KVM guest. Guest can perform read and persistent > > write operations on this memory range with the help of DAX capable > > filesystem. > > > > Persistent guest writes are assured with the help of virtio based > > flushing interface. When guest userspace space performs fsync on > > file fd on pmem device, a flush command is send to Qemu over VIRTIO > > and host side flush/sync is done on backing image file. > > > > Changes from RFC v2: > > This patch has no n/M in the subject line; but is included in a thread > that also has a 0/2 cover letter, as well as 1/2 and 2/2 patches in > separate mails. Is that intentional? Yes, kernel series has 0-2 patches and Qemu has this one. I thought its good to keep separate numbering for both the sets. > > When sending revision notes on a specific patch, it's best to place them... Sure. > > > - Use aio_worker() to avoid Qemu from hanging with blocking fsync > > call - Stefan > > - Use virtio_st*_p() for endianess - Stefan > > - Correct indentation in qapi/misc.json - Eric > > > > Signed-off-by: Pankaj Gupta <pagupta@redhat.com> > > --- > > ...here, after the --- separator. They are useful to reviewers on the > list, but are stripped by 'git am' as they don't need to be part of the > git history (a year from now, we won't care how many iterations the > patch went through during review, only what actually landed). > > > > +++ b/qapi/misc.json > > @@ -2907,6 +2907,29 @@ > > } > > } > > > > +## > > +# @VirtioPMemDeviceInfo: > > +# > > +# VirtioPMem state information > > +# > > +# @id: device's ID > > +# > > +# @start: physical address, where device is mapped > > +# > > +# @size: size of memory that the device provides > > +# > > +# @memdev: memory backend linked with device > > +# > > +# Since: 2.13 > > There is no 2.13 release, and you've missed the 3.0 window. Please > update this and any other version reference to 3.1. okay. Thanks, Pankaj
next prev parent reply other threads:[~2018-07-25 5:01 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-13 7:52 [RFC v3 0/2] kvm "fake DAX" device flushing Pankaj Gupta 2018-07-13 7:52 ` [Qemu-devel] " Pankaj Gupta 2018-07-13 7:52 ` Pankaj Gupta 2018-07-13 7:52 ` [RFC v3 1/2] libnvdimm: Add flush callback for virtio pmem Pankaj Gupta 2018-07-13 7:52 ` [Qemu-devel] " Pankaj Gupta 2018-07-13 20:35 ` Luiz Capitulino 2018-07-13 20:35 ` [Qemu-devel] " Luiz Capitulino 2018-07-16 8:13 ` Pankaj Gupta 2018-07-16 8:13 ` [Qemu-devel] " Pankaj Gupta [not found] ` <20180713075232.9575-1-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-13 7:52 ` [RFC v3 2/2] virtio-pmem: Add virtio pmem driver Pankaj Gupta 2018-07-13 7:52 ` [Qemu-devel] " Pankaj Gupta 2018-07-13 7:52 ` Pankaj Gupta [not found] ` <20180713075232.9575-3-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-13 20:38 ` Luiz Capitulino 2018-07-13 20:38 ` [Qemu-devel] " Luiz Capitulino 2018-07-13 20:38 ` Luiz Capitulino 2018-07-16 11:46 ` [Qemu-devel] " Pankaj Gupta 2018-07-16 11:46 ` Pankaj Gupta [not found] ` <633297685.51039804.1531741590092.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-16 14:03 ` Luiz Capitulino 2018-07-16 14:03 ` Luiz Capitulino 2018-07-16 15:11 ` Pankaj Gupta 2018-07-16 15:11 ` Pankaj Gupta 2018-07-17 13:11 ` Stefan Hajnoczi 2018-07-17 13:11 ` [Qemu-devel] " Stefan Hajnoczi [not found] ` <20180717131156.GA13498-lxVrvc10SDRcolVlb+j0YCZi+YwRKgec@public.gmane.org> 2018-07-18 7:05 ` Pankaj Gupta 2018-07-18 7:05 ` [Qemu-devel] " Pankaj Gupta 2018-07-18 7:05 ` Pankaj Gupta 2018-08-28 12:13 ` [RFC v3 0/2] kvm "fake DAX" device flushing David Hildenbrand 2018-08-28 12:13 ` [Qemu-devel] " David Hildenbrand 2018-08-28 12:13 ` David Hildenbrand [not found] ` <1328e543-0276-8f33-1744-8baa053023c4-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-08-28 12:39 ` [Qemu-devel] " Pankaj Gupta 2018-08-28 12:39 ` Pankaj Gupta 2018-07-13 7:52 ` [RFC v3] qemu: Add virtio pmem device Pankaj Gupta 2018-07-13 7:52 ` [Qemu-devel] " Pankaj Gupta [not found] ` <20180713075232.9575-4-pagupta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-18 12:55 ` Luiz Capitulino 2018-07-18 12:55 ` [Qemu-devel] " Luiz Capitulino 2018-07-18 12:55 ` Luiz Capitulino 2018-07-19 5:48 ` [Qemu-devel] " Pankaj Gupta 2018-07-19 12:16 ` Stefan Hajnoczi [not found] ` <20180719121635.GA28107-lxVrvc10SDRcolVlb+j0YCZi+YwRKgec@public.gmane.org> 2018-07-19 12:48 ` Luiz Capitulino 2018-07-19 12:48 ` Luiz Capitulino 2018-07-19 12:57 ` Luiz Capitulino 2018-07-20 13:04 ` Pankaj Gupta 2018-07-20 13:04 ` Pankaj Gupta 2018-07-19 13:58 ` David Hildenbrand 2018-07-19 13:58 ` David Hildenbrand [not found] ` <b6ef19f3-7f16-5427-bfed-f352a76e48b7-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-19 15:48 ` Luiz Capitulino 2018-07-19 15:48 ` Luiz Capitulino 2018-07-20 13:02 ` Pankaj Gupta 2018-07-20 13:02 ` Pankaj Gupta [not found] ` <367397176.52317488.1531979293251.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-19 12:39 ` Luiz Capitulino 2018-07-19 12:39 ` Luiz Capitulino 2018-07-24 16:13 ` Eric Blake 2018-07-24 16:13 ` [Qemu-devel] " Eric Blake 2018-07-24 16:13 ` Eric Blake [not found] ` <783786ae-2e85-2376-448c-1e362c3d4d48-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-25 5:01 ` Pankaj Gupta [this message] 2018-07-25 5:01 ` [Qemu-devel] " Pankaj Gupta [not found] ` <399916154.53931292.1532494899706.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-25 12:19 ` Eric Blake 2018-07-25 12:19 ` Eric Blake [not found] ` <d3fe397a-024d-faf7-8854-bb8e9ea17f53-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2018-07-25 12:47 ` Pankaj Gupta 2018-07-25 12:47 ` Pankaj Gupta
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=399916154.53931292.1532494899706.JavaMail.zimbra@redhat.com \ --to=pagupta-h+wxahxf7alqt0dzr+alfa@public.gmane.org \ --cc=david-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=eblake-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=hch-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \ --cc=imammedo-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=jack-AlSwsSmVLrQ@public.gmane.org \ --cc=kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=kwolf-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=lcapitulino-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org \ --cc=mst-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=nilal-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=niteshnarayanlal-PkbjNfxxIARBDgjK7y7TUQ@public.gmane.org \ --cc=pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \ --cc=riel-ebMLmSuQjDVBDgjK7y7TUQ@public.gmane.org \ --cc=ross.zwisler-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \ --cc=stefanha-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \ --cc=xiaoguangrong.eric-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.