From: Anthony PERARD via <qemu-devel@nongnu.org>
To: Bernhard Beschow <shentey@gmail.com>
Cc: qemu-devel@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Woodhouse" <dwmw@amazon.co.uk>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Paul Durrant" <paul@xen.org>,
xen-devel@lists.xenproject.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Chuck Zmudzinski" <brchuckz@aol.com>
Subject: Re: [PATCH v3 4/6] hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config()
Date: Thu, 30 Mar 2023 14:04:23 +0100 [thread overview]
Message-ID: <3bd7846b-2782-4857-b298-817fd683044e@perard> (raw)
In-Reply-To: <20230312120221.99183-5-shentey@gmail.com>
On Sun, Mar 12, 2023 at 01:02:19PM +0100, Bernhard Beschow wrote:
> Subscribe to pci_bus_fire_intx_routing_notifier() instead which allows for
> having a common piix3_write_config() for the PIIX3 device models.
>
> While at it, move the subscription into machine code to facilitate resolving
> TYPE_PIIX3_XEN_DEVICE.
>
> In a possible future followup, pci_bus_fire_intx_routing_notifier() could
> be adjusted in such a way that subscribing to it doesn't require
> knowledge of the device firing it.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
WARNING: multiple messages have this Message-ID (diff)
From: Anthony PERARD <anthony.perard@citrix.com>
To: Bernhard Beschow <shentey@gmail.com>
Cc: qemu-devel@nongnu.org,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"David Woodhouse" <dwmw@amazon.co.uk>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Paul Durrant" <paul@xen.org>,
xen-devel@lists.xenproject.org,
"Michael S. Tsirkin" <mst@redhat.com>,
"Stefano Stabellini" <sstabellini@kernel.org>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Chuck Zmudzinski" <brchuckz@aol.com>
Subject: Re: [PATCH v3 4/6] hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config()
Date: Thu, 30 Mar 2023 14:04:23 +0100 [thread overview]
Message-ID: <3bd7846b-2782-4857-b298-817fd683044e@perard> (raw)
In-Reply-To: <20230312120221.99183-5-shentey@gmail.com>
On Sun, Mar 12, 2023 at 01:02:19PM +0100, Bernhard Beschow wrote:
> Subscribe to pci_bus_fire_intx_routing_notifier() instead which allows for
> having a common piix3_write_config() for the PIIX3 device models.
>
> While at it, move the subscription into machine code to facilitate resolving
> TYPE_PIIX3_XEN_DEVICE.
>
> In a possible future followup, pci_bus_fire_intx_routing_notifier() could
> be adjusted in such a way that subscribing to it doesn't require
> knowledge of the device firing it.
>
> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Thanks,
--
Anthony PERARD
next prev parent reply other threads:[~2023-03-30 13:05 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-12 12:02 [PATCH v3 0/6] Resolve TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-03-12 12:02 ` [PATCH v3 1/6] include/hw/xen/xen: Rename xen_piix3_set_irq() to xen_intx_set_irq() Bernhard Beschow
2023-03-30 12:54 ` Anthony PERARD via
2023-03-30 12:54 ` Anthony PERARD
2023-03-12 12:02 ` [PATCH v3 2/6] hw/isa/piix3: Reuse piix3_realize() in piix3_xen_realize() Bernhard Beschow
2023-03-30 13:00 ` Anthony PERARD
2023-03-30 13:00 ` Anthony PERARD via
2023-04-01 22:36 ` Bernhard Beschow
2023-04-03 8:08 ` Bernhard Beschow
2023-04-03 9:32 ` Anthony PERARD
2023-04-03 9:32 ` Anthony PERARD via
2023-04-03 12:27 ` Jason Andryuk
2023-04-03 20:36 ` Bernhard Beschow
2023-09-19 20:02 ` Bernhard Beschow
2023-09-20 14:44 ` Chuck Zmudzinski
2023-09-24 15:41 ` Bernhard Beschow
2023-03-12 12:02 ` [PATCH v3 3/6] hw/isa/piix3: Wire up Xen PCI IRQ handling outside of PIIX3 Bernhard Beschow
2023-03-30 13:03 ` Anthony PERARD via
2023-03-30 13:03 ` Anthony PERARD
2023-03-12 12:02 ` [PATCH v3 4/6] hw/isa/piix3: Avoid Xen-specific variant of piix3_write_config() Bernhard Beschow
2023-03-30 13:04 ` Anthony PERARD via [this message]
2023-03-30 13:04 ` Anthony PERARD
2023-03-12 12:02 ` [PATCH v3 5/6] hw/isa/piix3: Resolve redundant k->config_write assignments Bernhard Beschow
2023-03-30 13:05 ` Anthony PERARD via
2023-03-30 13:05 ` Anthony PERARD
2023-03-12 12:02 ` [PATCH v3 6/6] hw/isa/piix3: Resolve redundant TYPE_PIIX3_XEN_DEVICE Bernhard Beschow
2023-03-30 13:05 ` Anthony PERARD
2023-03-30 13:05 ` Anthony PERARD via
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bd7846b-2782-4857-b298-817fd683044e@perard \
--to=qemu-devel@nongnu.org \
--cc=anthony.perard@citrix.com \
--cc=aurelien@aurel32.net \
--cc=brchuckz@aol.com \
--cc=dwmw@amazon.co.uk \
--cc=eduardo@habkost.net \
--cc=hpoussin@reactos.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.