From: James Morse <james.morse@arm.com>
To: Julien Grall <julien.grall@arm.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, marc.zyngier@arm.com,
julien.thierry@arm.com, suzuki.poulose@arm.com,
catalin.marinas@arm.com, will.deacon@arm.com
Subject: Re: [RFC v2 11/14] arm64: Move the ASID allocator code in a separate file
Date: Thu, 4 Jul 2019 15:56:52 +0100 [thread overview]
Message-ID: <3e6c6636-8522-ab4a-0183-ae0198a7a047@arm.com> (raw)
In-Reply-To: <20190620130608.17230-12-julien.grall@arm.com>
Hi Julien,
On 20/06/2019 14:06, Julien Grall wrote:
> We will want to re-use the ASID allocator in a separate context (e.g
> allocating VMID). So move the code in a new file.
>
> The function asid_check_context has been moved in the header as a static
> inline function because we want to avoid add a branch when checking if the
> ASID is still valid.
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index 3df63a28856c..b745cf356fe1 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -23,46 +23,21 @@
> -#define ASID_FIRST_VERSION(info) NUM_ASIDS(info)
> diff --git a/arch/arm64/lib/asid.c b/arch/arm64/lib/asid.c
> new file mode 100644
> index 000000000000..7252e4fdd5e9
> --- /dev/null
> +++ b/arch/arm64/lib/asid.c
> @@ -0,0 +1,185 @@
> +#define ASID_FIRST_VERSION(info) (1UL << ((info)->bits))
(oops!)
> @@ -344,7 +115,7 @@ static int asids_init(void)
> if (!asid_allocator_init(&asid_info, bits, ASID_PER_CONTEXT,
> asid_flush_cpu_ctxt))
> panic("Unable to initialize ASID allocator for %lu ASIDs\n",
> - 1UL << bits);
> + NUM_ASIDS(&asid_info));
Could this go in the patch that adds NUM_ASIDS()?
Thanks,
James
WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com>
To: Julien Grall <julien.grall@arm.com>
Cc: marc.zyngier@arm.com, catalin.marinas@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC v2 11/14] arm64: Move the ASID allocator code in a separate file
Date: Thu, 4 Jul 2019 15:56:52 +0100 [thread overview]
Message-ID: <3e6c6636-8522-ab4a-0183-ae0198a7a047@arm.com> (raw)
In-Reply-To: <20190620130608.17230-12-julien.grall@arm.com>
Hi Julien,
On 20/06/2019 14:06, Julien Grall wrote:
> We will want to re-use the ASID allocator in a separate context (e.g
> allocating VMID). So move the code in a new file.
>
> The function asid_check_context has been moved in the header as a static
> inline function because we want to avoid add a branch when checking if the
> ASID is still valid.
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index 3df63a28856c..b745cf356fe1 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -23,46 +23,21 @@
> -#define ASID_FIRST_VERSION(info) NUM_ASIDS(info)
> diff --git a/arch/arm64/lib/asid.c b/arch/arm64/lib/asid.c
> new file mode 100644
> index 000000000000..7252e4fdd5e9
> --- /dev/null
> +++ b/arch/arm64/lib/asid.c
> @@ -0,0 +1,185 @@
> +#define ASID_FIRST_VERSION(info) (1UL << ((info)->bits))
(oops!)
> @@ -344,7 +115,7 @@ static int asids_init(void)
> if (!asid_allocator_init(&asid_info, bits, ASID_PER_CONTEXT,
> asid_flush_cpu_ctxt))
> panic("Unable to initialize ASID allocator for %lu ASIDs\n",
> - 1UL << bits);
> + NUM_ASIDS(&asid_info));
Could this go in the patch that adds NUM_ASIDS()?
Thanks,
James
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: James Morse <james.morse@arm.com>
To: Julien Grall <julien.grall@arm.com>
Cc: julien.thierry@arm.com, marc.zyngier@arm.com,
catalin.marinas@arm.com, suzuki.poulose@arm.com,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
kvmarm@lists.cs.columbia.edu,
linux-arm-kernel@lists.infradead.org
Subject: Re: [RFC v2 11/14] arm64: Move the ASID allocator code in a separate file
Date: Thu, 4 Jul 2019 15:56:52 +0100 [thread overview]
Message-ID: <3e6c6636-8522-ab4a-0183-ae0198a7a047@arm.com> (raw)
In-Reply-To: <20190620130608.17230-12-julien.grall@arm.com>
Hi Julien,
On 20/06/2019 14:06, Julien Grall wrote:
> We will want to re-use the ASID allocator in a separate context (e.g
> allocating VMID). So move the code in a new file.
>
> The function asid_check_context has been moved in the header as a static
> inline function because we want to avoid add a branch when checking if the
> ASID is still valid.
> diff --git a/arch/arm64/mm/context.c b/arch/arm64/mm/context.c
> index 3df63a28856c..b745cf356fe1 100644
> --- a/arch/arm64/mm/context.c
> +++ b/arch/arm64/mm/context.c
> @@ -23,46 +23,21 @@
> -#define ASID_FIRST_VERSION(info) NUM_ASIDS(info)
> diff --git a/arch/arm64/lib/asid.c b/arch/arm64/lib/asid.c
> new file mode 100644
> index 000000000000..7252e4fdd5e9
> --- /dev/null
> +++ b/arch/arm64/lib/asid.c
> @@ -0,0 +1,185 @@
> +#define ASID_FIRST_VERSION(info) (1UL << ((info)->bits))
(oops!)
> @@ -344,7 +115,7 @@ static int asids_init(void)
> if (!asid_allocator_init(&asid_info, bits, ASID_PER_CONTEXT,
> asid_flush_cpu_ctxt))
> panic("Unable to initialize ASID allocator for %lu ASIDs\n",
> - 1UL << bits);
> + NUM_ASIDS(&asid_info));
Could this go in the patch that adds NUM_ASIDS()?
Thanks,
James
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-04 14:57 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-20 13:05 [RFC v2 00/14] kvm/arm: Align the VMID allocation with the arm64 ASID one Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` [RFC v2 01/14] arm64/mm: Introduce asid_info structure and move asid_generation/asid_map to it Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` [RFC v2 02/14] arm64/mm: Move active_asids and reserved_asids to asid_info Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` [RFC v2 03/14] arm64/mm: Move bits " Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` [RFC v2 04/14] arm64/mm: Move the variable lock and tlb_flush_pending " Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` [RFC v2 05/14] arm64/mm: Remove dependency on MM in new_context Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:05 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 06/14] arm64/mm: Store the number of asid allocated per context Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 07/14] arm64/mm: Introduce NUM_ASIDS Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 08/14] arm64/mm: Split asid_inits in 2 parts Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 09/14] arm64/mm: Split the function check_and_switch_context in 3 parts Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 10/14] arm64/mm: Introduce a callback to flush the local context Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 11/14] arm64: Move the ASID allocator code in a separate file Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-07-04 14:56 ` James Morse [this message]
2019-07-04 14:56 ` James Morse
2019-07-04 14:56 ` James Morse
2019-07-15 10:58 ` Julien Grall
2019-07-15 10:58 ` Julien Grall
2019-07-15 10:58 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 12/14] arm64/lib: asid: Allow user to update the context under the lock Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-07-03 17:35 ` James Morse
2019-07-03 17:35 ` James Morse
2019-07-03 17:35 ` James Morse
2019-07-15 14:38 ` Julien Grall
2019-07-15 14:38 ` Julien Grall
2019-07-15 14:38 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 13/14] arm/kvm: Introduce a new VMID allocator Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` [RFC v2 14/14] kvm/arm: Align the VMID allocation with the arm64 ASID one Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-06-20 13:06 ` Julien Grall
2019-07-03 17:36 ` James Morse
2019-07-03 17:36 ` James Morse
2019-07-03 17:36 ` James Morse
2019-07-15 17:06 ` Julien Grall
2019-07-15 17:06 ` Julien Grall
2019-07-15 17:06 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e6c6636-8522-ab4a-0183-ae0198a7a047@arm.com \
--to=james.morse@arm.com \
--cc=catalin.marinas@arm.com \
--cc=julien.grall@arm.com \
--cc=julien.thierry@arm.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=suzuki.poulose@arm.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.