All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Sandipan Das <sandipan@linux.ibm.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
	linux-arch@vger.kernel.org, fweimer@redhat.com, x86@kernel.org,
	linuxram@us.ibm.com, mhocko@kernel.org, linux-mm@kvack.org,
	mingo@redhat.com, aneesh.kumar@linux.ibm.com,
	bauerman@linux.ibm.com, msuchanek@suse.de, mpe@ellerman.id.au,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys
Date: Mon, 27 Jan 2020 07:42:33 -0800	[thread overview]
Message-ID: <3eca7a91-aa3e-cb01-47c8-5d36020993a2@intel.com> (raw)
In-Reply-To: <8f14bee0-ab1c-fc90-dfdb-5128607b767f@linux.ibm.com>

On 1/27/20 2:11 AM, Sandipan Das wrote:
> Hi Dave,
> 
> On 23/01/20 12:15 am, Dave Hansen wrote:
>> Still doesn't build for me:
>>
> I have this patch that hopefully fixes this. My understanding was
> that the vm tests are supposed to be generic but this has quite a
> bit of x86-specific conditional code which complicates things even
> though it is not used by any of the other tests.
> 
> I'm not sure if we should keep x86 multilib build support for these
> selftests but I'll let the maintainers take a call.

How have you tested this patch (and the whole series for that matter)?

WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Sandipan Das <sandipan@linux.ibm.com>
Cc: linux-arch@vger.kernel.org, fweimer@redhat.com,
	aneesh.kumar@linux.ibm.com, x86@kernel.org, linuxram@us.ibm.com,
	linuxppc-dev@lists.ozlabs.org, mhocko@kernel.org,
	linux-mm@kvack.org, mingo@redhat.com,
	linux-kselftest@vger.kernel.org, msuchanek@suse.de,
	shuah@kernel.org, bauerman@linux.ibm.com
Subject: Re: [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys
Date: Mon, 27 Jan 2020 07:42:33 -0800	[thread overview]
Message-ID: <3eca7a91-aa3e-cb01-47c8-5d36020993a2@intel.com> (raw)
In-Reply-To: <8f14bee0-ab1c-fc90-dfdb-5128607b767f@linux.ibm.com>

On 1/27/20 2:11 AM, Sandipan Das wrote:
> Hi Dave,
> 
> On 23/01/20 12:15 am, Dave Hansen wrote:
>> Still doesn't build for me:
>>
> I have this patch that hopefully fixes this. My understanding was
> that the vm tests are supposed to be generic but this has quite a
> bit of x86-specific conditional code which complicates things even
> though it is not used by any of the other tests.
> 
> I'm not sure if we should keep x86 multilib build support for these
> selftests but I'll let the maintainers take a call.

How have you tested this patch (and the whole series for that matter)?

  reply	other threads:[~2020-01-27 15:53 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20  8:35 [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys Sandipan Das
2020-01-20  8:35 ` [PATCH v17 " Sandipan Das
2020-01-20  8:35 ` Sandipan Das
2020-01-20  8:35 ` [PATCH v16 " Sandipan Das
2020-01-20  8:35 ` [PATCH v17 01/24] selftests/x86/pkeys: Move selftests to arch-neutral directory Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:35 ` [PATCH v17 02/24] selftests: vm: pkeys: Fix multilib builds for x86 Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:35   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 03/24] selftests/vm/pkeys: Rename all references to pkru to a generic name Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 04/24] selftests/vm/pkeys: Move generic definitions to header file Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 05/24] selftests/vm/pkeys: Move some definitions to arch-specific header Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 06/24] selftests/vm/pkeys: Make gcc check arguments of sigsafe_printf() Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 07/24] selftests: vm: pkeys: Use sane types for pkey register Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 08/24] selftests: vm: pkeys: Add helpers for pkey bits Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 09/24] selftests/vm/pkeys: Fix pkey_disable_clear() Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 10/24] selftests/vm/pkeys: Fix assertion in pkey_disable_set/clear() Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 11/24] selftests/vm/pkeys: Fix alloc_random_pkey() to make it really random Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 12/24] selftests: vm: pkeys: Use the correct huge page size Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 13/24] selftests/vm/pkeys: Introduce generic pkey abstractions Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 14/24] selftests/vm/pkeys: Introduce powerpc support Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 15/24] selftests/vm/pkeys: Fix number of reserved powerpc pkeys Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 16/24] selftests/vm/pkeys: Fix assertion in test_pkey_alloc_exhaust() Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 17/24] selftests/vm/pkeys: Improve checks to determine pkey support Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 18/24] selftests/vm/pkeys: Associate key on a mapped page and detect access violation Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 19/24] selftests/vm/pkeys: Associate key on a mapped page and detect write violation Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 20/24] selftests/vm/pkeys: Detect write violation on a mapped access-denied-key page Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 21/24] selftests/vm/pkeys: Introduce a sub-page allocator Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 22/24] selftests/vm/pkeys: Test correct behaviour of pkey-0 Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 23/24] selftests/vm/pkeys: Override access right definitions on powerpc Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36 ` [PATCH v17 24/24] selftests: vm: pkeys: Use the correct page size " Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-20  8:36   ` Sandipan Das
2020-01-22 18:45 ` [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys Dave Hansen
2020-01-22 18:45   ` Dave Hansen
2020-01-27 10:11   ` Sandipan Das
2020-01-27 10:11     ` Sandipan Das
2020-01-27 10:11     ` Sandipan Das
2020-01-27 15:42     ` Dave Hansen [this message]
2020-01-27 15:42       ` Dave Hansen
2020-01-28  9:38       ` Sandipan Das
2020-01-28  9:38         ` Sandipan Das
2020-01-29  9:56         ` Sandipan Das
2020-01-29  9:56           ` Sandipan Das
2020-01-29 18:59         ` Dave Hansen
2020-01-29 18:59           ` Dave Hansen
2020-01-30  6:19           ` Sandipan Das
2020-01-30  6:19             ` Sandipan Das
2020-01-30  9:20             ` Sandipan Das
2020-01-30  9:20               ` Sandipan Das
2020-01-29 19:04   ` Florian Weimer
2020-01-29 19:04     ` Florian Weimer
2020-01-29 19:04     ` Florian Weimer
  -- strict thread matches above, loose matches on Subject: below --
2020-01-17 12:49 Sandipan Das
2020-01-17 12:49 ` Sandipan Das
2020-01-17 18:02 ` Dave Hansen
2020-01-17 18:02   ` Dave Hansen
2020-01-18  9:24   ` Sandipan Das
2020-01-18  9:24     ` Sandipan Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3eca7a91-aa3e-cb01-47c8-5d36020993a2@intel.com \
    --to=dave.hansen@intel.com \
    --cc=aneesh.kumar@linux.ibm.com \
    --cc=bauerman@linux.ibm.com \
    --cc=fweimer@redhat.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=linuxram@us.ibm.com \
    --cc=mhocko@kernel.org \
    --cc=mingo@redhat.com \
    --cc=mpe@ellerman.id.au \
    --cc=msuchanek@suse.de \
    --cc=sandipan@linux.ibm.com \
    --cc=shuah@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.