From: Sandipan Das <sandipan@linux.ibm.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: shuah@kernel.org, linux-kselftest@vger.kernel.org,
linux-arch@vger.kernel.org, fweimer@redhat.com, x86@kernel.org,
linuxram@us.ibm.com, mhocko@kernel.org, linux-mm@kvack.org,
mingo@redhat.com, aneesh.kumar@linux.ibm.com,
bauerman@linux.ibm.com, msuchanek@suse.de, mpe@ellerman.id.au,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys
Date: Thu, 30 Jan 2020 14:50:10 +0530 [thread overview]
Message-ID: <880326d5-e23c-6724-1c93-7b1d0281dcbd@linux.ibm.com> (raw)
In-Reply-To: <26f630e5-1f70-888c-4b43-30e73c9f270c@linux.ibm.com>
On 30/01/20 11:49 am, Sandipan Das wrote:
> Hi Dave,
>
> On 30/01/20 12:29 am, Dave Hansen wrote:
>> On 1/28/20 1:38 AM, Sandipan Das wrote:
>>> On 27/01/20 9:12 pm, Dave Hansen wrote:
>>>> How have you tested this patch (and the whole series for that matter)?
>>>>
>>> I replaced the second patch with this one and did a build test.
>>> Till v16, I had tested the whole series (build + run) on both a POWER8
>>> system (with 4K and 64K page sizes) and a Skylake SP system but for
>>> x86_64 only.
>>
>> Do you have any idea why I was seeing x86 build errors and you were not?
>>
>
> There were problems with patch 2 from v17. The fixed patch is what I replied
> with previously in this thread. The test results that I posted were with that
> patch included. Will post out v18 today with the fix.
>
In patch 2 of v17, the issue was with the target names. Upon adding something
to TEST_GEN_FILES, rules for targets like the following are expected to be
defined.
<path-to-linux-source>/tools/testing/selftests/vm/protection_keys_32
<path-to-linux-source>/tools/testing/selftests/vm/protection_keys_64
<path-to-linux-source>/tools/testing/selftests/vm/protection_keys
But instead, I only defined rules for these.
protection_keys_32
protection_keys_64
protection_keys
Hence the build was failing in these cases:
$ make -C tools/testing/selftests
$ make -C tools/testing/selftests/vm
$ cd tools/testing/selftests/vm
$ make
But worked in these cases:
$ make -C tools/testing/selftests/vm protection_keys
$ cd tools/testing/selftests/vm
$ make protection_keys
This has been addressed in v18.
- Sandipan
WARNING: multiple messages have this Message-ID (diff)
From: Sandipan Das <sandipan@linux.ibm.com>
To: Dave Hansen <dave.hansen@intel.com>
Cc: linux-arch@vger.kernel.org, fweimer@redhat.com,
aneesh.kumar@linux.ibm.com, x86@kernel.org, linuxram@us.ibm.com,
linuxppc-dev@lists.ozlabs.org, mhocko@kernel.org,
linux-mm@kvack.org, mingo@redhat.com,
linux-kselftest@vger.kernel.org, msuchanek@suse.de,
shuah@kernel.org, bauerman@linux.ibm.com
Subject: Re: [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys
Date: Thu, 30 Jan 2020 14:50:10 +0530 [thread overview]
Message-ID: <880326d5-e23c-6724-1c93-7b1d0281dcbd@linux.ibm.com> (raw)
In-Reply-To: <26f630e5-1f70-888c-4b43-30e73c9f270c@linux.ibm.com>
On 30/01/20 11:49 am, Sandipan Das wrote:
> Hi Dave,
>
> On 30/01/20 12:29 am, Dave Hansen wrote:
>> On 1/28/20 1:38 AM, Sandipan Das wrote:
>>> On 27/01/20 9:12 pm, Dave Hansen wrote:
>>>> How have you tested this patch (and the whole series for that matter)?
>>>>
>>> I replaced the second patch with this one and did a build test.
>>> Till v16, I had tested the whole series (build + run) on both a POWER8
>>> system (with 4K and 64K page sizes) and a Skylake SP system but for
>>> x86_64 only.
>>
>> Do you have any idea why I was seeing x86 build errors and you were not?
>>
>
> There were problems with patch 2 from v17. The fixed patch is what I replied
> with previously in this thread. The test results that I posted were with that
> patch included. Will post out v18 today with the fix.
>
In patch 2 of v17, the issue was with the target names. Upon adding something
to TEST_GEN_FILES, rules for targets like the following are expected to be
defined.
<path-to-linux-source>/tools/testing/selftests/vm/protection_keys_32
<path-to-linux-source>/tools/testing/selftests/vm/protection_keys_64
<path-to-linux-source>/tools/testing/selftests/vm/protection_keys
But instead, I only defined rules for these.
protection_keys_32
protection_keys_64
protection_keys
Hence the build was failing in these cases:
$ make -C tools/testing/selftests
$ make -C tools/testing/selftests/vm
$ cd tools/testing/selftests/vm
$ make
But worked in these cases:
$ make -C tools/testing/selftests/vm protection_keys
$ cd tools/testing/selftests/vm
$ make protection_keys
This has been addressed in v18.
- Sandipan
next prev parent reply other threads:[~2020-01-30 9:20 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-20 8:35 [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys Sandipan Das
2020-01-20 8:35 ` [PATCH v17 " Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` [PATCH v16 " Sandipan Das
2020-01-20 8:35 ` [PATCH v17 01/24] selftests/x86/pkeys: Move selftests to arch-neutral directory Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` [PATCH v17 02/24] selftests: vm: pkeys: Fix multilib builds for x86 Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:35 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 03/24] selftests/vm/pkeys: Rename all references to pkru to a generic name Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 04/24] selftests/vm/pkeys: Move generic definitions to header file Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 05/24] selftests/vm/pkeys: Move some definitions to arch-specific header Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 06/24] selftests/vm/pkeys: Make gcc check arguments of sigsafe_printf() Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 07/24] selftests: vm: pkeys: Use sane types for pkey register Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 08/24] selftests: vm: pkeys: Add helpers for pkey bits Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 09/24] selftests/vm/pkeys: Fix pkey_disable_clear() Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 10/24] selftests/vm/pkeys: Fix assertion in pkey_disable_set/clear() Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 11/24] selftests/vm/pkeys: Fix alloc_random_pkey() to make it really random Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 12/24] selftests: vm: pkeys: Use the correct huge page size Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 13/24] selftests/vm/pkeys: Introduce generic pkey abstractions Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 14/24] selftests/vm/pkeys: Introduce powerpc support Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 15/24] selftests/vm/pkeys: Fix number of reserved powerpc pkeys Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 16/24] selftests/vm/pkeys: Fix assertion in test_pkey_alloc_exhaust() Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 17/24] selftests/vm/pkeys: Improve checks to determine pkey support Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 18/24] selftests/vm/pkeys: Associate key on a mapped page and detect access violation Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 19/24] selftests/vm/pkeys: Associate key on a mapped page and detect write violation Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 20/24] selftests/vm/pkeys: Detect write violation on a mapped access-denied-key page Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 21/24] selftests/vm/pkeys: Introduce a sub-page allocator Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 22/24] selftests/vm/pkeys: Test correct behaviour of pkey-0 Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 23/24] selftests/vm/pkeys: Override access right definitions on powerpc Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` [PATCH v17 24/24] selftests: vm: pkeys: Use the correct page size " Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-20 8:36 ` Sandipan Das
2020-01-22 18:45 ` [PATCH v16 00/23] selftests, powerpc, x86: Memory Protection Keys Dave Hansen
2020-01-22 18:45 ` Dave Hansen
2020-01-27 10:11 ` Sandipan Das
2020-01-27 10:11 ` Sandipan Das
2020-01-27 10:11 ` Sandipan Das
2020-01-27 15:42 ` Dave Hansen
2020-01-27 15:42 ` Dave Hansen
2020-01-28 9:38 ` Sandipan Das
2020-01-28 9:38 ` Sandipan Das
2020-01-29 9:56 ` Sandipan Das
2020-01-29 9:56 ` Sandipan Das
2020-01-29 18:59 ` Dave Hansen
2020-01-29 18:59 ` Dave Hansen
2020-01-30 6:19 ` Sandipan Das
2020-01-30 6:19 ` Sandipan Das
2020-01-30 9:20 ` Sandipan Das [this message]
2020-01-30 9:20 ` Sandipan Das
2020-01-29 19:04 ` Florian Weimer
2020-01-29 19:04 ` Florian Weimer
2020-01-29 19:04 ` Florian Weimer
-- strict thread matches above, loose matches on Subject: below --
2020-01-17 12:49 Sandipan Das
2020-01-17 12:49 ` Sandipan Das
2020-01-17 18:02 ` Dave Hansen
2020-01-17 18:02 ` Dave Hansen
2020-01-18 9:24 ` Sandipan Das
2020-01-18 9:24 ` Sandipan Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=880326d5-e23c-6724-1c93-7b1d0281dcbd@linux.ibm.com \
--to=sandipan@linux.ibm.com \
--cc=aneesh.kumar@linux.ibm.com \
--cc=bauerman@linux.ibm.com \
--cc=dave.hansen@intel.com \
--cc=fweimer@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=linuxram@us.ibm.com \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=mpe@ellerman.id.au \
--cc=msuchanek@suse.de \
--cc=shuah@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.