All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Boyd <sboyd@kernel.org>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>,
	alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	Conor Dooley <conor.dooley@microchip.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Marc Zyngier <maz@kernel.org>,
	ead.org@freedesktop.org, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	linux-media@vger.kernel.org, linux-phy@lists.infrad,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	linux-gpio@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sean Paul <sean@poorly.run>,
	linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
	Eric Dumazet <edumazet@google.com>,
	linux-spi@vger.kernel.org, Vinod Koul <vkoul@kernel.org>,
	linux-crypto@vger.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	freedreno@lists.freedesktop.org,
	"David S. Miller" <davem@davemloft.net>,
	Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'
Date: Mon, 06 Mar 2023 10:59:22 -0800	[thread overview]
Message-ID: <3f3c8bd83ddaac760f25fde2681d3a61.sboyd@kernel.org> (raw)
In-Reply-To: <20230303214223.49451-1-robh@kernel.org>

Quoting Rob Herring (2023-03-03 13:42:23)
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> index 525ebaa93c85..64bfd0f5d4d0 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> @@ -45,14 +45,14 @@ required:
>  additionalProperties: false
>  
>  examples:
> -  #Example 1 - A53 PLL found on MSM8916 devices
> +  # Example 1 - A53 PLL found on MSM8916 devices
>    - |
>      a53pll: clock@b016000 {
>          compatible = "qcom,msm8916-a53pll";
>          reg = <0xb016000 0x40>;
>          #clock-cells = <0>;
>      };
> -  #Example 2 - A53 PLL found on IPQ6018 devices
> +  # Example 2 - A53 PLL found on IPQ6018 devices
>    - |
>      a53pll_ipq: clock-controller@b116000 {
>          compatible = "qcom,ipq6018-a53pll";

WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <sboyd@kernel.org>
To: Rob Herring <robh@kernel.org>, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	"David S.Miller" <davem@davemloft.net>,
	Rob Clark <robdclark@gmail.com>,
	Abhinav Kumar <quic_abhinavk@quicinc.com>,
	Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
	Sean Paul <sean@poorly.run>, Thomas Gleixner <tglx@linutronix.de>,
	Marc Zyngier <maz@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Heiner Kallweit <hkallweit1@gmail.com>,
	Vinod Koul <vkoul@kernel.org>,
	Kishon Vijay Abraham I <kishon@kernel.org>,
	Mark Brown <broonie@kernel.org>,
	Conor Dooley <conor.dooley@microchip.com>,
	linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
	dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
	linux-media@vger.kernel.org, netdev@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-phy@lists.infrad,
	ead.org@alsa-project.org, linux-gpio@vger.kernel.org,
	alsa-devel@alsa-project.org, linux-riscv@lists.infradead.org,
	linux-spi@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'
Date: Mon, 06 Mar 2023 10:59:22 -0800	[thread overview]
Message-ID: <3f3c8bd83ddaac760f25fde2681d3a61.sboyd@kernel.org> (raw)
In-Reply-To: <20230303214223.49451-1-robh@kernel.org>

Quoting Rob Herring (2023-03-03 13:42:23)
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Stephen Boyd <sboyd@kernel.org>

> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> index 525ebaa93c85..64bfd0f5d4d0 100644
> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml
> @@ -45,14 +45,14 @@ required:
>  additionalProperties: false
>  
>  examples:
> -  #Example 1 - A53 PLL found on MSM8916 devices
> +  # Example 1 - A53 PLL found on MSM8916 devices
>    - |
>      a53pll: clock@b016000 {
>          compatible = "qcom,msm8916-a53pll";
>          reg = <0xb016000 0x40>;
>          #clock-cells = <0>;
>      };
> -  #Example 2 - A53 PLL found on IPQ6018 devices
> +  # Example 2 - A53 PLL found on IPQ6018 devices
>    - |
>      a53pll_ipq: clock-controller@b116000 {
>          compatible = "qcom,ipq6018-a53pll";

  parent reply	other threads:[~2023-03-06 18:59 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 21:42 [PATCH] dt-bindings: yamllint: Require a space after a comment '#' Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:51 ` Conor Dooley
2023-03-03 21:51   ` Conor Dooley
2023-03-03 21:51   ` Conor Dooley
2023-03-03 21:51   ` Conor Dooley
2023-03-03 21:51   ` Conor Dooley
2023-03-03 23:41 ` Dmitry Baryshkov
2023-03-03 23:41   ` Dmitry Baryshkov
2023-03-03 23:41   ` Dmitry Baryshkov
2023-03-03 23:41   ` Dmitry Baryshkov
2023-03-03 23:41   ` Dmitry Baryshkov
2023-03-03 23:53 ` Jakub Kicinski
2023-03-03 23:53   ` Jakub Kicinski
2023-03-03 23:53   ` Jakub Kicinski
2023-03-03 23:53   ` Jakub Kicinski
2023-03-03 23:53   ` Jakub Kicinski
2023-03-04 20:14 ` Mark Brown
2023-03-04 20:14   ` Mark Brown
2023-03-04 20:14   ` Mark Brown
2023-03-04 20:14   ` Mark Brown
2023-03-04 20:14   ` Mark Brown
2023-03-04 21:06 ` Simon Horman
2023-03-04 21:06   ` Simon Horman
2023-03-04 21:06   ` Simon Horman
2023-03-04 21:06   ` Simon Horman
2023-03-04 21:06   ` Simon Horman
2023-03-06 18:59 ` Stephen Boyd [this message]
2023-03-06 18:59   ` Stephen Boyd
2023-03-08 18:11 ` Rob Herring
2023-03-08 18:11   ` Rob Herring
2023-03-08 18:11   ` Rob Herring
2023-03-08 18:11   ` Rob Herring
2023-03-08 18:11   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f3c8bd83ddaac760f25fde2681d3a61.sboyd@kernel.org \
    --to=sboyd@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=ead.org@freedesktop.org \
    --cc=edumazet@google.com \
    --cc=freedreno@lists.freedesktop.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=hkallweit1@gmail.com \
    --cc=kishon@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-phy@lists.infrad \
    --cc=linux-riscv@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=maz@kernel.org \
    --cc=mchehab@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=quic_abhinavk@quicinc.com \
    --cc=robh@kernel.org \
    --cc=sean@poorly.run \
    --cc=tglx@linutronix.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.