From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
alsa-devel@alsa-project.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-phy@lists.infradead.org, linux-riscv@lists.infradead.org,
linux-clk@vger.kernel.org,
Kishon Vijay Abraham I <kishon@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
Marc Zyngier <maz@kernel.org>, Vinod Koul <vkoul@kernel.org>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
linux-gpio@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sean Paul <sean@poorly.run>,
linux-arm-kernel@lists.infradead.org,
Stephen Boyd <sboyd@kernel.org>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
linux-spi@vger.kernel.org, linux-crypto@vger.kernel.org,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
freedreno@lists.freedesktop.org,
"David S. Miller" <davem@davemloft.net>,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'
Date: Fri, 3 Mar 2023 21:51:12 +0000 [thread overview]
Message-ID: <cdad5aa0-bd94-4137-9063-af45e94a25b7@spud> (raw)
In-Reply-To: <20230303214223.49451-1-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]
On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote:
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Cc: Conor Dooley <conor.dooley@microchip.com>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 1051690e3753..74a817cc7d94 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -22,7 +22,7 @@ properties:
> - items:
> - const: microchip,mpfs-qspi
> - const: microchip,coreqspi-rtl-v2
> - - const: microchip,coreqspi-rtl-v2 #FPGA QSPI
> + - const: microchip,coreqspi-rtl-v2 # FPGA QSPI
> - const: microchip,mpfs-spi
I had to think for a minute as to what that comment even meant...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org,
alsa-devel@alsa-project.org, linux-riscv@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'
Date: Fri, 3 Mar 2023 21:51:12 +0000 [thread overview]
Message-ID: <cdad5aa0-bd94-4137-9063-af45e94a25b7@spud> (raw)
In-Reply-To: <20230303214223.49451-1-robh@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1326 bytes --]
On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote:
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Cc: Conor Dooley <conor.dooley@microchip.com>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 1051690e3753..74a817cc7d94 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -22,7 +22,7 @@ properties:
> - items:
> - const: microchip,mpfs-qspi
> - const: microchip,coreqspi-rtl-v2
> - - const: microchip,coreqspi-rtl-v2 #FPGA QSPI
> + - const: microchip,coreqspi-rtl-v2 # FPGA QSPI
> - const: microchip,mpfs-spi
I had to think for a minute as to what that comment even meant...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org,
alsa-devel@alsa-project.org, linux-riscv@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'
Date: Fri, 3 Mar 2023 21:51:12 +0000 [thread overview]
Message-ID: <cdad5aa0-bd94-4137-9063-af45e94a25b7@spud> (raw)
In-Reply-To: <20230303214223.49451-1-robh@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]
On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote:
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Cc: Conor Dooley <conor.dooley@microchip.com>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 1051690e3753..74a817cc7d94 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -22,7 +22,7 @@ properties:
> - items:
> - const: microchip,mpfs-qspi
> - const: microchip,coreqspi-rtl-v2
> - - const: microchip,coreqspi-rtl-v2 #FPGA QSPI
> + - const: microchip,coreqspi-rtl-v2 # FPGA QSPI
> - const: microchip,mpfs-spi
I had to think for a minute as to what that comment even meant...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 161 bytes --]
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org,
alsa-devel@alsa-project.org, linux-riscv@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'
Date: Fri, 3 Mar 2023 21:51:12 +0000 [thread overview]
Message-ID: <cdad5aa0-bd94-4137-9063-af45e94a25b7@spud> (raw)
In-Reply-To: <20230303214223.49451-1-robh@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]
On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote:
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Cc: Conor Dooley <conor.dooley@microchip.com>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 1051690e3753..74a817cc7d94 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -22,7 +22,7 @@ properties:
> - items:
> - const: microchip,mpfs-qspi
> - const: microchip,coreqspi-rtl-v2
> - - const: microchip,coreqspi-rtl-v2 #FPGA QSPI
> + - const: microchip,coreqspi-rtl-v2 # FPGA QSPI
> - const: microchip,mpfs-spi
I had to think for a minute as to what that comment even meant...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 112 bytes --]
--
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy
WARNING: multiple messages have this Message-ID (diff)
From: Conor Dooley <conor@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Stephen Boyd <sboyd@kernel.org>,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Rob Clark <robdclark@gmail.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Sean Paul <sean@poorly.run>, Thomas Gleixner <tglx@linutronix.de>,
Marc Zyngier <maz@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Vinod Koul <vkoul@kernel.org>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Mark Brown <broonie@kernel.org>,
Conor Dooley <conor.dooley@microchip.com>,
linux-clk@vger.kernel.org, linux-crypto@vger.kernel.org,
dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org,
linux-media@vger.kernel.org, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-gpio@vger.kernel.org,
alsa-devel@alsa-project.org, linux-riscv@lists.infradead.org,
linux-spi@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: yamllint: Require a space after a comment '#'
Date: Fri, 3 Mar 2023 21:51:12 +0000 [thread overview]
Message-ID: <cdad5aa0-bd94-4137-9063-af45e94a25b7@spud> (raw)
In-Reply-To: <20230303214223.49451-1-robh@kernel.org>
[-- Attachment #1.1: Type: text/plain, Size: 1326 bytes --]
On Fri, Mar 03, 2023 at 03:42:23PM -0600, Rob Herring wrote:
> Enable yamllint to check the prefered commenting style of requiring a
> space after a comment character '#'. Fix the cases in the tree which
> have a warning with this enabled. Most cases just need a space after the
> '#'. A couple of cases with comments which were not intended to be
> comments are revealed. Those were in ti,sa2ul.yaml, ti,cal.yaml, and
> brcm,bcmgenet.yaml.
>
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
> Cc: Conor Dooley <conor.dooley@microchip.com>
> diff --git a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> index 1051690e3753..74a817cc7d94 100644
> --- a/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> +++ b/Documentation/devicetree/bindings/spi/microchip,mpfs-spi.yaml
> @@ -22,7 +22,7 @@ properties:
> - items:
> - const: microchip,mpfs-qspi
> - const: microchip,coreqspi-rtl-v2
> - - const: microchip,coreqspi-rtl-v2 #FPGA QSPI
> + - const: microchip,coreqspi-rtl-v2 # FPGA QSPI
> - const: microchip,mpfs-spi
I had to think for a minute as to what that comment even meant...
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Thanks,
Conor.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-03 21:51 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 21:42 [PATCH] dt-bindings: yamllint: Require a space after a comment '#' Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:42 ` Rob Herring
2023-03-03 21:51 ` Conor Dooley [this message]
2023-03-03 21:51 ` Conor Dooley
2023-03-03 21:51 ` Conor Dooley
2023-03-03 21:51 ` Conor Dooley
2023-03-03 21:51 ` Conor Dooley
2023-03-03 23:41 ` Dmitry Baryshkov
2023-03-03 23:41 ` Dmitry Baryshkov
2023-03-03 23:41 ` Dmitry Baryshkov
2023-03-03 23:41 ` Dmitry Baryshkov
2023-03-03 23:41 ` Dmitry Baryshkov
2023-03-03 23:53 ` Jakub Kicinski
2023-03-03 23:53 ` Jakub Kicinski
2023-03-03 23:53 ` Jakub Kicinski
2023-03-03 23:53 ` Jakub Kicinski
2023-03-03 23:53 ` Jakub Kicinski
2023-03-04 20:14 ` Mark Brown
2023-03-04 20:14 ` Mark Brown
2023-03-04 20:14 ` Mark Brown
2023-03-04 20:14 ` Mark Brown
2023-03-04 20:14 ` Mark Brown
2023-03-04 21:06 ` Simon Horman
2023-03-04 21:06 ` Simon Horman
2023-03-04 21:06 ` Simon Horman
2023-03-04 21:06 ` Simon Horman
2023-03-04 21:06 ` Simon Horman
2023-03-06 18:59 ` Stephen Boyd
2023-03-06 18:59 ` Stephen Boyd
2023-03-08 18:11 ` Rob Herring
2023-03-08 18:11 ` Rob Herring
2023-03-08 18:11 ` Rob Herring
2023-03-08 18:11 ` Rob Herring
2023-03-08 18:11 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cdad5aa0-bd94-4137-9063-af45e94a25b7@spud \
--to=conor@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=andrew@lunn.ch \
--cc=broonie@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=edumazet@google.com \
--cc=freedreno@lists.freedesktop.org \
--cc=herbert@gondor.apana.org.au \
--cc=hkallweit1@gmail.com \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=maz@kernel.org \
--cc=mchehab@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=quic_abhinavk@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=sean@poorly.run \
--cc=tglx@linutronix.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.