From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: f.fainelli@gmail.com, gregkh@linuxfoundation.org,
wahrenst@gmx.net, helgaas@kernel.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
bcm-kernel-feedback-list@broadcom.com, tim.gover@raspberrypi.org,
linux-pci@vger.kernel.org
Subject: Re: [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk
Date: Wed, 13 May 2020 10:05:26 +0300 [thread overview]
Message-ID: <40515fe7-029b-e391-53f9-f87f95097adb@linux.intel.com> (raw)
In-Reply-To: <20200511142514.GB27249@e121166-lin.cambridge.arm.com>
On 11.5.2020 17.25, Lorenzo Pieralisi wrote:
> On Tue, May 05, 2020 at 06:13:17PM +0200, Nicolas Saenz Julienne wrote:
>> On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
>> loaded directly from an EEPROM or, if not present, by the SoC's
>> VideoCore. Inform VideoCore that VL805 was just reset.
>>
>> Also, as this creates a dependency between USB_PCI and VideoCore's
>> firmware interface, and since USB_PCI can't be set as a module neither
>> this can. Reflect that on the firmware interface Kconfg.
>>
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>> ---
>>
>> Changes since v5:
>> - Fix Kconfig issue with allmodconfig
>>
>> Changes since v4:
>> - Do not split up error message
>>
>> Changes since v3:
>> - Add more complete error message
>>
>> Changes since v1:
>> - Make RASPBERRYPI_FIRMWARE dependent on this quirk to make sure it
>> gets compiled when needed.
>>
>> drivers/firmware/Kconfig | 3 ++-
>> drivers/usb/host/pci-quirks.c | 16 ++++++++++++++++
>> 2 files changed, 18 insertions(+), 1 deletion(-)
>
> Hi Mathias,
>
> I would need your ACK to merge this series, thanks.
>
> Lorenzo
Ah, yes, of course
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
WARNING: multiple messages have this Message-ID (diff)
From: Mathias Nyman <mathias.nyman@linux.intel.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Mathias Nyman <mathias.nyman@intel.com>
Cc: f.fainelli@gmail.com, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
tim.gover@raspberrypi.org, helgaas@kernel.org, wahrenst@gmx.net,
linux-pci@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com,
linux-arm-kernel@lists.infradead.org,
linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk
Date: Wed, 13 May 2020 10:05:26 +0300 [thread overview]
Message-ID: <40515fe7-029b-e391-53f9-f87f95097adb@linux.intel.com> (raw)
In-Reply-To: <20200511142514.GB27249@e121166-lin.cambridge.arm.com>
On 11.5.2020 17.25, Lorenzo Pieralisi wrote:
> On Tue, May 05, 2020 at 06:13:17PM +0200, Nicolas Saenz Julienne wrote:
>> On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be
>> loaded directly from an EEPROM or, if not present, by the SoC's
>> VideoCore. Inform VideoCore that VL805 was just reset.
>>
>> Also, as this creates a dependency between USB_PCI and VideoCore's
>> firmware interface, and since USB_PCI can't be set as a module neither
>> this can. Reflect that on the firmware interface Kconfg.
>>
>> Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
>> ---
>>
>> Changes since v5:
>> - Fix Kconfig issue with allmodconfig
>>
>> Changes since v4:
>> - Do not split up error message
>>
>> Changes since v3:
>> - Add more complete error message
>>
>> Changes since v1:
>> - Make RASPBERRYPI_FIRMWARE dependent on this quirk to make sure it
>> gets compiled when needed.
>>
>> drivers/firmware/Kconfig | 3 ++-
>> drivers/usb/host/pci-quirks.c | 16 ++++++++++++++++
>> 2 files changed, 18 insertions(+), 1 deletion(-)
>
> Hi Mathias,
>
> I would need your ACK to merge this series, thanks.
>
> Lorenzo
Ah, yes, of course
Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-13 7:02 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-05 16:13 [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Nicolas Saenz Julienne
2020-05-05 16:13 ` Nicolas Saenz Julienne
2020-05-05 16:13 ` [PATCH v8 1/4] soc: bcm2835: Add notify xHCI reset property Nicolas Saenz Julienne
2020-05-05 16:13 ` Nicolas Saenz Julienne
2020-05-07 21:48 ` Rob Herring
2020-05-07 21:48 ` Rob Herring
2020-05-05 16:13 ` [PATCH v8 2/4] firmware: raspberrypi: Introduce vl805 init routine Nicolas Saenz Julienne
2020-05-05 16:13 ` Nicolas Saenz Julienne
2020-05-07 21:48 ` Rob Herring
2020-05-07 21:48 ` Rob Herring
2020-05-09 10:02 ` Stefan Wahren
2020-05-09 10:02 ` Stefan Wahren
2020-05-09 10:09 ` Stefan Wahren
2020-05-09 10:09 ` Stefan Wahren
2020-05-09 19:20 ` Nicolas Saenz Julienne
2020-05-09 19:20 ` Nicolas Saenz Julienne
2020-05-05 16:13 ` [PATCH v8 3/4] PCI: brcmstb: Wait for Raspberry Pi's firmware when present Nicolas Saenz Julienne
2020-05-05 16:13 ` Nicolas Saenz Julienne
2020-05-07 21:49 ` Rob Herring
2020-05-07 21:49 ` Rob Herring
2020-05-05 16:13 ` [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Nicolas Saenz Julienne
2020-05-05 16:13 ` Nicolas Saenz Julienne
2020-05-07 21:52 ` Rob Herring
2020-05-07 21:52 ` Rob Herring
2020-05-11 14:25 ` Lorenzo Pieralisi
2020-05-11 14:25 ` Lorenzo Pieralisi
2020-05-13 7:05 ` Mathias Nyman [this message]
2020-05-13 7:05 ` Mathias Nyman
2020-06-02 10:05 ` Nicolas Saenz Julienne
2020-06-02 10:05 ` Nicolas Saenz Julienne
2020-06-02 21:57 ` Florian Fainelli
2020-06-02 21:57 ` Florian Fainelli
2020-05-13 11:17 ` [PATCH v8 0/4] " Lorenzo Pieralisi
2020-05-13 11:17 ` Lorenzo Pieralisi
2020-05-13 11:26 ` Nicolas Saenz Julienne
2020-05-13 11:26 ` Nicolas Saenz Julienne
2020-05-13 15:47 ` Lorenzo Pieralisi
2020-05-13 15:47 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40515fe7-029b-e391-53f9-f87f95097adb@linux.intel.com \
--to=mathias.nyman@linux.intel.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-usb@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mathias.nyman@intel.com \
--cc=nsaenzjulienne@suse.de \
--cc=tim.gover@raspberrypi.org \
--cc=wahrenst@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.