From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: Mathias Nyman <mathias.nyman@intel.com>, Rob Herring <robh@kernel.org> Cc: linux-usb@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, tim.gover@raspberrypi.org, linux-pci@vger.kernel.org, Florian Fainelli <f.fainelli@gmail.com>, gregkh@linuxfoundation.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Date: Tue, 02 Jun 2020 12:05:20 +0200 [thread overview] Message-ID: <7cbe4da8ba4a1524824473f8c58720f412a00fc2.camel@suse.de> (raw) In-Reply-To: <20200505161318.26200-5-nsaenzjulienne@suse.de> [-- Attachment #1: Type: text/plain, Size: 3923 bytes --] On Tue, 2020-05-05 at 18:13 +0200, Nicolas Saenz Julienne wrote: > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > VideoCore. Inform VideoCore that VL805 was just reset. > > Also, as this creates a dependency between USB_PCI and VideoCore's > firmware interface, and since USB_PCI can't be set as a module neither > this can. Reflect that on the firmware interface Kconfg. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > --- It was pointed out to me on the u-boot mailing lists that all this could be implemented trough a reset controller. In other words have xhci get the reset controller trough device-tree, assert it, ultamately causing the firmware routine to be run. As much as it pains me to go over stuff that's already 'fixed', it seems to me it's a better solution. On one hand we get over the device-tree dependency mess (see patch #3), and on the other we transform a pci-quirk into something less hacky. That said, before getting my hands dirty, I was wondering if there is any obvious reasons why I shouldn't do this, note that: - We're talking here of a PCIe XCHI device, maybe there's an issue integrating it with DT, given the fact that, as of today, it's not really represented there. - There is no reset controller support in xhci-pci, maybe there are good reasons why. For instance, it's not something that's reflected in any way in the spec. Regards, Nicolas > > Changes since v5: > - Fix Kconfig issue with allmodconfig > > Changes since v4: > - Do not split up error message > > Changes since v3: > - Add more complete error message > > Changes since v1: > - Make RASPBERRYPI_FIRMWARE dependent on this quirk to make sure it > gets compiled when needed. > > drivers/firmware/Kconfig | 3 ++- > drivers/usb/host/pci-quirks.c | 16 ++++++++++++++++ > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 8007d4aa76dc..b42140cff8ac 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -178,8 +178,9 @@ config ISCSI_IBFT > Otherwise, say N. > > config RASPBERRYPI_FIRMWARE > - tristate "Raspberry Pi Firmware Driver" > + bool "Raspberry Pi Firmware Driver" > depends on BCM2835_MBOX > + default USB_PCI > help > This option enables support for communicating with the firmware on the > Raspberry Pi. > diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c > index 92150ecdb036..0b949acfa258 100644 > --- a/drivers/usb/host/pci-quirks.c > +++ b/drivers/usb/host/pci-quirks.c > @@ -16,6 +16,9 @@ > #include <linux/export.h> > #include <linux/acpi.h> > #include <linux/dmi.h> > + > +#include <soc/bcm2835/raspberrypi-firmware.h> > + > #include "pci-quirks.h" > #include "xhci-ext-caps.h" > > @@ -1243,11 +1246,24 @@ static void quirk_usb_handoff_xhci(struct pci_dev > *pdev) > > static void quirk_usb_early_handoff(struct pci_dev *pdev) > { > + int ret; > + > /* Skip Netlogic mips SoC's internal PCI USB controller. > * This device does not need/support EHCI/OHCI handoff > */ > if (pdev->vendor == 0x184e) /* vendor Netlogic */ > return; > + > + if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483) { > + ret = rpi_firmware_init_vl805(pdev); > + if (ret) { > + /* Firmware might be outdated, or something failed */ > + dev_warn(&pdev->dev, > + "Failed to load VL805's firmware: %d. Will > continue to attempt to work, but bad things might happen. You should fix > this...\n", > + ret); > + } > + } > + > if (pdev->class != PCI_CLASS_SERIAL_USB_UHCI && > pdev->class != PCI_CLASS_SERIAL_USB_OHCI && > pdev->class != PCI_CLASS_SERIAL_USB_EHCI && [-- Attachment #2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: Mathias Nyman <mathias.nyman@intel.com>, Rob Herring <robh@kernel.org> Cc: tim.gover@raspberrypi.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Florian Fainelli <f.fainelli@gmail.com>, bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, gregkh@linuxfoundation.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Date: Tue, 02 Jun 2020 12:05:20 +0200 [thread overview] Message-ID: <7cbe4da8ba4a1524824473f8c58720f412a00fc2.camel@suse.de> (raw) In-Reply-To: <20200505161318.26200-5-nsaenzjulienne@suse.de> [-- Attachment #1.1: Type: text/plain, Size: 3923 bytes --] On Tue, 2020-05-05 at 18:13 +0200, Nicolas Saenz Julienne wrote: > On the Raspberry Pi 4, after a PCI reset, VL805's firmware may either be > loaded directly from an EEPROM or, if not present, by the SoC's > VideoCore. Inform VideoCore that VL805 was just reset. > > Also, as this creates a dependency between USB_PCI and VideoCore's > firmware interface, and since USB_PCI can't be set as a module neither > this can. Reflect that on the firmware interface Kconfg. > > Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> > --- It was pointed out to me on the u-boot mailing lists that all this could be implemented trough a reset controller. In other words have xhci get the reset controller trough device-tree, assert it, ultamately causing the firmware routine to be run. As much as it pains me to go over stuff that's already 'fixed', it seems to me it's a better solution. On one hand we get over the device-tree dependency mess (see patch #3), and on the other we transform a pci-quirk into something less hacky. That said, before getting my hands dirty, I was wondering if there is any obvious reasons why I shouldn't do this, note that: - We're talking here of a PCIe XCHI device, maybe there's an issue integrating it with DT, given the fact that, as of today, it's not really represented there. - There is no reset controller support in xhci-pci, maybe there are good reasons why. For instance, it's not something that's reflected in any way in the spec. Regards, Nicolas > > Changes since v5: > - Fix Kconfig issue with allmodconfig > > Changes since v4: > - Do not split up error message > > Changes since v3: > - Add more complete error message > > Changes since v1: > - Make RASPBERRYPI_FIRMWARE dependent on this quirk to make sure it > gets compiled when needed. > > drivers/firmware/Kconfig | 3 ++- > drivers/usb/host/pci-quirks.c | 16 ++++++++++++++++ > 2 files changed, 18 insertions(+), 1 deletion(-) > > diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig > index 8007d4aa76dc..b42140cff8ac 100644 > --- a/drivers/firmware/Kconfig > +++ b/drivers/firmware/Kconfig > @@ -178,8 +178,9 @@ config ISCSI_IBFT > Otherwise, say N. > > config RASPBERRYPI_FIRMWARE > - tristate "Raspberry Pi Firmware Driver" > + bool "Raspberry Pi Firmware Driver" > depends on BCM2835_MBOX > + default USB_PCI > help > This option enables support for communicating with the firmware on the > Raspberry Pi. > diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c > index 92150ecdb036..0b949acfa258 100644 > --- a/drivers/usb/host/pci-quirks.c > +++ b/drivers/usb/host/pci-quirks.c > @@ -16,6 +16,9 @@ > #include <linux/export.h> > #include <linux/acpi.h> > #include <linux/dmi.h> > + > +#include <soc/bcm2835/raspberrypi-firmware.h> > + > #include "pci-quirks.h" > #include "xhci-ext-caps.h" > > @@ -1243,11 +1246,24 @@ static void quirk_usb_handoff_xhci(struct pci_dev > *pdev) > > static void quirk_usb_early_handoff(struct pci_dev *pdev) > { > + int ret; > + > /* Skip Netlogic mips SoC's internal PCI USB controller. > * This device does not need/support EHCI/OHCI handoff > */ > if (pdev->vendor == 0x184e) /* vendor Netlogic */ > return; > + > + if (pdev->vendor == PCI_VENDOR_ID_VIA && pdev->device == 0x3483) { > + ret = rpi_firmware_init_vl805(pdev); > + if (ret) { > + /* Firmware might be outdated, or something failed */ > + dev_warn(&pdev->dev, > + "Failed to load VL805's firmware: %d. Will > continue to attempt to work, but bad things might happen. You should fix > this...\n", > + ret); > + } > + } > + > if (pdev->class != PCI_CLASS_SERIAL_USB_UHCI && > pdev->class != PCI_CLASS_SERIAL_USB_OHCI && > pdev->class != PCI_CLASS_SERIAL_USB_EHCI && [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 488 bytes --] [-- Attachment #2: Type: text/plain, Size: 176 bytes --] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-02 10:05 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-05 16:13 [PATCH v8 0/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Nicolas Saenz Julienne 2020-05-05 16:13 ` Nicolas Saenz Julienne 2020-05-05 16:13 ` [PATCH v8 1/4] soc: bcm2835: Add notify xHCI reset property Nicolas Saenz Julienne 2020-05-05 16:13 ` Nicolas Saenz Julienne 2020-05-07 21:48 ` Rob Herring 2020-05-07 21:48 ` Rob Herring 2020-05-05 16:13 ` [PATCH v8 2/4] firmware: raspberrypi: Introduce vl805 init routine Nicolas Saenz Julienne 2020-05-05 16:13 ` Nicolas Saenz Julienne 2020-05-07 21:48 ` Rob Herring 2020-05-07 21:48 ` Rob Herring 2020-05-09 10:02 ` Stefan Wahren 2020-05-09 10:02 ` Stefan Wahren 2020-05-09 10:09 ` Stefan Wahren 2020-05-09 10:09 ` Stefan Wahren 2020-05-09 19:20 ` Nicolas Saenz Julienne 2020-05-09 19:20 ` Nicolas Saenz Julienne 2020-05-05 16:13 ` [PATCH v8 3/4] PCI: brcmstb: Wait for Raspberry Pi's firmware when present Nicolas Saenz Julienne 2020-05-05 16:13 ` Nicolas Saenz Julienne 2020-05-07 21:49 ` Rob Herring 2020-05-07 21:49 ` Rob Herring 2020-05-05 16:13 ` [PATCH v8 4/4] USB: pci-quirks: Add Raspberry Pi 4 quirk Nicolas Saenz Julienne 2020-05-05 16:13 ` Nicolas Saenz Julienne 2020-05-07 21:52 ` Rob Herring 2020-05-07 21:52 ` Rob Herring 2020-05-11 14:25 ` Lorenzo Pieralisi 2020-05-11 14:25 ` Lorenzo Pieralisi 2020-05-13 7:05 ` Mathias Nyman 2020-05-13 7:05 ` Mathias Nyman 2020-06-02 10:05 ` Nicolas Saenz Julienne [this message] 2020-06-02 10:05 ` Nicolas Saenz Julienne 2020-06-02 21:57 ` Florian Fainelli 2020-06-02 21:57 ` Florian Fainelli 2020-05-13 11:17 ` [PATCH v8 0/4] " Lorenzo Pieralisi 2020-05-13 11:17 ` Lorenzo Pieralisi 2020-05-13 11:26 ` Nicolas Saenz Julienne 2020-05-13 11:26 ` Nicolas Saenz Julienne 2020-05-13 15:47 ` Lorenzo Pieralisi 2020-05-13 15:47 ` Lorenzo Pieralisi
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=7cbe4da8ba4a1524824473f8c58720f412a00fc2.camel@suse.de \ --to=nsaenzjulienne@suse.de \ --cc=bcm-kernel-feedback-list@broadcom.com \ --cc=f.fainelli@gmail.com \ --cc=gregkh@linuxfoundation.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pci@vger.kernel.org \ --cc=linux-rpi-kernel@lists.infradead.org \ --cc=linux-usb@vger.kernel.org \ --cc=mathias.nyman@intel.com \ --cc=robh@kernel.org \ --cc=tim.gover@raspberrypi.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.