From: neil.armstrong@linaro.org
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: jbrunet@baylibre.com, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
khilman@baylibre.com, conor+dt@kernel.org, kernel@sberdevices.ru,
sdfw_system_team@sberdevices.ru, rockosov@gmail.com,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jan Dakinevich <yvdakinevich@sberdevices.ru>
Subject: Re: [PATCH v1 6/6] arm64: dts: meson: a1: add eMMC controller and its pins
Date: Mon, 26 Jun 2023 15:36:23 +0200 [thread overview]
Message-ID: <41e6d93a-8899-e792-0859-d26360ef5dab@linaro.org> (raw)
In-Reply-To: <CAFBinCC_g6FhzR=PNDsYwT4OZb4uAXAWYGKSe7vSX7_pWM8pNA@mail.gmail.com>
Hi,
On 25/06/2023 23:11, Martin Blumenstingl wrote:
> On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
>>
>> From: Jan Dakinevich <yvdakinevich@sberdevices.ru>
>>
>> The definition is inspired by a similar one for AXG SoC family.
>> 'sdio_pins' and 'sdio_clk_gate_pins' pinctrls are supposed to be used as
>> "default" and "clk-gate" in board-specific device trees.
> Let's wait for Neil's response on the other patch for the question
> about pin mux settings
>
>> 'meson-gx' driver during initialization sets clock to safe low-frequency
>> value (400kHz). However, both source clocks ("clkin0" and "clkin1") are
>> high-frequency by default, and using of eMMC's internal divider is not
>> enough to achieve so low values. To provide low-frequency source,
>> reparent "sd_emmc_sel2" clock using 'assigned-clocks' property.
> Even if the pinctrl part should be postponed then I think it's worth
> adding &sd_emmc
Yeah it's weird to add HW definition and to not enable them,
so please enable them in the board if you add them in the DTSI.
Neil
WARNING: multiple messages have this Message-ID (diff)
From: neil.armstrong@linaro.org
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: jbrunet@baylibre.com, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
khilman@baylibre.com, conor+dt@kernel.org, kernel@sberdevices.ru,
sdfw_system_team@sberdevices.ru, rockosov@gmail.com,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jan Dakinevich <yvdakinevich@sberdevices.ru>
Subject: Re: [PATCH v1 6/6] arm64: dts: meson: a1: add eMMC controller and its pins
Date: Mon, 26 Jun 2023 15:36:23 +0200 [thread overview]
Message-ID: <41e6d93a-8899-e792-0859-d26360ef5dab@linaro.org> (raw)
In-Reply-To: <CAFBinCC_g6FhzR=PNDsYwT4OZb4uAXAWYGKSe7vSX7_pWM8pNA@mail.gmail.com>
Hi,
On 25/06/2023 23:11, Martin Blumenstingl wrote:
> On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
>>
>> From: Jan Dakinevich <yvdakinevich@sberdevices.ru>
>>
>> The definition is inspired by a similar one for AXG SoC family.
>> 'sdio_pins' and 'sdio_clk_gate_pins' pinctrls are supposed to be used as
>> "default" and "clk-gate" in board-specific device trees.
> Let's wait for Neil's response on the other patch for the question
> about pin mux settings
>
>> 'meson-gx' driver during initialization sets clock to safe low-frequency
>> value (400kHz). However, both source clocks ("clkin0" and "clkin1") are
>> high-frequency by default, and using of eMMC's internal divider is not
>> enough to achieve so low values. To provide low-frequency source,
>> reparent "sd_emmc_sel2" clock using 'assigned-clocks' property.
> Even if the pinctrl part should be postponed then I think it's worth
> adding &sd_emmc
Yeah it's weird to add HW definition and to not enable them,
so please enable them in the board if you add them in the DTSI.
Neil
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
WARNING: multiple messages have this Message-ID (diff)
From: neil.armstrong@linaro.org
To: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Dmitry Rokosov <ddrokosov@sberdevices.ru>
Cc: jbrunet@baylibre.com, mturquette@baylibre.com, sboyd@kernel.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
khilman@baylibre.com, conor+dt@kernel.org, kernel@sberdevices.ru,
sdfw_system_team@sberdevices.ru, rockosov@gmail.com,
linux-amlogic@lists.infradead.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Jan Dakinevich <yvdakinevich@sberdevices.ru>
Subject: Re: [PATCH v1 6/6] arm64: dts: meson: a1: add eMMC controller and its pins
Date: Mon, 26 Jun 2023 15:36:23 +0200 [thread overview]
Message-ID: <41e6d93a-8899-e792-0859-d26360ef5dab@linaro.org> (raw)
In-Reply-To: <CAFBinCC_g6FhzR=PNDsYwT4OZb4uAXAWYGKSe7vSX7_pWM8pNA@mail.gmail.com>
Hi,
On 25/06/2023 23:11, Martin Blumenstingl wrote:
> On Wed, Jun 7, 2023 at 10:16 PM Dmitry Rokosov <ddrokosov@sberdevices.ru> wrote:
>>
>> From: Jan Dakinevich <yvdakinevich@sberdevices.ru>
>>
>> The definition is inspired by a similar one for AXG SoC family.
>> 'sdio_pins' and 'sdio_clk_gate_pins' pinctrls are supposed to be used as
>> "default" and "clk-gate" in board-specific device trees.
> Let's wait for Neil's response on the other patch for the question
> about pin mux settings
>
>> 'meson-gx' driver during initialization sets clock to safe low-frequency
>> value (400kHz). However, both source clocks ("clkin0" and "clkin1") are
>> high-frequency by default, and using of eMMC's internal divider is not
>> enough to achieve so low values. To provide low-frequency source,
>> reparent "sd_emmc_sel2" clock using 'assigned-clocks' property.
> Even if the pinctrl part should be postponed then I think it's worth
> adding &sd_emmc
Yeah it's weird to add HW definition and to not enable them,
so please enable them in the board if you add them in the DTSI.
Neil
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-26 13:36 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 20:16 [PATCH v1 0/6] arm64: dts: meson: a1: introduce several peripheral IPs Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 1/6] arm64: dts: meson: a1: introduce PLL and Peripherals clk controllers Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-25 21:00 ` Martin Blumenstingl
2023-06-25 21:00 ` Martin Blumenstingl
2023-06-25 21:00 ` Martin Blumenstingl
2023-06-28 14:18 ` Dmitry Rokosov
2023-06-28 14:18 ` Dmitry Rokosov
2023-06-28 14:18 ` Dmitry Rokosov
2023-06-28 20:51 ` Martin Blumenstingl
2023-06-28 20:51 ` Martin Blumenstingl
2023-06-28 20:51 ` Martin Blumenstingl
2023-06-07 20:16 ` [PATCH v1 2/6] arm64: dts: meson: a1: support USB controller in OTG mode Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 3/6] arm64: dts: meson: a1: enable efuse controller and setup its clk Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-25 20:50 ` Martin Blumenstingl
2023-06-25 20:50 ` Martin Blumenstingl
2023-06-25 20:50 ` Martin Blumenstingl
2023-06-28 14:20 ` Dmitry Rokosov
2023-06-28 14:20 ` Dmitry Rokosov
2023-06-28 14:20 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 4/6] arm64: dts: meson: a1: introduce SPI Flash Controller Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-25 21:03 ` Martin Blumenstingl
2023-06-25 21:03 ` Martin Blumenstingl
2023-06-25 21:03 ` Martin Blumenstingl
2023-06-28 14:23 ` Dmitry Rokosov
2023-06-28 14:23 ` Dmitry Rokosov
2023-06-28 14:23 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 5/6] arm64: dts: meson: a1: introduce UART_AO mux definitions Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-25 21:07 ` Martin Blumenstingl
2023-06-25 21:07 ` Martin Blumenstingl
2023-06-25 21:07 ` Martin Blumenstingl
2023-06-26 13:34 ` neil.armstrong
2023-06-26 13:34 ` neil.armstrong
2023-06-26 13:34 ` neil.armstrong
2023-06-28 14:51 ` Dmitry Rokosov
2023-06-28 14:51 ` Dmitry Rokosov
2023-06-28 14:51 ` Dmitry Rokosov
2023-06-28 14:49 ` Dmitry Rokosov
2023-06-28 14:49 ` Dmitry Rokosov
2023-06-28 14:49 ` Dmitry Rokosov
2023-06-07 20:16 ` [PATCH v1 6/6] arm64: dts: meson: a1: add eMMC controller and its pins Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-07 20:16 ` Dmitry Rokosov
2023-06-25 21:11 ` Martin Blumenstingl
2023-06-25 21:11 ` Martin Blumenstingl
2023-06-25 21:11 ` Martin Blumenstingl
2023-06-26 13:36 ` neil.armstrong [this message]
2023-06-26 13:36 ` neil.armstrong
2023-06-26 13:36 ` neil.armstrong
2023-06-28 14:28 ` Dmitry Rokosov
2023-06-28 14:28 ` Dmitry Rokosov
2023-06-28 14:28 ` Dmitry Rokosov
2023-06-23 8:22 ` [PATCH v1 0/6] arm64: dts: meson: a1: introduce several peripheral IPs Dmitry Rokosov
2023-06-23 8:22 ` Dmitry Rokosov
2023-06-23 8:22 ` Dmitry Rokosov
2023-06-23 8:49 ` Krzysztof Kozlowski
2023-06-23 8:49 ` Krzysztof Kozlowski
2023-06-23 8:49 ` Krzysztof Kozlowski
2023-06-23 11:23 ` Dmitry Rokosov
2023-06-23 11:23 ` Dmitry Rokosov
2023-06-23 11:23 ` Dmitry Rokosov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41e6d93a-8899-e792-0859-d26360ef5dab@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=conor+dt@kernel.org \
--cc=ddrokosov@sberdevices.ru \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=kernel@sberdevices.ru \
--cc=khilman@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=rockosov@gmail.com \
--cc=sboyd@kernel.org \
--cc=sdfw_system_team@sberdevices.ru \
--cc=yvdakinevich@sberdevices.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.