From: Thomas McKahan <tmckahan@singleboardsolutions.com>
To: Robin Murphy <robin.murphy@arm.com>,
Peter Geis <pgwipeout@gmail.com>, Adam Van Ymeren <adam@vany.ca>
Cc: "open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix rk3328-roc-cc sdmmcio-regulator
Date: Wed, 5 Feb 2020 22:05:50 -0500 [thread overview]
Message-ID: <477af575-d43f-fab8-36a4-0a75a4272667@singleboardsolutions.com> (raw)
In-Reply-To: <382b4bd5-279d-b227-5d0c-774d9c164168@arm.com>
On 2/5/2020 2:02 PM, Robin Murphy wrote:
> On 05/02/2020 6:43 pm, Peter Geis wrote:
> [...]
>>> One thing I did notice, though, is that GPIO_MUTE seems to have some
>>> inherent coupling to the analog codec, as the value automatically goes
>>> high when starting to play audio, and low again when stopping (but can
>>> still be manually toggled in between). Thus unless there's some secret
>>> to disabling that behaviour then it might not be safe to enable analog
>>> audio on these ROC-CC boards for fear of messing up peoples' SD cards.
>>
>> Robin,
>> Do you know if that is the SOC doing that or the drivers?
>
> Ha, once again I hastily jump to a conclusion without fully
> investigating... I'm really not doing too well in this thread :)
>
> You're absolutely right; on closer inspection rk3328_analog_output()
> in the codec driver is poking GRF_SOC_CON10 directly. That should be
> straightforward enough to sort out, phew!
>
> Cheers,
> Robin.
>
I've had random reports of SD problems from people using our mainline
images with Armbian on RK3328, I recently enabled the audio codec since
it looked like all the pieces were in place. I'll take a look at the
GPIO_MUTE patchset I saw just landed.
-Tony
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: Thomas McKahan <tmckahan@singleboardsolutions.com>
To: Robin Murphy <robin.murphy@arm.com>,
Peter Geis <pgwipeout@gmail.com>, Adam Van Ymeren <adam@vany.ca>
Cc: "open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
Heiko Stuebner <heiko@sntech.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: Fix rk3328-roc-cc sdmmcio-regulator
Date: Wed, 5 Feb 2020 22:05:50 -0500 [thread overview]
Message-ID: <477af575-d43f-fab8-36a4-0a75a4272667@singleboardsolutions.com> (raw)
In-Reply-To: <382b4bd5-279d-b227-5d0c-774d9c164168@arm.com>
On 2/5/2020 2:02 PM, Robin Murphy wrote:
> On 05/02/2020 6:43 pm, Peter Geis wrote:
> [...]
>>> One thing I did notice, though, is that GPIO_MUTE seems to have some
>>> inherent coupling to the analog codec, as the value automatically goes
>>> high when starting to play audio, and low again when stopping (but can
>>> still be manually toggled in between). Thus unless there's some secret
>>> to disabling that behaviour then it might not be safe to enable analog
>>> audio on these ROC-CC boards for fear of messing up peoples' SD cards.
>>
>> Robin,
>> Do you know if that is the SOC doing that or the drivers?
>
> Ha, once again I hastily jump to a conclusion without fully
> investigating... I'm really not doing too well in this thread :)
>
> You're absolutely right; on closer inspection rk3328_analog_output()
> in the codec driver is poking GRF_SOC_CON10 directly. That should be
> straightforward enough to sort out, phew!
>
> Cheers,
> Robin.
>
I've had random reports of SD problems from people using our mainline
images with Armbian on RK3328, I recently enabled the audio codec since
it looked like all the pieces were in place. I'll take a look at the
GPIO_MUTE patchset I saw just landed.
-Tony
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-06 3:05 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 23:38 [PATCH] arm64: dts: rockchip: Fix rk3328-roc-cc sdmmcio-regulator Adam Van Ymeren
2020-01-31 23:38 ` Adam Van Ymeren
2020-02-01 10:51 ` Robin Murphy
2020-02-01 10:51 ` Robin Murphy
2020-02-01 15:41 ` Adam Van Ymeren
2020-02-01 17:46 ` Robin Murphy
2020-02-01 22:10 ` Adam Van Ymeren
[not found] ` <510d310b-30af-7b24-d472-907bc6b2ef46-M8Nx6PV4agg@public.gmane.org>
2020-02-04 15:15 ` Peter Geis
2020-02-04 15:15 ` Peter Geis
2020-02-04 16:14 ` Adam Van Ymeren
[not found] ` <7b36198e-25c0-4f3b-d871-6bd5aaf619d8-M8Nx6PV4agg@public.gmane.org>
2020-02-04 17:25 ` Peter Geis
2020-02-04 17:25 ` Peter Geis
2020-02-05 16:14 ` Adam Van Ymeren
2020-02-05 17:39 ` Robin Murphy
2020-02-05 17:39 ` Robin Murphy
[not found] ` <2f863743-f5fd-7702-ac22-762dbca834cb-M8Nx6PV4agg@public.gmane.org>
2020-02-05 18:43 ` Peter Geis
2020-02-05 18:43 ` Peter Geis
2020-02-05 19:02 ` Robin Murphy
2020-02-05 19:02 ` Robin Murphy
2020-02-06 3:05 ` Thomas McKahan [this message]
2020-02-06 3:05 ` Thomas McKahan
[not found] ` <CAMdYzYopKjRpVnyq2k84XZK0kmR_ZBH8KNjVyPz3upQjx0rLJQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2020-02-09 1:07 ` Adam Van Ymeren
2020-02-09 1:07 ` Adam Van Ymeren
2020-02-10 13:37 ` Robin Murphy
2020-02-11 21:32 ` Adam Van Ymeren
2020-02-11 21:39 ` Adam Van Ymeren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=477af575-d43f-fab8-36a4-0a75a4272667@singleboardsolutions.com \
--to=tmckahan@singleboardsolutions.com \
--cc=adam@vany.ca \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.