Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode

From: Yibo Zhao <yiboz@codeaurora.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
	ath10k@lists.infradead.org, linux-wireless@vger.kernel.org,
	linux-wireless-owner@vger.kernel.org
Subject: Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode
Date: Wed, 18 Sep 2019 18:18:56 +0800	[thread overview]
Message-ID: <4780268b967c128a42396c39d697e67e@codeaurora.org> (raw)
In-Reply-To: <871rwdj4ez.fsf@toke.dk>

On 2019-09-18 18:16, Toke Høiland-Jørgensen wrote:
> Yibo Zhao <yiboz@codeaurora.org> writes:
> 
>> On 2019-09-18 05:12, Toke Høiland-Jørgensen wrote:
>>> Yibo Zhao <yiboz@codeaurora.org> writes:
>>> 
>>>> On 2019-09-16 23:27, Johannes Berg wrote:
>>>>> Without really looking at the code -
>>>>> 
>>>>>> If station is ineligible for transmission in
>>>>>> ieee80211_txq_may_transmit(),
>>>>>> no packet will be delivered to FW. During the tests in push-pull
>>>>>> mode
>>>>>> with
>>>>>> many clients, after several seconds, not a single station is an
>>>>>> eligible
>>>>>> candidate for transmission since global time is smaller than all 
>>>>>> the
>>>>>> station's virtual airtime. As a consequence, the Tx has been 
>>>>>> blocked
>>>>>> and
>>>>>> throughput is quite low.
>>>>> 
>>>>> You should rewrite this to be, erm, a bit more understandable in
>>>>> mac80211 context. I assume you're speaking (mostly?) about ath10k,
>>>>> but
>>>>> I
>>>>> have very little context there. "push pull mode"? "firmware"? These
>>>>> things are not something mac80211 knows about.
>>>> Hi Johannes,
>>>> 
>>>> Thanks for your kindly reminder. Will rewrite the commit log.
>>>> 
>>>>> 
>>>>>> Co-developed-by: Yibo Zhao <yiboz@codeaurora.org>
>>>>> 
>>>>> That also seems wrong, should be Toke I guess, unless you intended
>>>>> for
>>>>> a
>>>>> From: Toke to be present?
>>>> Do you mean it should be something like:
>>>> 
>>>> Co-developed-by: Toke Høiland-Jørgensen <toke@toke.dk>
>>>> Signed-off-by: Yibo Zhao <yiboz@codeaurora.org>
>>>> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk>
>>>> 
>>>> Am I understanding right?
>>> 
>>> I think the right thing here, as with the previous patch, is to just
>>> drop my sign-off; you're writing this patch, and I'll add ack/reviews
>>> as
>>> appropriate. And in that case, well, no need to have co-developed-by
>>> yourself when your name is on the patch as author :)
>>> 
>>> -Toke
>> Sorry, I think I have missed checking your reply, please ignore the
>> wrong signed-off in PATCH-V2.
> 
> While you're re-spinning, could you please add a changelog for the
> changes you make? Makes it easier to keep track :)
> 
> You can add a cover-letter with a full changelog instead of having a
> separate changelog for each patch; that's what I usually do...
> 
> -Toke
Sure, thanks.
-- 
Yibo