From: Yibo Zhao <yiboz@codeaurora.org> To: Johannes Berg <johannes@sipsolutions.net> Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, "Toke Høiland-Jørgensen" <toke@toke.dk>, linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode Date: Tue, 17 Sep 2019 14:36:20 +0800 [thread overview] Message-ID: <8e4cd872d082c6bce598c87411a2125f@codeaurora.org> (raw) In-Reply-To: <6684ceecde399edeb31c594f889a403440c78142.camel@sipsolutions.net> On 2019-09-16 23:27, Johannes Berg wrote: > Without really looking at the code - > >> If station is ineligible for transmission in >> ieee80211_txq_may_transmit(), >> no packet will be delivered to FW. During the tests in push-pull mode >> with >> many clients, after several seconds, not a single station is an >> eligible >> candidate for transmission since global time is smaller than all the >> station's virtual airtime. As a consequence, the Tx has been blocked >> and >> throughput is quite low. > > You should rewrite this to be, erm, a bit more understandable in > mac80211 context. I assume you're speaking (mostly?) about ath10k, but > I > have very little context there. "push pull mode"? "firmware"? These > things are not something mac80211 knows about. Hi Johannes, Thanks for your kindly reminder. Will rewrite the commit log. > >> Co-developed-by: Yibo Zhao <yiboz@codeaurora.org> > > That also seems wrong, should be Toke I guess, unless you intended for > a > From: Toke to be present? Do you mean it should be something like: Co-developed-by: Toke Høiland-Jørgensen <toke@toke.dk> Signed-off-by: Yibo Zhao <yiboz@codeaurora.org> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk> Am I understanding right? > > johannes -- Yibo
WARNING: multiple messages have this Message-ID (diff)
From: Yibo Zhao <yiboz@codeaurora.org> To: Johannes Berg <johannes@sipsolutions.net> Cc: linux-wireless-owner@vger.kernel.org, "Toke Høiland-Jørgensen" <toke@toke.dk>, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Subject: Re: [PATCH 3/4] mac80211: fix low throughput in push pull mode Date: Tue, 17 Sep 2019 14:36:20 +0800 [thread overview] Message-ID: <8e4cd872d082c6bce598c87411a2125f@codeaurora.org> (raw) In-Reply-To: <6684ceecde399edeb31c594f889a403440c78142.camel@sipsolutions.net> On 2019-09-16 23:27, Johannes Berg wrote: > Without really looking at the code - > >> If station is ineligible for transmission in >> ieee80211_txq_may_transmit(), >> no packet will be delivered to FW. During the tests in push-pull mode >> with >> many clients, after several seconds, not a single station is an >> eligible >> candidate for transmission since global time is smaller than all the >> station's virtual airtime. As a consequence, the Tx has been blocked >> and >> throughput is quite low. > > You should rewrite this to be, erm, a bit more understandable in > mac80211 context. I assume you're speaking (mostly?) about ath10k, but > I > have very little context there. "push pull mode"? "firmware"? These > things are not something mac80211 knows about. Hi Johannes, Thanks for your kindly reminder. Will rewrite the commit log. > >> Co-developed-by: Yibo Zhao <yiboz@codeaurora.org> > > That also seems wrong, should be Toke I guess, unless you intended for > a > From: Toke to be present? Do you mean it should be something like: Co-developed-by: Toke Høiland-Jørgensen <toke@toke.dk> Signed-off-by: Yibo Zhao <yiboz@codeaurora.org> Signed-off-by: Toke Høiland-Jørgensen <toke@toke.dk> Am I understanding right? > > johannes -- Yibo _______________________________________________ ath10k mailing list ath10k@lists.infradead.org http://lists.infradead.org/mailman/listinfo/ath10k
next prev parent reply other threads:[~2019-09-17 6:36 UTC|newest] Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-09-16 13:09 [PATCH 1/4] mac80211: Switch to a virtual time-based airtime scheduler Yibo Zhao 2019-09-16 13:09 ` Yibo Zhao 2019-09-16 13:09 ` [PATCH 2/4] mac80211: defer txqs removal from rbtree Yibo Zhao 2019-09-16 13:09 ` Yibo Zhao 2019-09-17 21:10 ` Toke Høiland-Jørgensen 2019-09-17 21:10 ` Toke Høiland-Jørgensen 2019-09-18 10:27 ` Yibo Zhao 2019-09-18 10:27 ` Yibo Zhao 2019-09-18 11:23 ` Toke Høiland-Jørgensen 2019-09-18 11:23 ` Toke Høiland-Jørgensen 2019-09-19 9:56 ` Yibo Zhao 2019-09-19 9:56 ` Yibo Zhao 2019-09-19 10:37 ` Toke Høiland-Jørgensen 2019-09-19 10:37 ` Toke Høiland-Jørgensen 2019-09-20 8:29 ` Yibo Zhao 2019-09-20 8:29 ` Yibo Zhao 2019-09-20 9:15 ` Toke Høiland-Jørgensen 2019-09-20 9:15 ` Toke Høiland-Jørgensen 2019-09-21 10:49 ` Yibo Zhao 2019-09-21 10:49 ` Yibo Zhao 2019-09-21 11:27 ` Toke Høiland-Jørgensen 2019-09-21 11:27 ` Toke Høiland-Jørgensen 2019-09-21 11:53 ` Yibo Zhao 2019-09-21 11:53 ` Yibo Zhao 2019-09-21 12:22 ` Yibo Zhao 2019-09-21 12:22 ` Yibo Zhao 2019-09-21 13:02 ` Toke Høiland-Jørgensen 2019-09-21 13:02 ` Toke Høiland-Jørgensen 2019-09-21 13:24 ` Yibo Zhao 2019-09-21 13:24 ` Yibo Zhao 2019-09-21 14:00 ` Toke Høiland-Jørgensen 2019-09-21 14:00 ` Toke Høiland-Jørgensen 2019-09-22 5:19 ` Yibo Zhao 2019-09-22 5:19 ` Yibo Zhao 2019-09-23 10:47 ` Toke Høiland-Jørgensen 2019-09-23 10:47 ` Toke Høiland-Jørgensen 2019-09-23 11:42 ` Kalle Valo 2019-09-23 11:42 ` Kalle Valo 2019-09-23 16:39 ` Toke Høiland-Jørgensen 2019-09-23 16:39 ` Toke Høiland-Jørgensen 2019-09-24 5:27 ` Kalle Valo 2019-09-24 5:27 ` Kalle Valo 2019-09-24 7:23 ` Toke Høiland-Jørgensen 2019-09-24 7:23 ` Toke Høiland-Jørgensen 2019-09-24 2:45 ` Yibo Zhao 2019-09-24 2:45 ` Yibo Zhao 2019-09-24 7:26 ` Toke Høiland-Jørgensen 2019-09-24 7:26 ` Toke Høiland-Jørgensen 2019-09-24 8:31 ` Yibo Zhao 2019-09-24 8:31 ` Yibo Zhao 2019-09-24 8:44 ` Toke Høiland-Jørgensen 2019-09-24 8:44 ` Toke Høiland-Jørgensen 2019-09-16 13:09 ` [PATCH 3/4] mac80211: fix low throughput in push pull mode Yibo Zhao 2019-09-16 13:09 ` Yibo Zhao 2019-09-16 15:27 ` Johannes Berg 2019-09-16 15:27 ` Johannes Berg 2019-09-17 6:36 ` Yibo Zhao [this message] 2019-09-17 6:36 ` Yibo Zhao 2019-09-17 6:55 ` Johannes Berg 2019-09-17 6:55 ` Johannes Berg 2019-09-17 21:12 ` Toke Høiland-Jørgensen 2019-09-17 21:12 ` Toke Høiland-Jørgensen 2019-09-18 10:02 ` Yibo Zhao 2019-09-18 10:02 ` Yibo Zhao 2019-09-18 10:16 ` Toke Høiland-Jørgensen 2019-09-18 10:16 ` Toke Høiland-Jørgensen 2019-09-18 10:18 ` Yibo Zhao 2019-09-18 10:18 ` Yibo Zhao 2019-09-16 13:09 ` [PATCH 4/4] mac80211: Sync airtime weight sum with per AC synced sta airtime weight together Yibo Zhao 2019-09-16 13:09 ` Yibo Zhao 2019-09-17 21:24 ` Toke Høiland-Jørgensen 2019-09-17 21:24 ` Toke Høiland-Jørgensen 2019-09-18 10:16 ` Yibo Zhao 2019-09-18 10:16 ` Yibo Zhao 2019-09-16 14:51 ` [PATCH 1/4] mac80211: Switch to a virtual time-based airtime scheduler Toke Høiland-Jørgensen 2019-09-16 14:51 ` Toke Høiland-Jørgensen 2019-09-17 21:31 ` Toke Høiland-Jørgensen 2019-09-17 21:31 ` Toke Høiland-Jørgensen 2019-09-20 8:37 ` Yibo Zhao 2019-09-20 8:37 ` Yibo Zhao
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=8e4cd872d082c6bce598c87411a2125f@codeaurora.org \ --to=yiboz@codeaurora.org \ --cc=ath10k@lists.infradead.org \ --cc=johannes@sipsolutions.net \ --cc=linux-wireless-owner@vger.kernel.org \ --cc=linux-wireless@vger.kernel.org \ --cc=toke@toke.dk \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.