From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: change huge_ptep_clear_flush() to return the original pte
Date: Thu, 5 May 2022 16:15:26 -0700 [thread overview]
Message-ID: <495c4ebe-a5b4-afb6-4cb0-956c1b18d0cc@oracle.com> (raw)
In-Reply-To: <a9038435d408cd7b9defe143537de668dfdf03be.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> It is incorrect to use ptep_clear_flush() to nuke a hugetlb page
> table when unmapping or migrating a hugetlb page, and will change
> to use huge_ptep_clear_flush() instead in the following patches.
>
> So this is a preparation patch, which changes the huge_ptep_clear_flush()
> to return the original pte to help to nuke a hugetlb page table.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> arch/arm64/include/asm/hugetlb.h | 4 ++--
> arch/arm64/mm/hugetlbpage.c | 12 +++++-------
> arch/ia64/include/asm/hugetlb.h | 4 ++--
> arch/mips/include/asm/hugetlb.h | 9 ++++++---
> arch/parisc/include/asm/hugetlb.h | 4 ++--
> arch/powerpc/include/asm/hugetlb.h | 9 ++++++---
> arch/s390/include/asm/hugetlb.h | 6 +++---
> arch/sh/include/asm/hugetlb.h | 4 ++--
> arch/sparc/include/asm/hugetlb.h | 4 ++--
> include/asm-generic/hugetlb.h | 4 ++--
> 10 files changed, 32 insertions(+), 28 deletions(-)
The above changes look straight forward.
Happy that you Cc'ed impacted arch maintainers so they can at least
have a look.
The only user of huge_ptep_clear_flush() today is hugetlb_cow/wp() in
mm/hugetlb.c. Any reason why you did not change that code? At least
cast the return of huge_ptep_clear_flush() to void with a comment?
Not absolutely necessary.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: dalias@libc.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com, linux-mm@kvack.org,
paulus@samba.org, sparclinux@vger.kernel.org,
agordeev@linux.ibm.com, linux-arch@vger.kernel.org,
linux-s390@vger.kernel.org, arnd@arndb.de,
ysato@users.sourceforge.jp, deller@gmx.de,
borntraeger@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com,
linux-arm-kernel@lists.infradead.org, tsbogend@alpha.franken.de,
linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org,
svens@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net
Subject: Re: [PATCH 1/3] mm: change huge_ptep_clear_flush() to return the original pte
Date: Thu, 5 May 2022 16:15:26 -0700 [thread overview]
Message-ID: <495c4ebe-a5b4-afb6-4cb0-956c1b18d0cc@oracle.com> (raw)
In-Reply-To: <a9038435d408cd7b9defe143537de668dfdf03be.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> It is incorrect to use ptep_clear_flush() to nuke a hugetlb page
> table when unmapping or migrating a hugetlb page, and will change
> to use huge_ptep_clear_flush() instead in the following patches.
>
> So this is a preparation patch, which changes the huge_ptep_clear_flush()
> to return the original pte to help to nuke a hugetlb page table.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> arch/arm64/include/asm/hugetlb.h | 4 ++--
> arch/arm64/mm/hugetlbpage.c | 12 +++++-------
> arch/ia64/include/asm/hugetlb.h | 4 ++--
> arch/mips/include/asm/hugetlb.h | 9 ++++++---
> arch/parisc/include/asm/hugetlb.h | 4 ++--
> arch/powerpc/include/asm/hugetlb.h | 9 ++++++---
> arch/s390/include/asm/hugetlb.h | 6 +++---
> arch/sh/include/asm/hugetlb.h | 4 ++--
> arch/sparc/include/asm/hugetlb.h | 4 ++--
> include/asm-generic/hugetlb.h | 4 ++--
> 10 files changed, 32 insertions(+), 28 deletions(-)
The above changes look straight forward.
Happy that you Cc'ed impacted arch maintainers so they can at least
have a look.
The only user of huge_ptep_clear_flush() today is hugetlb_cow/wp() in
mm/hugetlb.c. Any reason why you did not change that code? At least
cast the return of huge_ptep_clear_flush() to void with a comment?
Not absolutely necessary.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: change huge_ptep_clear_flush() to return the original pte
Date: Thu, 5 May 2022 16:15:26 -0700 [thread overview]
Message-ID: <495c4ebe-a5b4-afb6-4cb0-956c1b18d0cc@oracle.com> (raw)
In-Reply-To: <a9038435d408cd7b9defe143537de668dfdf03be.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> It is incorrect to use ptep_clear_flush() to nuke a hugetlb page
> table when unmapping or migrating a hugetlb page, and will change
> to use huge_ptep_clear_flush() instead in the following patches.
>
> So this is a preparation patch, which changes the huge_ptep_clear_flush()
> to return the original pte to help to nuke a hugetlb page table.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> arch/arm64/include/asm/hugetlb.h | 4 ++--
> arch/arm64/mm/hugetlbpage.c | 12 +++++-------
> arch/ia64/include/asm/hugetlb.h | 4 ++--
> arch/mips/include/asm/hugetlb.h | 9 ++++++---
> arch/parisc/include/asm/hugetlb.h | 4 ++--
> arch/powerpc/include/asm/hugetlb.h | 9 ++++++---
> arch/s390/include/asm/hugetlb.h | 6 +++---
> arch/sh/include/asm/hugetlb.h | 4 ++--
> arch/sparc/include/asm/hugetlb.h | 4 ++--
> include/asm-generic/hugetlb.h | 4 ++--
> 10 files changed, 32 insertions(+), 28 deletions(-)
The above changes look straight forward.
Happy that you Cc'ed impacted arch maintainers so they can at least
have a look.
The only user of huge_ptep_clear_flush() today is hugetlb_cow/wp() in
mm/hugetlb.c. Any reason why you did not change that code? At least
cast the return of huge_ptep_clear_flush() to void with a comment?
Not absolutely necessary.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 1/3] mm: change huge_ptep_clear_flush() to return the original pte
Date: Thu, 05 May 2022 23:15:26 +0000 [thread overview]
Message-ID: <495c4ebe-a5b4-afb6-4cb0-956c1b18d0cc@oracle.com> (raw)
In-Reply-To: <a9038435d408cd7b9defe143537de668dfdf03be.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> It is incorrect to use ptep_clear_flush() to nuke a hugetlb page
> table when unmapping or migrating a hugetlb page, and will change
> to use huge_ptep_clear_flush() instead in the following patches.
>
> So this is a preparation patch, which changes the huge_ptep_clear_flush()
> to return the original pte to help to nuke a hugetlb page table.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> arch/arm64/include/asm/hugetlb.h | 4 ++--
> arch/arm64/mm/hugetlbpage.c | 12 +++++-------
> arch/ia64/include/asm/hugetlb.h | 4 ++--
> arch/mips/include/asm/hugetlb.h | 9 ++++++---
> arch/parisc/include/asm/hugetlb.h | 4 ++--
> arch/powerpc/include/asm/hugetlb.h | 9 ++++++---
> arch/s390/include/asm/hugetlb.h | 6 +++---
> arch/sh/include/asm/hugetlb.h | 4 ++--
> arch/sparc/include/asm/hugetlb.h | 4 ++--
> include/asm-generic/hugetlb.h | 4 ++--
> 10 files changed, 32 insertions(+), 28 deletions(-)
The above changes look straight forward.
Happy that you Cc'ed impacted arch maintainers so they can at least
have a look.
The only user of huge_ptep_clear_flush() today is hugetlb_cow/wp() in
mm/hugetlb.c. Any reason why you did not change that code? At least
cast the return of huge_ptep_clear_flush() to void with a comment?
Not absolutely necessary.
Acked-by: Mike Kravetz <mike.kravetz@oracle.com>
--
Mike Kravetz
next prev parent reply other threads:[~2022-05-05 23:17 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:14 [PATCH 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` [PATCH 1/3] mm: change huge_ptep_clear_flush() to return the original pte Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-05-05 23:15 ` Mike Kravetz [this message]
2022-05-05 23:15 ` Mike Kravetz
2022-05-05 23:15 ` Mike Kravetz
2022-05-05 23:15 ` Mike Kravetz
2022-05-06 3:02 ` Baolin Wang
2022-05-06 3:02 ` Baolin Wang
2022-05-06 3:02 ` Baolin Wang
2022-05-06 3:02 ` Baolin Wang
2022-04-29 8:14 ` [PATCH 2/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when migration Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-05-05 23:53 ` Mike Kravetz
2022-05-05 23:53 ` Mike Kravetz
2022-05-05 23:53 ` Mike Kravetz
2022-05-05 23:53 ` Mike Kravetz
2022-05-06 3:39 ` Baolin Wang
2022-05-06 3:39 ` Baolin Wang
2022-05-06 3:39 ` Baolin Wang
2022-05-06 3:39 ` Baolin Wang
2022-05-06 17:56 ` Mike Kravetz
2022-05-06 17:56 ` Mike Kravetz
2022-05-06 17:56 ` Mike Kravetz
2022-05-06 17:56 ` Mike Kravetz
2022-05-07 2:33 ` Baolin Wang
2022-05-07 2:33 ` Baolin Wang
2022-05-07 2:33 ` Baolin Wang
2022-05-07 2:33 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-04-29 8:14 ` [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 20:02 ` Gerald Schaefer
2022-04-29 20:02 ` Gerald Schaefer
2022-04-29 20:02 ` Gerald Schaefer
2022-04-29 20:02 ` Gerald Schaefer
2022-04-30 3:22 ` Baolin Wang
2022-04-30 3:22 ` Baolin Wang
2022-04-30 3:22 ` Baolin Wang
2022-04-30 3:22 ` Baolin Wang
2022-05-02 14:02 ` Gerald Schaefer
2022-05-02 14:02 ` Gerald Schaefer
2022-05-02 14:02 ` Gerald Schaefer
2022-05-02 14:02 ` Gerald Schaefer
2022-05-03 2:19 ` Baolin Wang
2022-05-03 2:19 ` Baolin Wang
2022-05-03 2:19 ` Baolin Wang
2022-05-03 2:19 ` Baolin Wang
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 13:33 ` Baolin Wang
2022-05-03 13:33 ` Baolin Wang
2022-05-03 13:33 ` Baolin Wang
2022-05-03 13:33 ` Baolin Wang
2022-05-06 19:07 ` Mike Kravetz
2022-05-06 19:07 ` Mike Kravetz
2022-05-06 19:07 ` Mike Kravetz
2022-05-06 19:07 ` Mike Kravetz
2022-05-09 16:41 ` Peter Xu
2022-05-09 16:41 ` Peter Xu
2022-05-09 16:41 ` Peter Xu
2022-05-09 16:41 ` Peter Xu
2022-05-10 1:28 ` Baolin Wang
2022-05-10 1:28 ` Baolin Wang
2022-05-10 1:28 ` Baolin Wang
2022-05-10 1:28 ` Baolin Wang
2022-05-06 18:55 ` Mike Kravetz
2022-05-06 18:55 ` Mike Kravetz
2022-05-06 18:55 ` Mike Kravetz
2022-05-06 18:55 ` Mike Kravetz
2022-05-07 1:32 ` Baolin Wang
2022-05-07 1:32 ` Baolin Wang
2022-05-07 1:32 ` Baolin Wang
2022-05-07 1:32 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495c4ebe-a5b4-afb6-4cb0-956c1b18d0cc@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.