From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping
Date: Fri, 6 May 2022 11:55:13 -0700 [thread overview]
Message-ID: <f64f0d4f-f0fc-f07c-3c17-96f124da21e4@oracle.com> (raw)
In-Reply-To: <c91e04ebb792ef7b72966edea8bd6fa2dfa5bfa7.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> On some architectures (like ARM64), it can support CONT-PTE/PMD size
> hugetlb, which means it can support not only PMD/PUD size hugetlb:
> 2M and 1G, but also CONT-PTE/PMD size: 64K and 32M if a 4K page
> size specified.
>
> When unmapping a hugetlb page, we will get the relevant page table
> entry by huge_pte_offset() only once to nuke it. This is correct
> for PMD or PUD size hugetlb, since they always contain only one
> pmd entry or pud entry in the page table.
>
> However this is incorrect for CONT-PTE and CONT-PMD size hugetlb,
> since they can contain several continuous pte or pmd entry with
> same page table attributes, so we will nuke only one pte or pmd
> entry for this CONT-PTE/PMD size hugetlb page.
>
> And now we only use try_to_unmap() to unmap a poisoned hugetlb page,
Since try_to_unmap can be called for non-hugetlb pages, perhaps the following
is more accurate?
try_to_unmap is only passed a hugetlb page in the case where the
hugetlb page is poisoned.
It does concern me that this assumption is built into the code as
pointed out in your discussion with Gerald. Should we perhaps add
a VM_BUG_ON() to make sure the passed huge page is poisoned? This
would be in the same 'if block' where we call
adjust_range_if_pmd_sharing_possible.
--
Mike Kravetz
> which means now we will unmap only one pte entry for a CONT-PTE or
> CONT-PMD size poisoned hugetlb page, and we can still access other
> subpages of a CONT-PTE or CONT-PMD size poisoned hugetlb page,
> which will cause serious issues possibly.
>
> So we should change to use huge_ptep_clear_flush() to nuke the
> hugetlb page table to fix this issue, which already considered
> CONT-PTE and CONT-PMD size hugetlb.
>
> Note we've already used set_huge_swap_pte_at() to set a poisoned
> swap entry for a poisoned hugetlb page.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> mm/rmap.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: dalias@libc.org, linux-ia64@vger.kernel.org,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
James.Bottomley@HansenPartnership.com, linux-mm@kvack.org,
paulus@samba.org, sparclinux@vger.kernel.org,
agordeev@linux.ibm.com, linux-arch@vger.kernel.org,
linux-s390@vger.kernel.org, arnd@arndb.de,
ysato@users.sourceforge.jp, deller@gmx.de,
borntraeger@linux.ibm.com, gor@linux.ibm.com, hca@linux.ibm.com,
linux-arm-kernel@lists.infradead.org, tsbogend@alpha.franken.de,
linux-parisc@vger.kernel.org, linux-mips@vger.kernel.org,
svens@linux.ibm.com, linuxppc-dev@lists.ozlabs.org,
davem@davemloft.net
Subject: Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping
Date: Fri, 6 May 2022 11:55:13 -0700 [thread overview]
Message-ID: <f64f0d4f-f0fc-f07c-3c17-96f124da21e4@oracle.com> (raw)
In-Reply-To: <c91e04ebb792ef7b72966edea8bd6fa2dfa5bfa7.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> On some architectures (like ARM64), it can support CONT-PTE/PMD size
> hugetlb, which means it can support not only PMD/PUD size hugetlb:
> 2M and 1G, but also CONT-PTE/PMD size: 64K and 32M if a 4K page
> size specified.
>
> When unmapping a hugetlb page, we will get the relevant page table
> entry by huge_pte_offset() only once to nuke it. This is correct
> for PMD or PUD size hugetlb, since they always contain only one
> pmd entry or pud entry in the page table.
>
> However this is incorrect for CONT-PTE and CONT-PMD size hugetlb,
> since they can contain several continuous pte or pmd entry with
> same page table attributes, so we will nuke only one pte or pmd
> entry for this CONT-PTE/PMD size hugetlb page.
>
> And now we only use try_to_unmap() to unmap a poisoned hugetlb page,
Since try_to_unmap can be called for non-hugetlb pages, perhaps the following
is more accurate?
try_to_unmap is only passed a hugetlb page in the case where the
hugetlb page is poisoned.
It does concern me that this assumption is built into the code as
pointed out in your discussion with Gerald. Should we perhaps add
a VM_BUG_ON() to make sure the passed huge page is poisoned? This
would be in the same 'if block' where we call
adjust_range_if_pmd_sharing_possible.
--
Mike Kravetz
> which means now we will unmap only one pte entry for a CONT-PTE or
> CONT-PMD size poisoned hugetlb page, and we can still access other
> subpages of a CONT-PTE or CONT-PMD size poisoned hugetlb page,
> which will cause serious issues possibly.
>
> So we should change to use huge_ptep_clear_flush() to nuke the
> hugetlb page table to fix this issue, which already considered
> CONT-PTE and CONT-PMD size hugetlb.
>
> Note we've already used set_huge_swap_pte_at() to set a poisoned
> swap entry for a poisoned hugetlb page.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> mm/rmap.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping
Date: Fri, 6 May 2022 11:55:13 -0700 [thread overview]
Message-ID: <f64f0d4f-f0fc-f07c-3c17-96f124da21e4@oracle.com> (raw)
In-Reply-To: <c91e04ebb792ef7b72966edea8bd6fa2dfa5bfa7.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> On some architectures (like ARM64), it can support CONT-PTE/PMD size
> hugetlb, which means it can support not only PMD/PUD size hugetlb:
> 2M and 1G, but also CONT-PTE/PMD size: 64K and 32M if a 4K page
> size specified.
>
> When unmapping a hugetlb page, we will get the relevant page table
> entry by huge_pte_offset() only once to nuke it. This is correct
> for PMD or PUD size hugetlb, since they always contain only one
> pmd entry or pud entry in the page table.
>
> However this is incorrect for CONT-PTE and CONT-PMD size hugetlb,
> since they can contain several continuous pte or pmd entry with
> same page table attributes, so we will nuke only one pte or pmd
> entry for this CONT-PTE/PMD size hugetlb page.
>
> And now we only use try_to_unmap() to unmap a poisoned hugetlb page,
Since try_to_unmap can be called for non-hugetlb pages, perhaps the following
is more accurate?
try_to_unmap is only passed a hugetlb page in the case where the
hugetlb page is poisoned.
It does concern me that this assumption is built into the code as
pointed out in your discussion with Gerald. Should we perhaps add
a VM_BUG_ON() to make sure the passed huge page is poisoned? This
would be in the same 'if block' where we call
adjust_range_if_pmd_sharing_possible.
--
Mike Kravetz
> which means now we will unmap only one pte entry for a CONT-PTE or
> CONT-PMD size poisoned hugetlb page, and we can still access other
> subpages of a CONT-PTE or CONT-PMD size poisoned hugetlb page,
> which will cause serious issues possibly.
>
> So we should change to use huge_ptep_clear_flush() to nuke the
> hugetlb page table to fix this issue, which already considered
> CONT-PTE and CONT-PMD size hugetlb.
>
> Note we've already used set_huge_swap_pte_at() to set a poisoned
> swap entry for a poisoned hugetlb page.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> mm/rmap.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Mike Kravetz <mike.kravetz@oracle.com>
To: Baolin Wang <baolin.wang@linux.alibaba.com>,
akpm@linux-foundation.org, catalin.marinas@arm.com,
will@kernel.org
Cc: tsbogend@alpha.franken.de, James.Bottomley@HansenPartnership.com,
deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
paulus@samba.org, hca@linux.ibm.com, gor@linux.ibm.com,
agordeev@linux.ibm.com, borntraeger@linux.ibm.com,
svens@linux.ibm.com, ysato@users.sourceforge.jp, dalias@libc.org,
davem@davemloft.net, arnd@arndb.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-ia64@vger.kernel.org,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org,
linux-sh@vger.kernel.org, sparclinux@vger.kernel.org,
linux-arch@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping
Date: Fri, 06 May 2022 18:55:13 +0000 [thread overview]
Message-ID: <f64f0d4f-f0fc-f07c-3c17-96f124da21e4@oracle.com> (raw)
In-Reply-To: <c91e04ebb792ef7b72966edea8bd6fa2dfa5bfa7.1651216964.git.baolin.wang@linux.alibaba.com>
On 4/29/22 01:14, Baolin Wang wrote:
> On some architectures (like ARM64), it can support CONT-PTE/PMD size
> hugetlb, which means it can support not only PMD/PUD size hugetlb:
> 2M and 1G, but also CONT-PTE/PMD size: 64K and 32M if a 4K page
> size specified.
>
> When unmapping a hugetlb page, we will get the relevant page table
> entry by huge_pte_offset() only once to nuke it. This is correct
> for PMD or PUD size hugetlb, since they always contain only one
> pmd entry or pud entry in the page table.
>
> However this is incorrect for CONT-PTE and CONT-PMD size hugetlb,
> since they can contain several continuous pte or pmd entry with
> same page table attributes, so we will nuke only one pte or pmd
> entry for this CONT-PTE/PMD size hugetlb page.
>
> And now we only use try_to_unmap() to unmap a poisoned hugetlb page,
Since try_to_unmap can be called for non-hugetlb pages, perhaps the following
is more accurate?
try_to_unmap is only passed a hugetlb page in the case where the
hugetlb page is poisoned.
It does concern me that this assumption is built into the code as
pointed out in your discussion with Gerald. Should we perhaps add
a VM_BUG_ON() to make sure the passed huge page is poisoned? This
would be in the same 'if block' where we call
adjust_range_if_pmd_sharing_possible.
--
Mike Kravetz
> which means now we will unmap only one pte entry for a CONT-PTE or
> CONT-PMD size poisoned hugetlb page, and we can still access other
> subpages of a CONT-PTE or CONT-PMD size poisoned hugetlb page,
> which will cause serious issues possibly.
>
> So we should change to use huge_ptep_clear_flush() to nuke the
> hugetlb page table to fix this issue, which already considered
> CONT-PTE and CONT-PMD size hugetlb.
>
> Note we've already used set_huge_swap_pte_at() to set a poisoned
> swap entry for a poisoned hugetlb page.
>
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> mm/rmap.c | 34 +++++++++++++++++-----------------
> 1 file changed, 17 insertions(+), 17 deletions(-)
next prev parent reply other threads:[~2022-05-06 18:56 UTC|newest]
Thread overview: 88+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 8:14 [PATCH 0/3] Fix CONT-PTE/PMD size hugetlb issue when unmapping or migrating Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` [PATCH 1/3] mm: change huge_ptep_clear_flush() to return the original pte Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-05-05 23:15 ` Mike Kravetz
2022-05-05 23:15 ` Mike Kravetz
2022-05-05 23:15 ` Mike Kravetz
2022-05-05 23:15 ` Mike Kravetz
2022-05-06 3:02 ` Baolin Wang
2022-05-06 3:02 ` Baolin Wang
2022-05-06 3:02 ` Baolin Wang
2022-05-06 3:02 ` Baolin Wang
2022-04-29 8:14 ` [PATCH 2/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when migration Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-05-05 23:53 ` Mike Kravetz
2022-05-05 23:53 ` Mike Kravetz
2022-05-05 23:53 ` Mike Kravetz
2022-05-05 23:53 ` Mike Kravetz
2022-05-06 3:39 ` Baolin Wang
2022-05-06 3:39 ` Baolin Wang
2022-05-06 3:39 ` Baolin Wang
2022-05-06 3:39 ` Baolin Wang
2022-05-06 17:56 ` Mike Kravetz
2022-05-06 17:56 ` Mike Kravetz
2022-05-06 17:56 ` Mike Kravetz
2022-05-06 17:56 ` Mike Kravetz
2022-05-07 2:33 ` Baolin Wang
2022-05-07 2:33 ` Baolin Wang
2022-05-07 2:33 ` Baolin Wang
2022-05-07 2:33 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-05-08 9:19 ` Baolin Wang
2022-04-29 8:14 ` [PATCH 3/3] mm: rmap: Fix CONT-PTE/PMD size hugetlb issue when unmapping Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 8:14 ` Baolin Wang
2022-04-29 20:02 ` Gerald Schaefer
2022-04-29 20:02 ` Gerald Schaefer
2022-04-29 20:02 ` Gerald Schaefer
2022-04-29 20:02 ` Gerald Schaefer
2022-04-30 3:22 ` Baolin Wang
2022-04-30 3:22 ` Baolin Wang
2022-04-30 3:22 ` Baolin Wang
2022-04-30 3:22 ` Baolin Wang
2022-05-02 14:02 ` Gerald Schaefer
2022-05-02 14:02 ` Gerald Schaefer
2022-05-02 14:02 ` Gerald Schaefer
2022-05-02 14:02 ` Gerald Schaefer
2022-05-03 2:19 ` Baolin Wang
2022-05-03 2:19 ` Baolin Wang
2022-05-03 2:19 ` Baolin Wang
2022-05-03 2:19 ` Baolin Wang
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 10:03 ` Gerald Schaefer
2022-05-03 13:33 ` Baolin Wang
2022-05-03 13:33 ` Baolin Wang
2022-05-03 13:33 ` Baolin Wang
2022-05-03 13:33 ` Baolin Wang
2022-05-06 19:07 ` Mike Kravetz
2022-05-06 19:07 ` Mike Kravetz
2022-05-06 19:07 ` Mike Kravetz
2022-05-06 19:07 ` Mike Kravetz
2022-05-09 16:41 ` Peter Xu
2022-05-09 16:41 ` Peter Xu
2022-05-09 16:41 ` Peter Xu
2022-05-09 16:41 ` Peter Xu
2022-05-10 1:28 ` Baolin Wang
2022-05-10 1:28 ` Baolin Wang
2022-05-10 1:28 ` Baolin Wang
2022-05-10 1:28 ` Baolin Wang
2022-05-06 18:55 ` Mike Kravetz [this message]
2022-05-06 18:55 ` Mike Kravetz
2022-05-06 18:55 ` Mike Kravetz
2022-05-06 18:55 ` Mike Kravetz
2022-05-07 1:32 ` Baolin Wang
2022-05-07 1:32 ` Baolin Wang
2022-05-07 1:32 ` Baolin Wang
2022-05-07 1:32 ` Baolin Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f64f0d4f-f0fc-f07c-3c17-96f124da21e4@oracle.com \
--to=mike.kravetz@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=agordeev@linux.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=baolin.wang@linux.alibaba.com \
--cc=benh@kernel.crashing.org \
--cc=borntraeger@linux.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=dalias@libc.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=gor@linux.ibm.com \
--cc=hca@linux.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=sparclinux@vger.kernel.org \
--cc=svens@linux.ibm.com \
--cc=tsbogend@alpha.franken.de \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.