Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support.

From: Matthieu CASTET <matthieu.castet@parrot.com>
To: Murali Nalajala <mnalajal@codeaurora.org>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
	"Dima Zavin" <dima@android.com>,
	"Arve Hjønnevåg" <arve@android.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"Brian Swetland" <swetland@google.com>,
	"dwmw2@infradead.org" <dwmw2@infradead.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/2] mtd: msm_nand: Add initial msm nand driver support.
Date: Mon, 18 Apr 2011 09:32:14 +0200	[thread overview]
Message-ID: <4DABE8FE.5040300@parrot.com> (raw)
In-Reply-To: <1302938249-4601-1-git-send-email-mnalajal@codeaurora.org>

Hi,

Murali Nalajala a écrit :
> Add initial msm nand driver support for Qualcomm MSM platforms.
> This driver is capable of handling both 2k and 4k page support
> nand devices.
> 
> This driver was originally developed by Arve Hjønnevåg at google.
> Its source is available at
> http://android.git.kernel.org/?p=kernel/msm.git under
> android-msm-2.6.35 branch.
> 
> CC: Dima Zavin <dima@android.com>
> CC: Brian Swetland <swetland@google.com>
> CC: Arve Hjønnevåg <arve@android.com>
> Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>
> ---
> Changes in V2
> * Turn most of the pr_info() calls into pr_debug().
> 
>  drivers/mtd/devices/Kconfig    |   11 +
>  drivers/mtd/devices/Makefile   |    1 +
>  drivers/mtd/devices/msm_nand.c | 1597 ++++++++++++++++++++++++++++++++++++++++
>  drivers/mtd/devices/msm_nand.h |   77 ++
>  4 files changed, 1686 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mtd/devices/msm_nand.c
>  create mode 100644 drivers/mtd/devices/msm_nand.h
> 

For the record, I am not sure it is a great idea to make nand drivers
independent of the nand layer.
By doing that you could change the expected behavior, and introduce bug
difficult to debug.

Why do you need that ? Nand drivers can override callbacks of nand framework.

Maybe because the nand layer call the driver page per page, and  you want to
work with more than one page. But in this case you can extend nand layer.

Or does your controller don't allow sending raw command ?
And in that case all the nand logic is in the nand controller ?

Matthieu

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel