From: Andi Kleen <ak@linux.intel.com>
To: Will Deacon <will.deacon@arm.com>
Cc: "Catalin Marinas" <catalin.marinas@arm.com>,
"Måns Rullgård" <mans@mansr.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
sam@ravnborg.org
Subject: Re: [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP
Date: Thu, 26 May 2011 12:58:40 -0700 [thread overview]
Message-ID: <4DDEB0F0.3010101@linux.intel.com> (raw)
In-Reply-To: <1306429854.26735.9.camel@e102144-lin.cambridge.arm.com>
> So it sounds like we might not want to enable this blindly across all
> architectures. Indeed, on ARM, it encourages the compiler to pack
> variables on the stack which leads to the weird and wonderful alignment
> situation that has been encountered in this thread.
Interesting. I'm pretty sure it didn't do that when I added the flag.
Anyways making it a CONFIG is fine for me. Just don't set it on ARM. It
should be set on x86
at least.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: ak@linux.intel.com (Andi Kleen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP
Date: Thu, 26 May 2011 12:58:40 -0700 [thread overview]
Message-ID: <4DDEB0F0.3010101@linux.intel.com> (raw)
In-Reply-To: <1306429854.26735.9.camel@e102144-lin.cambridge.arm.com>
> So it sounds like we might not want to enable this blindly across all
> architectures. Indeed, on ARM, it encourages the compiler to pack
> variables on the stack which leads to the weird and wonderful alignment
> situation that has been encountered in this thread.
Interesting. I'm pretty sure it didn't do that when I added the flag.
Anyways making it a CONFIG is fine for me. Just don't set it on ARM. It
should be set on x86
at least.
-Andi
next prev parent reply other threads:[~2011-05-26 19:58 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-23 11:16 [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP Catalin Marinas
2011-05-23 12:30 ` Måns Rullgård
2011-05-23 13:25 ` Russell King - ARM Linux
2011-05-23 13:21 ` Russell King - ARM Linux
2011-05-23 13:51 ` Catalin Marinas
2011-05-23 14:37 ` Måns Rullgård
2011-05-23 14:41 ` Catalin Marinas
2011-05-23 14:52 ` Russell King - ARM Linux
2011-05-24 9:39 ` Catalin Marinas
2011-05-24 14:17 ` Måns Rullgård
2011-05-24 15:26 ` Catalin Marinas
2011-05-24 16:23 ` Måns Rullgård
2011-05-24 17:26 ` Nicolas Pitre
2011-05-24 17:13 ` Dave Martin
2011-05-25 11:14 ` Catalin Marinas
2011-05-25 12:43 ` Dave Martin
2011-05-25 13:32 ` Måns Rullgård
2011-05-25 14:05 ` Dave Martin
2011-05-25 14:48 ` Måns Rullgård
2011-05-25 14:50 ` Catalin Marinas
2011-05-25 14:53 ` Måns Rullgård
2011-05-26 17:10 ` Will Deacon
2011-05-26 17:10 ` Will Deacon
2011-05-26 18:14 ` Måns Rullgård
2011-05-26 18:14 ` Måns Rullgård
2011-05-26 19:58 ` Andi Kleen [this message]
2011-05-26 19:58 ` Andi Kleen
2011-05-26 21:03 ` Nicolas Pitre
2011-05-26 21:03 ` Nicolas Pitre
2011-05-26 21:10 ` Andi Kleen
2011-05-26 21:10 ` Andi Kleen
2011-05-26 21:26 ` Måns Rullgård
2011-05-26 21:26 ` Måns Rullgård
2011-05-27 10:05 ` Will Deacon
2011-05-27 10:05 ` Will Deacon
2011-05-27 16:53 ` Andi Kleen
2011-05-27 16:53 ` Andi Kleen
2011-05-26 21:51 ` Russell King - ARM Linux
2011-05-26 21:51 ` Russell King - ARM Linux
2011-05-26 22:29 ` Andi Kleen
2011-05-26 22:29 ` Andi Kleen
2011-05-27 8:38 ` Catalin Marinas
2011-05-27 8:38 ` Catalin Marinas
2011-05-27 8:54 ` Russell King - ARM Linux
2011-05-27 8:54 ` Russell King - ARM Linux
2011-05-27 9:51 ` Catalin Marinas
2011-05-27 9:51 ` Catalin Marinas
2011-05-27 9:56 ` Catalin Marinas
2011-05-27 9:56 ` Catalin Marinas
2011-05-27 12:46 ` Måns Rullgård
2011-05-27 12:46 ` Måns Rullgård
2011-05-28 15:34 ` [PATCH] Disable -fconserve-stack on ARM Andi Kleen
2011-05-28 15:34 ` Andi Kleen
2011-05-31 16:30 ` Catalin Marinas
2011-05-31 16:30 ` Catalin Marinas
2011-05-31 18:01 ` Andi Kleen
2011-05-31 18:01 ` Andi Kleen
2011-06-02 13:08 ` Catalin Marinas
2011-06-02 13:08 ` Catalin Marinas
[not found] <mailman.254.1306496353.1533.linux-arm-kernel@lists.infradead.org>
2011-05-27 12:14 ` [PATCH] ARM: Do not allow unaligned accesses when CONFIG_ALIGNMENT_TRAP Frank Hofmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DDEB0F0.3010101@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=sam@ravnborg.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.