From: Stephen Boyd <sboyd@codeaurora.org> To: Russell King - ARM Linux <linux@arm.linux.org.uk> Cc: Will Deacon <will.deacon@arm.com>, Arnd Bergmann <arnd@arndb.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Date: Mon, 19 Sep 2011 15:55:10 -0700 [thread overview] Message-ID: <4E77C84E.9040202@codeaurora.org> (raw) In-Reply-To: <20110919224151.GB28237@n2100.arm.linux.org.uk> On 09/19/11 15:41, Russell King - ARM Linux wrote: > On Mon, Sep 19, 2011 at 03:12:04PM -0700, Stephen Boyd wrote: >> On 09/19/11 14:25, Will Deacon wrote: >>> Thanks for cooking the patch, it was somewhere on my list of things to do >>> this week! I think we also need to fix the DEBUG_DC21285_PORT option as that >>> has a similar `if not selected then use a different UART' behaviour. It can be >>> fixed in the same way as you have done in this patch.' >> Ah my eyes glossed over the DC21285 one. Here's one on top of patch 2. >> Feel free to squash, etc. > Err, the DC21285 only has one serial port. > > Some footbridge platforms expose the DC21285 to the outside world, others > don't. Some footbridge platforms have a separate 8250 UART at the standard > PCI COM1 address, others don't. > > What DEBUG_DC21285_PORT is selecting between is whether to use the DC21285 > port (when set) or the 8250 at PCI COM1 (when unset). Ah ok. How about this instead? diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 9661c51..31896f4 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -93,14 +93,19 @@ choice It does include a timeout to ensure that the system does not totally freeze when there is nothing connected to read. + config DEBUG_FOOTBRIDGE_COM1 + bool "Kernel low-level debugging messages via footbridge 8250 at PCI COM1" + depends on FOOTBRIDGE + help + Say Y here if you want the debug print routines to direct + their output to the 8250 at PCI COM1. + config DEBUG_DC21285_PORT bool "Kernel low-level debugging messages via footbridge serial port" depends on FOOTBRIDGE help Say Y here if you want the debug print routines to direct their output to the serial port in the DC21285 (Footbridge). - Saying N will cause the debug messages to appear on the first - 16550 serial port. config DEBUG_CLPS711X_UART1 bool "Kernel low-level debugging messages via UART1" -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
WARNING: multiple messages have this Message-ID (diff)
From: sboyd@codeaurora.org (Stephen Boyd) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Date: Mon, 19 Sep 2011 15:55:10 -0700 [thread overview] Message-ID: <4E77C84E.9040202@codeaurora.org> (raw) In-Reply-To: <20110919224151.GB28237@n2100.arm.linux.org.uk> On 09/19/11 15:41, Russell King - ARM Linux wrote: > On Mon, Sep 19, 2011 at 03:12:04PM -0700, Stephen Boyd wrote: >> On 09/19/11 14:25, Will Deacon wrote: >>> Thanks for cooking the patch, it was somewhere on my list of things to do >>> this week! I think we also need to fix the DEBUG_DC21285_PORT option as that >>> has a similar `if not selected then use a different UART' behaviour. It can be >>> fixed in the same way as you have done in this patch.' >> Ah my eyes glossed over the DC21285 one. Here's one on top of patch 2. >> Feel free to squash, etc. > Err, the DC21285 only has one serial port. > > Some footbridge platforms expose the DC21285 to the outside world, others > don't. Some footbridge platforms have a separate 8250 UART at the standard > PCI COM1 address, others don't. > > What DEBUG_DC21285_PORT is selecting between is whether to use the DC21285 > port (when set) or the 8250 at PCI COM1 (when unset). Ah ok. How about this instead? diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug index 9661c51..31896f4 100644 --- a/arch/arm/Kconfig.debug +++ b/arch/arm/Kconfig.debug @@ -93,14 +93,19 @@ choice It does include a timeout to ensure that the system does not totally freeze when there is nothing connected to read. + config DEBUG_FOOTBRIDGE_COM1 + bool "Kernel low-level debugging messages via footbridge 8250 at PCI COM1" + depends on FOOTBRIDGE + help + Say Y here if you want the debug print routines to direct + their output to the 8250 at PCI COM1. + config DEBUG_DC21285_PORT bool "Kernel low-level debugging messages via footbridge serial port" depends on FOOTBRIDGE help Say Y here if you want the debug print routines to direct their output to the serial port in the DC21285 (Footbridge). - Saying N will cause the debug messages to appear on the first - 16550 serial port. config DEBUG_CLPS711X_UART1 bool "Kernel low-level debugging messages via UART1" -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-09-19 22:55 UTC|newest] Thread overview: 86+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-16 21:41 [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Will Deacon 2011-08-16 21:41 ` [PATCH 2/3] ARM: plat-samsung: use Kconfig choice for debug UART selection Will Deacon 2011-10-10 11:56 ` Thomas Abraham 2011-10-10 11:56 ` Thomas Abraham 2011-10-10 12:23 ` Will Deacon 2011-10-10 12:23 ` Will Deacon 2011-10-10 12:35 ` Thomas Abraham 2011-10-10 12:35 ` Thomas Abraham 2011-10-10 13:34 ` Will Deacon 2011-10-10 13:34 ` Will Deacon 2011-10-10 13:38 ` Thomas Abraham 2011-10-10 13:38 ` Thomas Abraham 2011-08-16 21:41 ` [PATCH 3/3] ARM: realview: " Will Deacon 2011-08-18 4:06 ` [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Nicolas Pitre 2011-08-18 9:33 ` Will Deacon 2011-08-18 16:11 ` Shawn Guo 2011-08-18 16:07 ` Will Deacon 2011-08-19 4:59 ` Shawn Guo 2011-08-19 11:08 ` Will Deacon 2011-08-19 11:37 ` Shawn Guo 2011-08-19 12:32 ` Will Deacon 2011-08-19 15:49 ` Nicolas Pitre 2011-08-21 9:14 ` Russell King - ARM Linux 2011-08-21 17:35 ` Nicolas Pitre 2011-08-21 18:26 ` Russell King - ARM Linux 2011-08-21 19:02 ` Nicolas Pitre 2011-08-21 19:18 ` Russell King - ARM Linux 2011-08-21 19:22 ` Russell King - ARM Linux 2011-08-21 20:07 ` Nicolas Pitre 2011-08-21 20:54 ` Russell King - ARM Linux 2011-08-21 21:00 ` Nicolas Pitre 2011-08-21 21:29 ` Russell King - ARM Linux 2011-08-21 22:00 ` Nicolas Pitre 2011-08-21 19:53 ` Nicolas Pitre 2011-09-06 9:28 ` Tony Lindgren 2011-09-06 9:37 ` Russell King - ARM Linux 2011-09-06 10:27 ` Tony Lindgren 2011-09-06 10:52 ` Russell King - ARM Linux 2011-09-06 11:01 ` Tony Lindgren 2011-09-06 11:07 ` Russell King - ARM Linux 2011-09-06 19:45 ` Uwe Kleine-König 2011-08-19 14:54 ` Nicolas Pitre 2011-08-19 4:56 ` [PATCH] arm/imx: use Kconfig choice for low-level debug UART selection Shawn Guo 2011-08-19 6:35 ` Sascha Hauer 2011-08-19 7:00 ` Shawn Guo 2011-08-19 11:09 ` Will Deacon 2011-08-19 11:39 ` Sascha Hauer 2011-08-19 12:35 ` Will Deacon 2011-08-19 17:15 ` Sascha Hauer 2011-08-21 9:18 ` Russell King - ARM Linux 2011-08-21 11:25 ` Will Deacon 2011-08-21 17:59 ` Nicolas Pitre 2011-08-21 18:17 ` Russell King - ARM Linux 2011-08-21 18:28 ` Nicolas Pitre 2011-08-21 18:33 ` Russell King - ARM Linux 2011-11-22 8:58 ` Uwe Kleine-König 2011-11-22 11:50 ` Will Deacon 2011-11-22 13:02 ` Uwe Kleine-König 2011-11-22 13:20 ` Will Deacon 2011-11-22 13:30 ` Uwe Kleine-König 2011-11-22 15:48 ` Russell King - ARM Linux 2011-11-22 16:38 ` Uwe Kleine-König 2011-11-22 16:47 ` Mark Brown 2011-11-22 17:13 ` Uwe Kleine-König 2011-11-22 20:24 ` Russell King - ARM Linux 2011-11-22 21:19 ` Arnd Bergmann 2011-11-22 23:00 ` Mark Brown 2011-11-23 10:57 ` Will Deacon 2011-09-15 17:34 ` [PATCH 1/3] ARM: debug: use kconfig choice for selecting DEBUG_LL UART Stephen Boyd 2011-09-16 11:41 ` Will Deacon 2011-09-19 18:01 ` [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Stephen Boyd 2011-09-19 18:01 ` Stephen Boyd 2011-09-19 18:01 ` [PATCH 2/2] ARM: debug: Move DEBUG_ICEDCC into the DEBUG_LL choice Stephen Boyd 2011-09-19 18:01 ` Stephen Boyd 2011-09-19 21:25 ` [PATCH 1/2] ARM: debug: Add CLSP711X_UART1 config choice Will Deacon 2011-09-19 21:25 ` Will Deacon 2011-09-19 22:12 ` Stephen Boyd 2011-09-19 22:12 ` Stephen Boyd 2011-09-19 22:41 ` Russell King - ARM Linux 2011-09-19 22:41 ` Russell King - ARM Linux 2011-09-19 22:55 ` Stephen Boyd [this message] 2011-09-19 22:55 ` Stephen Boyd 2011-11-22 20:42 ` Russell King - ARM Linux 2011-11-22 20:42 ` Russell King - ARM Linux 2011-09-19 23:14 ` Will Deacon 2011-09-19 23:14 ` Will Deacon
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4E77C84E.9040202@codeaurora.org \ --to=sboyd@codeaurora.org \ --cc=arnd@arndb.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@arm.linux.org.uk \ --cc=will.deacon@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.