From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tamseel Shams <m.shams@samsung.com>,
jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzk+dt@kernel.org
Cc: geert@linux-m68k.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, alim.akhtar@samsung.com,
paul@crapouillou.net, linux-fsd@tesla.com
Subject: Re: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant
Date: Mon, 23 May 2022 12:16:38 +0200 [thread overview]
Message-ID: <4cbbd4c2-6d39-da8e-d0fc-c49ba9b8ae7d@linaro.org> (raw)
In-Reply-To: <20220520145820.67667-2-m.shams@samsung.com>
On 20/05/2022 16:58, Tamseel Shams wrote:
> From: Alim Akhtar <alim.akhtar@samsung.com>
>
> This patch adds a new compatible string for FSD-HW's
> ADC variant
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> - Changes since v1
> * Addressed Krzysztof's comment to use soc-specific compatible
>
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 81c87295912c..ded0e3f85991 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - samsung,exynos-adc-v1 # Exynos5250
> - samsung,exynos-adc-v2
> + - samsung,exynos-adc-fsd-hw
The soc is fsd, so compatible should rather be:
tesla,fsd-adc
What does the "HW" mean?
> - samsung,exynos3250-adc
> - samsung,exynos4212-adc # Exynos4212 and Exynos4412
> - samsung,exynos7-adc
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tamseel Shams <m.shams@samsung.com>,
jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
krzk+dt@kernel.org
Cc: geert@linux-m68k.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-iio@vger.kernel.org, alim.akhtar@samsung.com,
paul@crapouillou.net, linux-fsd@tesla.com
Subject: Re: [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant
Date: Mon, 23 May 2022 12:16:38 +0200 [thread overview]
Message-ID: <4cbbd4c2-6d39-da8e-d0fc-c49ba9b8ae7d@linaro.org> (raw)
In-Reply-To: <20220520145820.67667-2-m.shams@samsung.com>
On 20/05/2022 16:58, Tamseel Shams wrote:
> From: Alim Akhtar <alim.akhtar@samsung.com>
>
> This patch adds a new compatible string for FSD-HW's
> ADC variant
>
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> - Changes since v1
> * Addressed Krzysztof's comment to use soc-specific compatible
>
> .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index 81c87295912c..ded0e3f85991 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -14,6 +14,7 @@ properties:
> enum:
> - samsung,exynos-adc-v1 # Exynos5250
> - samsung,exynos-adc-v2
> + - samsung,exynos-adc-fsd-hw
The soc is fsd, so compatible should rather be:
tesla,fsd-adc
What does the "HW" mean?
> - samsung,exynos3250-adc
> - samsung,exynos4212-adc # Exynos4212 and Exynos4412
> - samsung,exynos7-adc
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-23 10:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20220520145757epcas5p145e5546f71fe836ad6d6a5f1b40459ec@epcas5p1.samsung.com>
2022-05-20 14:58 ` [PATCH v2 0/3] Adds support of ADC for FSD SoC Tamseel Shams
2022-05-20 14:58 ` Tamseel Shams
[not found] ` <CGME20220520145759epcas5p240de0ce6d1a1bfea6c8a6bfb61c5d27d@epcas5p2.samsung.com>
2022-05-20 14:58 ` [PATCH v2 1/3] dt-bindings: iio: adc: Add FSD-HW variant Tamseel Shams
2022-05-20 14:58 ` Tamseel Shams
2022-05-23 10:16 ` Krzysztof Kozlowski [this message]
2022-05-23 10:16 ` Krzysztof Kozlowski
2022-05-31 8:27 ` m.shams
2022-05-31 8:27 ` m.shams
[not found] ` <CGME20220520145802epcas5p2153cb572493e3bccd702e0ecce1171fb@epcas5p2.samsung.com>
2022-05-20 14:58 ` [PATCH v2 2/3] iio: adc: exynos-adc: Add support for ADC FSD-HW controller Tamseel Shams
2022-05-20 14:58 ` Tamseel Shams
2022-05-22 11:25 ` Jonathan Cameron
2022-05-22 11:25 ` Jonathan Cameron
2022-05-31 8:42 ` m.shams
2022-05-31 8:42 ` m.shams
2022-06-03 15:10 ` Jonathan Cameron
2022-06-03 15:10 ` Jonathan Cameron
2022-05-23 10:20 ` Krzysztof Kozlowski
2022-05-23 10:20 ` Krzysztof Kozlowski
2022-05-31 8:29 ` m.shams
2022-05-31 8:29 ` m.shams
[not found] ` <CGME20220520145804epcas5p2925e66d30b18378fc62c92999ec269f7@epcas5p2.samsung.com>
2022-05-20 14:58 ` [PATCH v2 3/3] arm64: dts: fsd: Add ADC device tree node Tamseel Shams
2022-05-20 14:58 ` Tamseel Shams
2022-05-23 10:22 ` Krzysztof Kozlowski
2022-05-23 10:22 ` Krzysztof Kozlowski
2022-05-31 8:32 ` m.shams
2022-05-31 8:32 ` m.shams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cbbd4c2-6d39-da8e-d0fc-c49ba9b8ae7d@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-fsd@tesla.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.shams@samsung.com \
--cc=paul@crapouillou.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.