Re: [PATCH v2 3/3] arm64: dts: fsd: Add ADC device tree node

From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Tamseel Shams <m.shams@samsung.com>,
	jic23@kernel.org, lars@metafoo.de, robh+dt@kernel.org,
	krzk+dt@kernel.org
Cc: geert@linux-m68k.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-iio@vger.kernel.org, alim.akhtar@samsung.com,
	paul@crapouillou.net, linux-fsd@tesla.com
Subject: Re: [PATCH v2 3/3] arm64: dts: fsd: Add ADC device tree node
Date: Mon, 23 May 2022 12:22:14 +0200	[thread overview]
Message-ID: <d04b6d8c-0117-b5a6-dcb5-aa328ad5d1f5@linaro.org> (raw)
In-Reply-To: <20220520145820.67667-4-m.shams@samsung.com>

On 20/05/2022 16:58, Tamseel Shams wrote:
> From: Alim Akhtar <alim.akhtar@samsung.com>
> 
> This patch adds ADC device tree node and enables the same
> on fsd platform.
> 
> Signed-off-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Tamseel Shams <m.shams@samsung.com>
> ---
> - Changes since v1
> * Addressed Krzysztof's comment for corrections in dt files
> 
>  arch/arm64/boot/dts/tesla/fsd-evb.dts |  4 ++++
>  arch/arm64/boot/dts/tesla/fsd.dtsi    | 11 +++++++++++
>  2 files changed, 15 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> index 5af560c1b5e6..63f26a85053a 100644
> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> @@ -34,6 +34,10 @@
>  	clock-frequency = <24000000>;
>  };
>  
> +&adc {
> +	status = "okay";

Please test your bindings (`make dtbs_check`). There is no way it passes
since you miss at least supply (maybe more?).

Best regards,
Krzysztof