From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Russell King <linux@arm.linux.org.uk>,
Jason Cooper <jason@lakedaemon.net>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Rabeeh Khoury <rabeeh@solid-run.com>,
Ian Molton <ian.molton@codethink.co.uk>,
Arnd Bergmann <arnd@arndb.de>, Maen Suleiman <maen@marvell.com>,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 1/6] ARM: dove: unify clock setup
Date: Sat, 11 Aug 2012 11:38:59 +0200 [thread overview]
Message-ID: <50262833.2010601@gmail.com> (raw)
In-Reply-To: <20120811091255.GA31809@lunn.ch>
On 08/11/2012 11:12 AM, Andrew Lunn wrote:
>> + /* Ensure tclk is always clocked */
>> + clk_prepare_enable(tclk);
>> }
>
> "ticking" would be better than clocked.
>
> Since this is a root fixed clock, is it necessary to prepare_enable()
> it? I think prepare and enable become NOPs in this situation.
Hi Andrew,
yes you are right, it is useless to prepare or enable a fixed rate clk.
I cannot be gated anyway. I'll update the patch and resend soon.
Sebastian
WARNING: multiple messages have this Message-ID (diff)
From: sebastian.hesselbarth@gmail.com (Sebastian Hesselbarth)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: dove: unify clock setup
Date: Sat, 11 Aug 2012 11:38:59 +0200 [thread overview]
Message-ID: <50262833.2010601@gmail.com> (raw)
In-Reply-To: <20120811091255.GA31809@lunn.ch>
On 08/11/2012 11:12 AM, Andrew Lunn wrote:
>> + /* Ensure tclk is always clocked */
>> + clk_prepare_enable(tclk);
>> }
>
> "ticking" would be better than clocked.
>
> Since this is a root fixed clock, is it necessary to prepare_enable()
> it? I think prepare and enable become NOPs in this situation.
Hi Andrew,
yes you are right, it is useless to prepare or enable a fixed rate clk.
I cannot be gated anyway. I'll update the patch and resend soon.
Sebastian
next prev parent reply other threads:[~2012-08-11 9:39 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-06 12:23 [PATCH 0/6] ARM: dove: DT support for Marvell Dove Sebastian Hesselbarth
2012-08-06 12:23 ` Sebastian Hesselbarth
2012-08-06 12:23 ` [PATCH 1/6] ARM: dove: unify clock setup Sebastian Hesselbarth
2012-08-06 12:23 ` Sebastian Hesselbarth
2012-08-11 9:12 ` Andrew Lunn
2012-08-11 9:12 ` Andrew Lunn
2012-08-11 9:38 ` Sebastian Hesselbarth [this message]
2012-08-11 9:38 ` Sebastian Hesselbarth
2012-08-06 12:23 ` [PATCH 2/6] ARM: dove: add clock gating control Sebastian Hesselbarth
2012-08-06 12:23 ` Sebastian Hesselbarth
2012-08-06 12:23 ` [PATCH 3/6] ARM: dove: add crypto engine Sebastian Hesselbarth
2012-08-06 12:23 ` Sebastian Hesselbarth
2012-08-06 12:23 ` [PATCH 4/6] ARM: dove: add device tree based machine descriptor Sebastian Hesselbarth
2012-08-06 12:23 ` Sebastian Hesselbarth
2012-08-06 12:23 ` [PATCH 5/6] ARM: dove: add device tree descriptors Sebastian Hesselbarth
2012-08-06 12:23 ` Sebastian Hesselbarth
2012-08-06 12:23 ` [PATCH 6/6] ARM: dove: SolidRun CuBox DT Sebastian Hesselbarth
2012-08-06 12:23 ` Sebastian Hesselbarth
2012-08-06 14:02 ` [PATCH 0/6] ARM: dove: DT support for Marvell Dove Arnd Bergmann
2012-08-06 14:02 ` Arnd Bergmann
2012-08-06 14:16 ` Sebastian Hesselbarth
2012-08-06 14:16 ` Sebastian Hesselbarth
2012-08-06 14:23 ` Arnd Bergmann
2012-08-06 14:23 ` Arnd Bergmann
2012-08-07 16:53 ` Russell King - ARM Linux
2012-08-07 16:53 ` Russell King - ARM Linux
2012-08-07 19:32 ` Sebastian Hesselbarth
2012-08-07 19:32 ` Sebastian Hesselbarth
2012-08-11 10:35 ` [PATCH v2 " Sebastian Hesselbarth
2012-08-11 10:35 ` Sebastian Hesselbarth
2012-08-11 10:35 ` [PATCH v2 1/6] ARM: dove: unify clock setup Sebastian Hesselbarth
2012-08-11 10:35 ` Sebastian Hesselbarth
2012-08-11 10:35 ` [PATCH v2 2/6] ARM: dove: add clock gating control Sebastian Hesselbarth
2012-08-11 10:35 ` Sebastian Hesselbarth
2012-08-12 15:22 ` Andrew Lunn
2012-08-12 15:22 ` Andrew Lunn
2012-08-11 10:35 ` [PATCH v2 3/6] ARM: dove: add crypto engine Sebastian Hesselbarth
2012-08-11 10:35 ` Sebastian Hesselbarth
2012-08-11 10:35 ` [PATCH v2 4/6] ARM: dove: add device tree based machine descriptor Sebastian Hesselbarth
2012-08-11 10:35 ` Sebastian Hesselbarth
2012-08-11 10:35 ` [PATCH v2 5/6] ARM: dove: add device tree descriptors Sebastian Hesselbarth
2012-08-11 10:35 ` Sebastian Hesselbarth
2012-08-11 10:35 ` [PATCH v2 6/6] ARM: dove: SolidRun CuBox DT Sebastian Hesselbarth
2012-08-11 10:35 ` Sebastian Hesselbarth
2012-08-15 17:07 ` [PATCH v3 0/6] ARM: dove: DT support for Marvell Dove Sebastian Hesselbarth
2012-08-15 17:07 ` Sebastian Hesselbarth
2012-08-15 17:07 ` [PATCH v3 1/6] ARM: dove: unify clock setup Sebastian Hesselbarth
2012-08-15 17:07 ` Sebastian Hesselbarth
2012-08-15 17:07 ` [PATCH v3 2/6] ARM: dove: add clock gating control Sebastian Hesselbarth
2012-08-15 17:07 ` Sebastian Hesselbarth
2012-08-15 17:07 ` [PATCH v3 3/6] ARM: dove: add crypto engine Sebastian Hesselbarth
2012-08-15 17:07 ` Sebastian Hesselbarth
2012-08-15 17:07 ` [PATCH v3 4/6] ARM: dove: add device tree based machine descriptor Sebastian Hesselbarth
2012-08-15 17:07 ` Sebastian Hesselbarth
2012-08-15 17:07 ` [PATCH v3 5/6] ARM: dove: add device tree descriptors Sebastian Hesselbarth
2012-08-15 17:07 ` Sebastian Hesselbarth
2012-08-15 17:07 ` [PATCH v3 6/6] ARM: dove: SolidRun CuBox DT Sebastian Hesselbarth
2012-08-15 17:07 ` Sebastian Hesselbarth
2012-09-10 2:41 ` [PATCH v3 0/6] ARM: dove: DT support for Marvell Dove Jason Cooper
2012-09-10 2:41 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50262833.2010601@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=andrew@lunn.ch \
--cc=arnd@arndb.de \
--cc=ian.molton@codethink.co.uk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=maen@marvell.com \
--cc=olof@lixom.net \
--cc=rabeeh@solid-run.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.