From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
linux-media@vger.kernel.org, kyungmin.park@samsung.com,
kgene.kim@samsung.com, rob.herring@calxeda.com,
prabhakar.lad@ti.com, devicetree-discuss@lists.ozlabs.org,
linux-samsung-soc@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 06/10] s5p-fimc: Use pinctrl API for camera ports configuration
Date: Sat, 09 Feb 2013 00:30:54 +0100 [thread overview]
Message-ID: <51158AAE.7050003@gmail.com> (raw)
In-Reply-To: <5112EAF6.1040408@wwwdotorg.org>
On 02/07/2013 12:44 AM, Stephen Warren wrote:
> On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote:
>> Before the camera ports can be used the pinmux needs to be configured
>> properly. This patch adds a function to set the camera ports pinctrl
>> to a default state within the media driver's probe().
>> The camera port(s) are then configured for the video bus operation.
>
>> diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt
>
>> +- pinctrl-names : pinctrl names for camera port pinmux control, at least
>> + "default" needs to be specified.
>> +- pinctrl-0...N : pinctrl properties corresponding to pinctrl-names
>> +
>
> A reference to the binding document describing the pin control bindings
> would be appropriate here. Given that reference, I'm not sure if
> spelling out the property names makes sense since it feels a little like
> duplication; an alternative might be simply:
>
> The pinctrl bindings defined in ../../../pinctrl/pinctrl-bindings.txt
> must be used to define a pinctrl state named "default".
OK, I will add a reference to the pinctrl bindings instead.
> However, this isn't a big deal; it's fine either way.
--
Thanks.
Sylwester
WARNING: multiple messages have this Message-ID (diff)
From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 06/10] s5p-fimc: Use pinctrl API for camera ports configuration
Date: Sat, 09 Feb 2013 00:30:54 +0100 [thread overview]
Message-ID: <51158AAE.7050003@gmail.com> (raw)
In-Reply-To: <5112EAF6.1040408@wwwdotorg.org>
On 02/07/2013 12:44 AM, Stephen Warren wrote:
> On 02/01/2013 12:09 PM, Sylwester Nawrocki wrote:
>> Before the camera ports can be used the pinmux needs to be configured
>> properly. This patch adds a function to set the camera ports pinctrl
>> to a default state within the media driver's probe().
>> The camera port(s) are then configured for the video bus operation.
>
>> diff --git a/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt b/Documentation/devicetree/bindings/media/soc/samsung-fimc.txt
>
>> +- pinctrl-names : pinctrl names for camera port pinmux control, at least
>> + "default" needs to be specified.
>> +- pinctrl-0...N : pinctrl properties corresponding to pinctrl-names
>> +
>
> A reference to the binding document describing the pin control bindings
> would be appropriate here. Given that reference, I'm not sure if
> spelling out the property names makes sense since it feels a little like
> duplication; an alternative might be simply:
>
> The pinctrl bindings defined in ../../../pinctrl/pinctrl-bindings.txt
> must be used to define a pinctrl state named "default".
OK, I will add a reference to the pinctrl bindings instead.
> However, this isn't a big deal; it's fine either way.
--
Thanks.
Sylwester
next prev parent reply other threads:[~2013-02-08 23:30 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 19:09 [PATCH v4 00/10] Device tree support for Exynos SoC camera subsystem Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 01/10] s5p-csis: Add device tree support Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-06 23:36 ` Stephen Warren
2013-02-06 23:36 ` Stephen Warren
2013-02-08 22:29 ` Sylwester Nawrocki
2013-02-08 22:29 ` Sylwester Nawrocki
2013-02-08 23:27 ` Stephen Warren
2013-02-08 23:27 ` Stephen Warren
2013-02-09 0:31 ` Sylwester Nawrocki
2013-02-09 0:31 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 02/10] s5p-fimc: Add device tree support for FIMC devices Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-06 23:40 ` Stephen Warren
2013-02-06 23:40 ` Stephen Warren
2013-02-08 23:16 ` Sylwester Nawrocki
2013-02-08 23:16 ` Sylwester Nawrocki
2013-02-08 23:21 ` Stephen Warren
2013-02-08 23:21 ` Stephen Warren
2013-02-09 0:05 ` Sylwester Nawrocki
2013-02-09 0:05 ` Sylwester Nawrocki
2013-02-09 0:32 ` Stephen Warren
2013-02-09 0:32 ` Stephen Warren
2013-02-09 22:29 ` Sylwester Nawrocki
2013-02-09 22:29 ` Sylwester Nawrocki
2013-02-09 22:52 ` Sylwester Nawrocki
2013-02-09 22:52 ` Sylwester Nawrocki
2013-02-11 21:50 ` Stephen Warren
2013-02-11 21:50 ` Stephen Warren
2013-02-12 22:39 ` Sylwester Nawrocki
2013-02-12 22:39 ` Sylwester Nawrocki
2013-02-13 20:42 ` Stephen Warren
2013-02-13 20:42 ` Stephen Warren
2013-02-14 23:03 ` Sylwester Nawrocki
2013-02-14 23:03 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 03/10] s5p-fimc: Add device tree support for FIMC-LITE devices Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 04/10] s5p-fimc: Add device tree support for the main media device driver Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 05/10] s5p-fimc: Add device tree based sensors registration Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-06 23:42 ` Stephen Warren
2013-02-06 23:42 ` Stephen Warren
2013-02-08 23:26 ` Sylwester Nawrocki
2013-02-08 23:26 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 06/10] s5p-fimc: Use pinctrl API for camera ports configuration Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-06 23:44 ` Stephen Warren
2013-02-06 23:44 ` Stephen Warren
2013-02-08 23:30 ` Sylwester Nawrocki [this message]
2013-02-08 23:30 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 07/10] ARM: dts: Add camera to node exynos4.dtsi Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 08/10] ARM: dts: Add ISP power domain node for Exynos4x12 Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 09/10] ARM: dts: Add FIMC and MIPI CSIS device nodes " Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
2013-02-01 19:09 ` [PATCH v4 10/10] ARM: dts: Correct camera pinctrl nodes for Exynos4x12 SoCs Sylwester Nawrocki
2013-02-01 19:09 ` Sylwester Nawrocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51158AAE.7050003@gmail.com \
--to=sylvester.nawrocki@gmail.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kgene.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=prabhakar.lad@ti.com \
--cc=rob.herring@calxeda.com \
--cc=s.nawrocki@samsung.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.