All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Murphy <dmurphy@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	<devicetree@vger.kernel.org>, <linux-doc@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-omap@vger.kernel.org>, <linux-pci@vger.kernel.org>
Cc: <rogerq@ti.com>, <balajitk@ti.com>
Subject: Re: [TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node
Date: Tue, 6 May 2014 08:40:40 -0500	[thread overview]
Message-ID: <5368E658.1040209@ti.com> (raw)
In-Reply-To: <1399383244-14556-18-git-send-email-kishon@ti.com>

On 05/06/2014 08:34 AM, Kishon Vijay Abraham I wrote:
> Added *resets* and *reset-names* properies for PCIe dt node.
> The documention for this node can be found @ ../bindings/pci/ti-pci.txt.
>
> Cc: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 20b1a09..7bc0555 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1031,6 +1031,8 @@
>  			ti,hwmods = "pcie1";
>  			phys = <&pcie1_phy>;
>  			phy-names = "pcie-phy";
> +			resets = <&prm_resets &device_reset>;

If you look @ v2 of the reset framework patchset your phandle should be

resets = <&prm_resets &pcie1_reset>;

If you call the device_reset phandle you will reset the SoC.


> +			reset-names = "reset";

This needs to be more descriptive.

>  		};
>  
>  		sata: sata@4a141100 {


-- 
------------------
Dan Murphy


WARNING: multiple messages have this Message-ID (diff)
From: Dan Murphy <dmurphy@ti.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
	devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
	linux-pci@vger.kernel.org
Cc: balajitk@ti.com, rogerq@ti.com
Subject: Re: [TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node
Date: Tue, 6 May 2014 08:40:40 -0500	[thread overview]
Message-ID: <5368E658.1040209@ti.com> (raw)
In-Reply-To: <1399383244-14556-18-git-send-email-kishon@ti.com>

On 05/06/2014 08:34 AM, Kishon Vijay Abraham I wrote:
> Added *resets* and *reset-names* properies for PCIe dt node.
> The documention for this node can be found @ ../bindings/pci/ti-pci.txt.
>
> Cc: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 20b1a09..7bc0555 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1031,6 +1031,8 @@
>  			ti,hwmods = "pcie1";
>  			phys = <&pcie1_phy>;
>  			phy-names = "pcie-phy";
> +			resets = <&prm_resets &device_reset>;

If you look @ v2 of the reset framework patchset your phandle should be

resets = <&prm_resets &pcie1_reset>;

If you call the device_reset phandle you will reset the SoC.


> +			reset-names = "reset";

This needs to be more descriptive.

>  		};
>  
>  		sata: sata@4a141100 {


-- 
------------------
Dan Murphy

WARNING: multiple messages have this Message-ID (diff)
From: dmurphy@ti.com (Dan Murphy)
To: linux-arm-kernel@lists.infradead.org
Subject: [TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node
Date: Tue, 6 May 2014 08:40:40 -0500	[thread overview]
Message-ID: <5368E658.1040209@ti.com> (raw)
In-Reply-To: <1399383244-14556-18-git-send-email-kishon@ti.com>

On 05/06/2014 08:34 AM, Kishon Vijay Abraham I wrote:
> Added *resets* and *reset-names* properies for PCIe dt node.
> The documention for this node can be found @ ../bindings/pci/ti-pci.txt.
>
> Cc: Dan Murphy <dmurphy@ti.com>
> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
> ---
>  arch/arm/boot/dts/dra7.dtsi |    2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
> index 20b1a09..7bc0555 100644
> --- a/arch/arm/boot/dts/dra7.dtsi
> +++ b/arch/arm/boot/dts/dra7.dtsi
> @@ -1031,6 +1031,8 @@
>  			ti,hwmods = "pcie1";
>  			phys = <&pcie1_phy>;
>  			phy-names = "pcie-phy";
> +			resets = <&prm_resets &device_reset>;

If you look @ v2 of the reset framework patchset your phandle should be

resets = <&prm_resets &pcie1_reset>;

If you call the device_reset phandle you will reset the SoC.


> +			reset-names = "reset";

This needs to be more descriptive.

>  		};
>  
>  		sata: sata at 4a141100 {


-- 
------------------
Dan Murphy

  reply	other threads:[~2014-05-06 13:41 UTC|newest]

Thread overview: 195+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-06 13:33 [PATCH 00/17] PCIe support for DRA7xx Kishon Vijay Abraham I
2014-05-06 13:33 ` Kishon Vijay Abraham I
2014-05-06 13:33 ` Kishon Vijay Abraham I
2014-05-06 13:33 ` [PATCH 01/17] phy: phy-omap-pipe3: Add support for PCIe PHY Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-14 12:57   ` Roger Quadros
2014-05-14 12:57     ` Roger Quadros
2014-05-14 12:57     ` Roger Quadros
2014-05-06 13:33 ` [PATCH 02/17] phy: omap-control: add external clock " Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-14 13:02   ` Roger Quadros
2014-05-14 13:02     ` Roger Quadros
2014-05-14 13:02     ` Roger Quadros
2014-05-06 13:33 ` [PATCH 03/17] phy: ti-pipe3: " Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-14 13:16   ` Roger Quadros
2014-05-14 13:16     ` Roger Quadros
2014-05-14 13:16     ` Roger Quadros
2014-05-14 15:19     ` Kishon Vijay Abraham I
2014-05-14 15:19       ` Kishon Vijay Abraham I
2014-05-14 15:19       ` Kishon Vijay Abraham I
2014-05-14 15:34       ` Nishanth Menon
2014-05-14 15:34         ` Nishanth Menon
2014-05-14 15:34         ` Nishanth Menon
2014-05-15  9:15         ` Kishon Vijay Abraham I
2014-05-15  9:15           ` Kishon Vijay Abraham I
2014-05-15  9:15           ` Kishon Vijay Abraham I
2014-05-15  9:15           ` Kishon Vijay Abraham I
2014-05-15  9:25           ` Roger Quadros
2014-05-15  9:25             ` Roger Quadros
2014-05-15  9:25             ` Roger Quadros
2014-05-15  9:25             ` Roger Quadros
2014-05-15 11:46             ` Nishanth Menon
2014-05-15 11:46               ` Nishanth Menon
2014-05-15 11:46               ` Nishanth Menon
2014-05-15 11:59               ` Kishon Vijay Abraham I
2014-05-15 11:59                 ` Kishon Vijay Abraham I
2014-05-15 11:59                 ` Kishon Vijay Abraham I
2014-05-15 11:59                 ` Kishon Vijay Abraham I
2014-05-15 12:12                 ` Nishanth Menon
2014-05-15 12:12                   ` Nishanth Menon
2014-05-15 12:12                   ` Nishanth Menon
2014-05-15 12:18                   ` Kishon Vijay Abraham I
2014-05-15 12:18                     ` Kishon Vijay Abraham I
2014-05-15 12:18                     ` Kishon Vijay Abraham I
2014-05-15 12:18                     ` Kishon Vijay Abraham I
2014-05-15 12:33                     ` Nishanth Menon
2014-05-15 12:33                       ` Nishanth Menon
2014-05-15 12:33                       ` Nishanth Menon
2014-05-15 12:33                       ` Nishanth Menon
2014-05-15 12:42                       ` Kishon Vijay Abraham I
2014-05-15 12:42                         ` Kishon Vijay Abraham I
2014-05-15 12:42                         ` Kishon Vijay Abraham I
2014-05-15 12:42                         ` Kishon Vijay Abraham I
2014-05-27  6:11                       ` Kishon Vijay Abraham I
2014-05-27  6:11                         ` Kishon Vijay Abraham I
2014-05-27  6:11                         ` Kishon Vijay Abraham I
2014-05-27  6:11                         ` Kishon Vijay Abraham I
2014-05-28  1:54                       ` Mike Turquette
2014-05-28  1:54                         ` Mike Turquette
2014-05-28  1:54                         ` Mike Turquette
2014-05-28  1:54                         ` Mike Turquette
2014-05-28 15:52                         ` Nishanth Menon
2014-05-28 15:52                           ` Nishanth Menon
2014-05-28 15:52                           ` Nishanth Menon
2014-05-06 13:33 ` [PATCH 04/17] phy: pipe3: insert delay to enumerate in GEN2 mode Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-14 13:20   ` Roger Quadros
2014-05-14 13:20     ` Roger Quadros
2014-05-14 13:20     ` Roger Quadros
2014-05-06 13:33 ` [PATCH 05/17] pci: host: pcie-dra7xx: add support for pcie-dra7xx controller Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:44   ` Marek Vasut
2014-05-06 13:44     ` Marek Vasut
2014-05-07  8:21     ` Kishon Vijay Abraham I
2014-05-07  8:21       ` Kishon Vijay Abraham I
2014-05-07  8:21       ` Kishon Vijay Abraham I
2014-05-09  9:43     ` Pavel Machek
2014-05-09  9:43       ` Pavel Machek
2014-05-09  9:43       ` Pavel Machek
2014-05-06 13:54   ` Arnd Bergmann
2014-05-06 13:54     ` Arnd Bergmann
2014-05-06 13:54     ` Arnd Bergmann
2014-05-07  8:44     ` Kishon Vijay Abraham I
2014-05-07  8:44       ` Kishon Vijay Abraham I
2014-05-07  8:44       ` Kishon Vijay Abraham I
2014-05-07  9:30       ` Arnd Bergmann
2014-05-07  9:30         ` Arnd Bergmann
2014-05-09 11:29         ` Kishon Vijay Abraham I
2014-05-09 11:29           ` Kishon Vijay Abraham I
2014-05-09 11:29           ` Kishon Vijay Abraham I
2014-05-06 16:35   ` Jason Gunthorpe
2014-05-06 16:35     ` Jason Gunthorpe
2014-05-07  9:22     ` Kishon Vijay Abraham I
2014-05-07  9:22       ` Kishon Vijay Abraham I
2014-05-07  9:22       ` Kishon Vijay Abraham I
2014-05-07  9:25       ` Arnd Bergmann
2014-05-07  9:25         ` Arnd Bergmann
2014-05-08  8:56         ` Jingoo Han
2014-05-08  8:56           ` Jingoo Han
2014-05-08  9:16           ` Arnd Bergmann
2014-05-08  9:16             ` Arnd Bergmann
2014-05-06 13:33 ` [PATCH 06/17] pci: host: pcie-designware: Use *base-mask* for configuring the iATU Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:59   ` Arnd Bergmann
2014-05-06 13:59     ` Arnd Bergmann
2014-05-08  9:05     ` Jingoo Han
2014-05-08  9:05       ` Jingoo Han
2014-05-08  9:05       ` Jingoo Han
2014-05-08  9:18       ` Arnd Bergmann
2014-05-08  9:18         ` Arnd Bergmann
2014-05-09 11:50         ` Kishon Vijay Abraham I
2014-05-09 11:50           ` Kishon Vijay Abraham I
2014-05-09 11:50           ` Kishon Vijay Abraham I
2014-05-12  1:44           ` Jingoo Han
2014-05-12  1:44             ` Jingoo Han
2014-05-13 12:31         ` Kishon Vijay Abraham I
2014-05-13 12:31           ` Kishon Vijay Abraham I
2014-05-13 12:31           ` Kishon Vijay Abraham I
2014-05-13 12:47           ` Arnd Bergmann
2014-05-13 12:47             ` Arnd Bergmann
2014-05-13 12:47             ` Arnd Bergmann
2014-05-13 13:26             ` Kishon Vijay Abraham I
2014-05-13 13:26               ` Kishon Vijay Abraham I
2014-05-13 13:26               ` Kishon Vijay Abraham I
2014-05-13 13:27               ` Arnd Bergmann
2014-05-13 13:27                 ` Arnd Bergmann
2014-05-13 13:27                 ` Arnd Bergmann
2014-05-13 13:34                 ` Arnd Bergmann
2014-05-13 13:34                   ` Arnd Bergmann
2014-05-13 13:34                   ` Arnd Bergmann
2014-05-14  5:44                   ` Kishon Vijay Abraham I
2014-05-14  5:44                     ` Kishon Vijay Abraham I
2014-05-14  5:44                     ` Kishon Vijay Abraham I
2014-05-14 12:45                     ` Arnd Bergmann
2014-05-14 12:45                       ` Arnd Bergmann
2014-05-14 15:04                       ` Kishon Vijay Abraham I
2014-05-14 15:04                         ` Kishon Vijay Abraham I
2014-05-14 15:04                         ` Kishon Vijay Abraham I
2014-05-16  9:00                       ` Kishon Vijay Abraham I
2014-05-16  9:00                         ` Kishon Vijay Abraham I
2014-05-16  9:00                         ` Kishon Vijay Abraham I
2014-05-19 12:45                         ` Arnd Bergmann
2014-05-19 12:45                           ` Arnd Bergmann
2014-05-06 13:33 ` [PATCH 07/17] ARM: dts: DRA7: Add divider table to optfclk_pciephy_div clock Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33 ` [PATCH 08/17] ARM: dts: DRA7: Change the parent of apll_pcie_in_clk_mux to dpll_pcie_ref_m2ldo_ck Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33 ` [PATCH 09/17] arm: dra7xx: Add hwmod data for pcie1 phy and pcie2 phy Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33 ` [PATCH 10/17] arm: dra7xx: Add hwmod data for pcie1 and pcie2 subsystems Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33 ` [PATCH 11/17] ARM: dts: dra7xx-clocks: Add missing 32khz clocks used for PHY Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-14 13:23   ` Roger Quadros
2014-05-14 13:23     ` Roger Quadros
2014-05-14 13:23     ` Roger Quadros
2014-05-14 15:19     ` Kishon Vijay Abraham I
2014-05-14 15:19       ` Kishon Vijay Abraham I
2014-05-14 15:19       ` Kishon Vijay Abraham I
2014-05-06 13:33 ` [PATCH 12/17] ARM: dts: dra7: Add dt data for PCIe PHY control module Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33 ` [PATCH 13/17] ARM: dts: dra7: Add dt data for PCIe PHY Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:33   ` Kishon Vijay Abraham I
2014-05-06 13:34 ` [PATCH 14/17] ARM: dts: dra7: Add dt data for PCIe controller Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:34 ` [PATCH 15/17] ARM: OMAP: Enable PCI for DRA7 Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:34 ` [TEMP PATCH 16/17] pci: host: pcie-dra7xx: use reset framework APIs to reset PCIe Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:41   ` Dan Murphy
2014-05-06 13:41     ` Dan Murphy
2014-05-06 13:41     ` Dan Murphy
2014-05-06 13:34 ` [TEMP PATCH 17/17] ARM: dts: dra7: Add *resets* property for PCIe dt node Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:34   ` Kishon Vijay Abraham I
2014-05-06 13:40   ` Dan Murphy [this message]
2014-05-06 13:40     ` Dan Murphy
2014-05-06 13:40     ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5368E658.1040209@ti.com \
    --to=dmurphy@ti.com \
    --cc=balajitk@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rogerq@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.