From: Nitesh Narayan Lal <nitesh@redhat.com> To: David Hildenbrand <david@redhat.com>, Alexander Duyck <alexander.duyck@gmail.com> Cc: kvm list <kvm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, virtio-dev@lists.oasis-open.org, Paolo Bonzini <pbonzini@redhat.com>, lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, Yang Zhang <yang.zhang.wz@gmail.com>, Rik van Riel <riel@surriel.com>, "Michael S. Tsirkin" <mst@redhat.com>, dodgen@google.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, dhildenb@redhat.com, Andrea Arcangeli <aarcange@redhat.com>, john.starks@microsoft.com, Dave Hansen <dave.hansen@intel.com>, Michal Hocko <mhocko@suse.com>, cohuck@redhat.com Subject: Re: [RFC][Patch v12 1/2] mm: page_reporting: core infrastructure Date: Tue, 13 Aug 2019 06:42:41 -0400 [thread overview] Message-ID: <53fb1343-3b18-a566-aaa5-90a1d99d7333@redhat.com> (raw) In-Reply-To: <32f61f87-6205-5001-866c-a84e20fc9d85@redhat.com> On 8/13/19 6:34 AM, David Hildenbrand wrote: >>>>> +static int process_free_page(struct page *page, >>>>> + struct page_reporting_config *phconf, int count) >>>>> +{ >>>>> + int mt, order, ret = 0; [...] >>>>> +/** >>>>> + * zone_reporting_init - For each zone initializes the page reporting fields >>>>> + * and allocates the respective bitmap. >>>>> + * >>>>> + * This function returns 0 on successful initialization, -ENOMEM otherwise. >>>>> + */ >>>>> +static int zone_reporting_init(void) >>>>> +{ >>>>> + struct zone *zone; >>>>> + int ret; >>>>> + >>>>> + for_each_populated_zone(zone) { >>>>> +#ifdef CONFIG_ZONE_DEVICE >>>>> + /* we can not report pages which are not in the buddy */ >>>>> + if (zone_idx(zone) == ZONE_DEVICE) >>>>> + continue; >>>>> +#endif >>>> I'm pretty sure this isn't needed since I don't think the ZONE_DEVICE >>>> zone will be considered "populated". >>>> >>> I think you are right (although it's confusing, we will have present >>> sections part of a zone but the zone has no present_pages - screams like >>> a re factoring - leftover from ZONE_DEVICE introduction). >> >> I think in that case it is safe to have this check here. >> What do you guys suggest? > If it's not needed, I'd say drop it (eventually add a comment). Comment to mention that we do not expect a zone with non-buddy page to be initialized here? > > -- Thanks Nitesh
WARNING: multiple messages have this Message-ID (diff)
From: Nitesh Narayan Lal <nitesh@redhat.com> To: David Hildenbrand <david@redhat.com>, Alexander Duyck <alexander.duyck@gmail.com> Cc: kvm list <kvm@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>, linux-mm <linux-mm@kvack.org>, virtio-dev@lists.oasis-open.org, Paolo Bonzini <pbonzini@redhat.com>, lcapitulino@redhat.com, pagupta@redhat.com, wei.w.wang@intel.com, Yang Zhang <yang.zhang.wz@gmail.com>, Rik van Riel <riel@surriel.com>, "Michael S. Tsirkin" <mst@redhat.com>, dodgen@google.com, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>, dhildenb@redhat.com, Andrea Arcangeli <aarcange@redhat.com>, john.starks@microsoft.com, Dave Hansen <dave.hansen@intel.com>, Michal Hocko <mhocko@suse.com>, cohuck@redhat.com Subject: [virtio-dev] Re: [RFC][Patch v12 1/2] mm: page_reporting: core infrastructure Date: Tue, 13 Aug 2019 06:42:41 -0400 [thread overview] Message-ID: <53fb1343-3b18-a566-aaa5-90a1d99d7333@redhat.com> (raw) In-Reply-To: <32f61f87-6205-5001-866c-a84e20fc9d85@redhat.com> On 8/13/19 6:34 AM, David Hildenbrand wrote: >>>>> +static int process_free_page(struct page *page, >>>>> + struct page_reporting_config *phconf, int count) >>>>> +{ >>>>> + int mt, order, ret = 0; [...] >>>>> +/** >>>>> + * zone_reporting_init - For each zone initializes the page reporting fields >>>>> + * and allocates the respective bitmap. >>>>> + * >>>>> + * This function returns 0 on successful initialization, -ENOMEM otherwise. >>>>> + */ >>>>> +static int zone_reporting_init(void) >>>>> +{ >>>>> + struct zone *zone; >>>>> + int ret; >>>>> + >>>>> + for_each_populated_zone(zone) { >>>>> +#ifdef CONFIG_ZONE_DEVICE >>>>> + /* we can not report pages which are not in the buddy */ >>>>> + if (zone_idx(zone) == ZONE_DEVICE) >>>>> + continue; >>>>> +#endif >>>> I'm pretty sure this isn't needed since I don't think the ZONE_DEVICE >>>> zone will be considered "populated". >>>> >>> I think you are right (although it's confusing, we will have present >>> sections part of a zone but the zone has no present_pages - screams like >>> a re factoring - leftover from ZONE_DEVICE introduction). >> >> I think in that case it is safe to have this check here. >> What do you guys suggest? > If it's not needed, I'd say drop it (eventually add a comment). Comment to mention that we do not expect a zone with non-buddy page to be initialized here? > > -- Thanks Nitesh --------------------------------------------------------------------- To unsubscribe, e-mail: virtio-dev-unsubscribe@lists.oasis-open.org For additional commands, e-mail: virtio-dev-help@lists.oasis-open.org
next prev parent reply other threads:[~2019-08-13 10:43 UTC|newest] Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-08-12 13:12 [RFC][PATCH v12 0/2] mm: Support for page reporting Nitesh Narayan Lal 2019-08-12 13:12 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-12 13:12 ` [RFC][Patch v12 1/2] mm: page_reporting: core infrastructure Nitesh Narayan Lal 2019-08-12 13:12 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-12 18:47 ` Alexander Duyck 2019-08-12 18:47 ` [virtio-dev] " Alexander Duyck 2019-08-12 18:47 ` Alexander Duyck 2019-08-12 20:04 ` Nitesh Narayan Lal 2019-08-12 20:04 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-20 14:11 ` Nitesh Narayan Lal 2019-08-20 14:11 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-12 20:05 ` David Hildenbrand 2019-08-12 20:05 ` [virtio-dev] " David Hildenbrand 2019-08-13 10:30 ` Nitesh Narayan Lal 2019-08-13 10:30 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-13 10:34 ` David Hildenbrand 2019-08-13 10:34 ` [virtio-dev] " David Hildenbrand 2019-08-13 10:42 ` Nitesh Narayan Lal [this message] 2019-08-13 10:42 ` Nitesh Narayan Lal 2019-08-13 10:44 ` David Hildenbrand 2019-08-13 10:44 ` [virtio-dev] " David Hildenbrand 2019-08-13 23:14 ` Alexander Duyck 2019-08-13 23:14 ` [virtio-dev] " Alexander Duyck 2019-08-13 23:14 ` Alexander Duyck 2019-08-14 7:07 ` David Hildenbrand 2019-08-14 7:07 ` [virtio-dev] " David Hildenbrand 2019-08-14 12:49 ` Nitesh Narayan Lal 2019-08-14 12:49 ` Nitesh Narayan Lal 2019-08-14 15:49 ` Nitesh Narayan Lal 2019-08-14 15:49 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-14 16:11 ` Alexander Duyck 2019-08-14 16:11 ` [virtio-dev] " Alexander Duyck 2019-08-14 16:11 ` Alexander Duyck 2019-08-15 13:15 ` Nitesh Narayan Lal 2019-08-15 13:15 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-15 19:22 ` Nitesh Narayan Lal 2019-08-15 19:22 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-15 23:00 ` Alexander Duyck 2019-08-15 23:00 ` [virtio-dev] " Alexander Duyck 2019-08-15 23:00 ` Alexander Duyck 2019-08-16 18:35 ` Nitesh Narayan Lal 2019-08-16 18:35 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-30 15:15 ` Nitesh Narayan Lal 2019-08-30 15:15 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-30 15:31 ` Alexander Duyck 2019-08-30 15:31 ` [virtio-dev] " Alexander Duyck 2019-08-30 15:31 ` Alexander Duyck 2019-08-30 16:05 ` Nitesh Narayan Lal 2019-08-30 16:05 ` [virtio-dev] " Nitesh Narayan Lal 2019-09-04 8:40 ` David Hildenbrand 2019-09-04 8:40 ` David Hildenbrand 2019-10-10 20:36 ` Alexander Duyck 2019-10-10 20:36 ` [virtio-dev] " Alexander Duyck 2019-10-10 20:36 ` Alexander Duyck 2019-10-11 11:02 ` Nitesh Narayan Lal 2019-10-11 11:02 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-12 13:12 ` [RFC][Patch v12 2/2] virtio-balloon: interface to support free page reporting Nitesh Narayan Lal 2019-08-12 13:12 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-14 10:29 ` Cornelia Huck 2019-08-14 10:29 ` [virtio-dev] " Cornelia Huck 2019-08-14 11:47 ` Nitesh Narayan Lal 2019-08-14 11:47 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-14 13:42 ` Cornelia Huck 2019-08-14 13:42 ` [virtio-dev] " Cornelia Huck 2019-08-14 14:01 ` Nitesh Narayan Lal 2019-08-14 14:01 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-12 13:13 ` [QEMU Patch 1/2] virtio-balloon: adding bit for page reporting support Nitesh Narayan Lal 2019-08-12 13:13 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-12 13:13 ` [QEMU Patch 2/2] virtio-balloon: support for handling page reporting Nitesh Narayan Lal 2019-08-12 13:13 ` [virtio-dev] " Nitesh Narayan Lal 2019-08-12 15:18 ` Alexander Duyck 2019-08-12 15:18 ` [virtio-dev] " Alexander Duyck 2019-08-12 15:18 ` Alexander Duyck 2019-08-12 15:26 ` Nitesh Narayan Lal 2019-08-12 15:26 ` [virtio-dev] " Nitesh Narayan Lal 2019-09-11 12:30 ` [RFC][PATCH v12 0/2] mm: Support for " David Hildenbrand 2019-09-11 12:30 ` [virtio-dev] " David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=53fb1343-3b18-a566-aaa5-90a1d99d7333@redhat.com \ --to=nitesh@redhat.com \ --cc=aarcange@redhat.com \ --cc=alexander.duyck@gmail.com \ --cc=cohuck@redhat.com \ --cc=dave.hansen@intel.com \ --cc=david@redhat.com \ --cc=dhildenb@redhat.com \ --cc=dodgen@google.com \ --cc=john.starks@microsoft.com \ --cc=konrad.wilk@oracle.com \ --cc=kvm@vger.kernel.org \ --cc=lcapitulino@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=mhocko@suse.com \ --cc=mst@redhat.com \ --cc=pagupta@redhat.com \ --cc=pbonzini@redhat.com \ --cc=riel@surriel.com \ --cc=virtio-dev@lists.oasis-open.org \ --cc=wei.w.wang@intel.com \ --cc=yang.zhang.wz@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.