From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
To: Stephen Boyd <sboyd@codeaurora.org>,
Mike Turquette <mturquette@linaro.org>
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Viresh Kumar <viresh.kumar@linaro.org>,
linux-pm@vger.kernel.org
Subject: Re: [PATCH v2 04/15] clk: divider: Make generic for usage elsewhere
Date: Tue, 07 Oct 2014 18:27:35 +0100 [thread overview]
Message-ID: <54342287.7020005@linaro.org> (raw)
In-Reply-To: <542EE5FE.9080806@codeaurora.org>
Hi Stephen,
Just noticed this regression while testing the patch on Arndale board.
https://bugs.linaro.org/show_bug.cgi?id=740
--srini
On 03/10/14 19:07, Stephen Boyd wrote:
> On 09/05/14 15:47, Stephen Boyd wrote:
>> +
>> +int divider_get_val(unsigned long rate, unsigned long parent_rate,
>> + const struct clk_div_table *table, u8 width,
>> + unsigned long flags)
>> +{
>> unsigned int div, value;
>> - unsigned long flags = 0;
>> - u32 val;
>>
>> div = DIV_ROUND_UP(parent_rate, rate);
>>
>> - if (!_is_valid_div(divider, div))
>> + if (!_is_valid_div(table, div, flags))
>> return -EINVAL;
>>
>> - value = _get_val(divider, div);
>> + value = _get_val(table, div, flags);
>> +
>> + min_t(unsigned int, value, div_mask(width));
>> +
>> + return 0;
>
> This should be return value, not return 0.
>
>> +}
>> +EXPORT_SYMBOL_GPL(divider_get_val);
>>
WARNING: multiple messages have this Message-ID (diff)
From: srinivas.kandagatla@linaro.org (Srinivas Kandagatla)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 04/15] clk: divider: Make generic for usage elsewhere
Date: Tue, 07 Oct 2014 18:27:35 +0100 [thread overview]
Message-ID: <54342287.7020005@linaro.org> (raw)
In-Reply-To: <542EE5FE.9080806@codeaurora.org>
Hi Stephen,
Just noticed this regression while testing the patch on Arndale board.
https://bugs.linaro.org/show_bug.cgi?id=740
--srini
On 03/10/14 19:07, Stephen Boyd wrote:
> On 09/05/14 15:47, Stephen Boyd wrote:
>> +
>> +int divider_get_val(unsigned long rate, unsigned long parent_rate,
>> + const struct clk_div_table *table, u8 width,
>> + unsigned long flags)
>> +{
>> unsigned int div, value;
>> - unsigned long flags = 0;
>> - u32 val;
>>
>> div = DIV_ROUND_UP(parent_rate, rate);
>>
>> - if (!_is_valid_div(divider, div))
>> + if (!_is_valid_div(table, div, flags))
>> return -EINVAL;
>>
>> - value = _get_val(divider, div);
>> + value = _get_val(table, div, flags);
>> +
>> + min_t(unsigned int, value, div_mask(width));
>> +
>> + return 0;
>
> This should be return value, not return 0.
>
>> +}
>> +EXPORT_SYMBOL_GPL(divider_get_val);
>>
next prev parent reply other threads:[~2014-10-07 17:27 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-05 22:47 [PATCH v2 00/15] Krait clocks + Krait CPUfreq Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 01/15] clk: mux: Add unregistration API Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 02/15] clk: mux: Split out register accessors for reuse Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 03/15] clk: Add __clk_mux_determine_rate_closest Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 04/15] clk: divider: Make generic for usage elsewhere Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-10-03 18:07 ` Stephen Boyd
2014-10-03 18:07 ` Stephen Boyd
2014-10-07 17:27 ` Srinivas Kandagatla [this message]
2014-10-07 17:27 ` Srinivas Kandagatla
2014-10-07 18:26 ` Stephen Boyd
2014-10-07 18:26 ` Stephen Boyd
2014-10-07 19:28 ` Srinivas Kandagatla
2014-10-07 19:28 ` Srinivas Kandagatla
2014-10-08 15:04 ` Srinivas Kandagatla
2014-10-08 15:04 ` Srinivas Kandagatla
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 05/15] clk: Add safe switch hook Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 06/15] clk: Avoid sending high rates to downstream clocks during set_rate Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 07/15] clk: qcom: Add support for High-Frequency PLLs (HFPLLs) Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 08/15] clk: qcom: Add HFPLL driver Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 09/15] clk: qcom: Add MSM8960/APQ8064's HFPLLs Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 10/15] clk: qcom: Add IPQ806X's HFPLLs Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 11/15] clk: qcom: Add support for Krait clocks Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 12/15] clk: qcom: Add KPSS ACC/GCC driver Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 13/15] clk: qcom: Add Krait clock controller driver Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 14/15] cpufreq: Add module to register cpufreq on Krait CPUs Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-08 4:46 ` Viresh Kumar
2014-09-08 4:46 ` Viresh Kumar
2014-09-08 4:46 ` Viresh Kumar
2014-09-08 17:15 ` Christopher Covington
2014-09-08 17:15 ` Christopher Covington
2014-09-08 17:15 ` Christopher Covington
2014-09-09 0:37 ` Stephen Boyd
2014-09-09 0:37 ` Stephen Boyd
2014-09-09 0:37 ` Stephen Boyd
2014-09-09 4:53 ` Viresh Kumar
2014-09-09 4:53 ` Viresh Kumar
2014-09-09 4:53 ` Viresh Kumar
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-05 22:47 ` [PATCH v2 15/15] ARM: dts: qcom: Add necessary DT data for Krait cpufreq Stephen Boyd
2014-09-05 22:47 ` Stephen Boyd
2014-09-08 9:42 ` [PATCH v2 00/15] Krait clocks + Krait CPUfreq Pramod Gurav
2014-09-08 9:42 ` Pramod Gurav
2014-09-08 9:42 ` Pramod Gurav
2014-09-08 11:59 ` Pramod Gurav
2014-09-08 11:59 ` Pramod Gurav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54342287.7020005@linaro.org \
--to=srinivas.kandagatla@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mturquette@linaro.org \
--cc=sboyd@codeaurora.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.